refactor(metrics/map): DRY up charts, decompose MapView monoliths, add test coverage (#5049)

This commit is contained in:
James Rich 2026-04-10 15:54:09 -05:00 committed by GitHub
parent 56332f4d77
commit 520fa717a9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
71 changed files with 3464 additions and 2169 deletions

View file

@ -207,7 +207,7 @@ object DeepLinkRouter {
private val nodeDetailSubRoutes: Map<String, (Int) -> Route> =
mapOf(
"device-metrics" to { destNum -> NodeDetailRoute.DeviceMetrics(destNum) },
"map" to { destNum -> NodeDetailRoute.NodeMap(destNum) },
"map" to { destNum -> NodeDetailRoute.PositionLog(destNum) },
"position" to { destNum -> NodeDetailRoute.PositionLog(destNum) },
"environment" to { destNum -> NodeDetailRoute.EnvironmentMetrics(destNum) },
"signal" to { destNum -> NodeDetailRoute.SignalMetrics(destNum) },

View file

@ -74,8 +74,6 @@ sealed interface NodesRoute : Route {
sealed interface NodeDetailRoute : Route {
@Serializable data class DeviceMetrics(val destNum: Int) : NodeDetailRoute
@Serializable data class NodeMap(val destNum: Int) : NodeDetailRoute
@Serializable data class PositionLog(val destNum: Int) : NodeDetailRoute
@Serializable data class EnvironmentMetrics(val destNum: Int) : NodeDetailRoute

View file

@ -156,7 +156,7 @@ class DeepLinkRouterTest {
listOf(
NodesRoute.NodesGraph,
NodesRoute.NodeDetailGraph(destNum = 5678),
NodeDetailRoute.NodeMap(destNum = 5678),
NodeDetailRoute.PositionLog(destNum = 5678),
),
route("/nodes/5678/map"),
)

View file

@ -62,7 +62,6 @@ class NavigationConfigTest {
NodesRoute.NodeDetail(),
// NodeDetailRoute
NodeDetailRoute.DeviceMetrics(destNum = 100),
NodeDetailRoute.NodeMap(destNum = 100),
NodeDetailRoute.PositionLog(destNum = 100),
NodeDetailRoute.EnvironmentMetrics(destNum = 100),
NodeDetailRoute.SignalMetrics(destNum = 100),