meshcore-dev/MeshCore
1
0
Fork 0
mirror of https://github.com/meshcore-dev/MeshCore.git synced 2026-04-20 22:13:47 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix LED manager issues from code review feedback

Browse source 
- Guard LED prefs read for backward compatibility with older prefs files
- Gate BLE disconnect LED update on _isEnabled to prevent stale state
- Replace hardcoded LED pins with P_LORA_TX_LED macro
- Fix inaccurate comment in WioWM1110 board init
This commit is contained in:
Ryan Gregg 2026-04-10 18:44:48 +00:00
parent e2aa33b3a0
commit 4636ce59e4
No known key found for this signature in database
5 changed files with 12 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
variants/thinknode_m1/ThinkNodeM1Board.cpp
View file

@ -15,8 +15,8 @@ void ThinkNodeM1Board::begin() {
delay(10); // give sx1262 some time to power up
// Start LEDs with defaults; prefs are applied after loadPrefs()
// LED_GREEN is active-LOW (LED_STATE_ON=LOW), P_LORA_TX_LED(13) is active-HIGH
static LEDManager _ledManager(LED_GREEN, 13, false, true);
// LED_GREEN is active-LOW (LED_STATE_ON=LOW), P_LORA_TX_LED is active-HIGH
static LEDManager _ledManager(LED_GREEN, P_LORA_TX_LED, false, true);
ledManager = &_ledManager;
ledManager->begin(LED_STATUS_BOOT_30S, LED_ACTIVITY_BOTH);
}