By replacing Emu.Stop() with GracefulShutdown() in gs_frame::close(), the game window was now unknowingly closed recursively, causing RPCS3 to crash in some cases.
Let's just ignore any consecutive calls to close() from now on.
Also don't close the window internally on a close event. request a shutdown instead.
Depending on the dpi settings, the debug overlay was almost unreadable.
I also took the liberty to refactor some redundant client size calls and to add some margin to the left of the debug text.
- fix headers
- update cursor whenever the mouse is moved
- unify cursor logic
- move m_mouse_hide_and_lock logic to handle_cursor (toggle_fullscreen is the trigger, not the handler)
- disable mouse lock and idle timer if the window is inactive
Used to access get_mouse_lock_state rather than going through the QWindow property tables.
Modify mouse hide and lock to default OFF when entering Windowed mode, and to default ON when entering Fullscreen unless 'show cursor in fullscreen' is configured
This should address the second point of #4502.
A few notes:
1. it changes the current behaviour of the 'Fullscreen cursor'. Currently it defaults to be captive. This changes it so that it defaults to NOT being captive, but can be made captive with the CTRL+L key combination.
2. There are situations when in windowed mode it's possible to escape the captivity (it's like a minigame if you will). This requires the mouse movement to exceed the bounds of the window in a single event scan. It will just show up as a temporary visibility of the cursor when outside of the window bounds. It's not too difficult to 'fix', but might not be a likely enough scenario to warrant either.
3. There currently isn't an ability to change what this keyboard combo maps to, but it's inline with a collection of other similar keyboard mappings. I think adding such a more generic keyboard mapping system (not for just keypad items, but system items.. e.g. so that Emulator stop could be mapped to something other than CTRL+S etc) is a bit out-of-scope of this particular PR.
Fixed indenting
Renamed click callback argument from 'val'->'checked'
Converted m_gui re-usage to just reference ui
Removed implicit capture from spinbox lambda
Corrected millisecond acronym from mS->ms
Removed superfluous QTimer include in gs_frame.cpp
In line with the Show Cursor in Fullscreen settings, these settings are only updated when the render window is first launched, and not during the game.
This could be revised (along with the Fullscreen Cursor) if it's more desired.
- NVIDIA drivers hook into the msq before our nativeEvent handler. This means NV is aware of events before rpcs3 is aware of them and sometimes stops until a new event is triggered.
If rpcs3 is inside a driver call at this time, the system will deadlock since the driver waits for msq which waits for the renderer which waits for the driver.
- Use explicit hook management to control window events
- Add fence timeout to attempt detection of surface loss events
* Fix gs_frame spawning on a screen other than the one the RPCS3 window is on for multi-monitor setups
* Cleaned up code & refactored it into a utility function for reuse
* Qt: take gs_frame's framemargins into account by using showEvent
- Identify minimize/restore events as separate from regular resize and do not react to them
- Enable message queue consumption after loading the shaders cache. Also hides the frame in this step
-- This fixes the 'start fullscreen' bug when running vulkan
- This communication is important in communicating window events. Helps properly synchronize swapchain management on vulkan and stops nvidia crashing
- Do not block the message queue lest the driver detect window as not responding
* Fix windows build. I made sure to do everything with a win32 prefix to not effect linux build.
* Make the window resizable instead of fixed in the corner.
* Ignore moc files and things in the debug/release folder. I might also ignore rpcs3qt.vcxproj and its filters as they're autogenerated by importing the qt project file. But, this helps clean out clutter for now.
* Add cmake. This doesn't interact with the rest of rpcs3 nor the main cmake file. That's the next thing I'm doing. I'll probably need to modify them so it'll take me time to figure out. But, this will build rpcs3qt on linux and build as is with using qt.
* The build works. I'd like to thank my friends, Google and Stackoverflow.
Setted up by importing rpcs3Qt project using Qt's visual studio plugin.
* Cleanup. Remove all the stuff in the rpcs3qt folder as its incorporated elsewhere. Remove the rpcs3qt project file as its now built into the solution and cmake doesn't care about pro files.
* Update readme to reflect getting Qt.
* Remove wxwidgets as submodule and add zlib instead. Wxwidgets was our old way of having zlib. I also added build dependencies to rpcs3qt so you should no longer get link errors on the first clean rebuild.
* Add rpcs3_version, few GUI tweaks
* Set defaultSize to 70% of screen size
* Add the view menu (#3)
* Added the view menu with the corresponding elements. Now, the debugger/log are hidden by default. The view menu has a checkbox which you click to show/hide the dock widgets.
* Make log visible by default
* Improve UI by making it into a checkbox that's easier to use.
* fix qt build for vs2017 (seems to work fine in 2015 with plugin but needs testing by other users)
* updated readme for qt
* update appveyor for qt
- cleaned formatting for the post build command
* fix build (#6)
* fix build legit this time i promise
* [Ready] Gamepadsettings (#4)
* WIP Gamepadsettings
pushbutton Eventhandling missing
* GamepadSettings should work except for cfg Init
Some KeyInputs are missing
* Update padsettingsdialog.h
* Update padsettingsdialog.cpp (#5)
* Update padsettingsdialog.cpp
removed silly tabs
* Update padsettingsdialog.cpp
* GetKeyCode simplified
* rename pad settings to keyboard settings o.O
* rename keyboard setting to input settings
* Remvoed the QT_UI defines.
* Readded new line at end of file. Replaced define in padsettings with constant.
* GUI fixes (Settings)
* Stub the logger UI. Nothing special besides a simple stub.
* Unstub the log. I haven't tested TTY but it should work.
Only thing to do, but this is in general, is add persistent settings.
* Minor refactoring to simplify code.
* Fix image loading. I'm 90% sure it works because it loads the path as expected and that's the same format I used in my gamelist implementation for the images.
* Made game lists much more functional than it was.
* mainwindow
* gamelist
* Please forgive me for I have lambdaed.
Added the ability to toggle showing columns via a context menu.
* Fix GameList further
* sort by name on init fixed
* Created the baseline refactoring. I'm going to start working on the callbacks now. May need to implement other classes in the process. Fun stuff, I know.
* adds InstallPkg (tested) and InstallPup (should work but makes unknown shenanigans) implementation
adds RefreshGameList
obliterates 10sec Refresh
* messages
* Rpcs3 gs frame (#16)
* Messing with project settings try to get trails of cold steel to boot.bluh
Definitely one change is needed in linker settings for RPCS3 to not crash immediately.
Can't even see how horribly botched my implementation of GSFrame is because we aren't booting lol. Something is gone awry with elf.
* remove random ! not that it matters much right now
* minor additions
* "Working" with debug mode though you have to ignore an assert reached from Qt. Qt is upset that the rsx thread is calling stuff on the UI thread despite not owning it. However, I can't do a thing to change that atm. (The fix would be to do what the TODO says in System.cpp-- making gsframe and stuff get initialized via system call)
Crashes due to needing pad callback to be done.
* With this build in debug mode, Trails of Cold steel will get FPS. (caveat. You have to ignore when Qt throws a debug assert lol)
* Fix release mode. Fix the Qt debug assert by using ancient occault rituals. I want to be able to remove the blocking connects but it won't work right now without it. It isn't perfect but it's good enough for now IMO.
* Add enters to the end of files.
* Removing target and setting source of events to be the application instead of the main window. The main window isn't the game window, and I don't really know what widget will be targetted for the game event. Works, though, it's admittedly probably not optimal by ANY means.
* Fix comment.
* Fix libpng wit zlib.
* Move Qt GUI into RPCS3Qt. (#17)
Restore wx GUI.
* fix install-progressdialogs randomly not showing
* install-progressdialog cosmetics
* add stylesheet file loading
* apply request
* Add stylesheet to git ignore.
* XInput..
* Joystick...
* Rpcs3 qt small fixes (#20)
* Small fixes. Have emulator stop when x button is pressed on game window. Have emulator/application stop when the main window is closed.
* If I forget another new line ending for a file.............................................
* Add CgDisasm (#21)
* fix install-progressdialogs randomly not showing
* install-progressdialog cosmetics
* add stylesheet file loading
* apply request
* add CgDisasm
add code to disable contextmenu options
fix gamelist issue
* missing proj changes
* Add ability to open stylesheets from menu.
* Mega searcher (#23)
* add MemoryStringSearcher
set minimum Sizes for mainwindow and CgDisasm
* minor fixes
* Since the system.cpp callbacks for emulator state were unused, I removed them. Then, I replaced them with callbacks for the Gui.
* added stylesheet options
setfocus on settings fixed
newline added
* added signals and slots for EmuRun and EmuStop
* update ui
update ui now works
added callback onReady
added EnableMenues
added ps3 commands
* added restart logic to menu
* newline
* event header removed
* Added graphic settings class. (#26)
* Added graphic settings class. First thing is to have the dock widgets and window size/location be stateful. Minor bug with debugger frame changing size on hide/show on default setup on second load. But, otherwise, fine. Also, the GUI doesn't update to accomodate the statefulness of the widgets. But, that'll come in time as I update this class.
* Add view debugger, logger, gamelist to settings and synchronize them.
* Separate initializing actions from connects
* Add invisible fullscreen cursor and double click event.
* Add the UI log settings.
* Add MemoryViewer (#30)
* Add Memoryviewer
Image Button crashes/not fully implemented
focus on some button annoying
minor changes for question dialogs
* GuiSettings Refactoring (#31)
* Add settings for columns shown and which one is saved
* I accidentally refactored the settings class. Added ability to reset to default GUI. Added statefulness to column widths.
* add gui tab
* Fix logging at startup.
* Preset settings.I think I ironed out MOST of the glitches. Will work on the rest of it soon. Should be a lot simpler as I won't have to use the so-called meta settings. Also, renamed all settings methods to CapitalCase.
* Removed dock widget controls.
* Added style sheets. Removed the option from the menu.
* Rewrite to use folder design. Much simpler! Yay! Simpler. Better, right?
* It's remarkable how tricky this is.
* Added convenience button to open up the settings folder in explorer
* Add newlines at end of file
* simplified logic. Fixed a bug.. hopefully not more bugs
* Fix the undocumented feature
* Make the dialog big enough to have entire text on title shown. If talkashie changes the font to size 1203482 I don't care lol
* Make warning messagebox instead of changing the title of the dialog.
* marking...
* Hcorion suggested changes.
* [WIP] autopause (#32)
* autopause added
needs fixing
headers do not show text
* fix compile stuff
* Add MsgDialog + edge widgets (#33)
* Add MsgDialog
needs magic
* add "Debugger" Buttons to menubar
* Adapt ds4 changes. I'm not sure if they work as I don't have a compatible controller. But, at the same time, it's kind of silly all I had to do was remove stdguiafx to get compilation.
* [Ready] Add KernelExplorer (#36)
* KernelExplorer added
* Fix build. Connect mainwindow to show explorer.
* qstr formatting added
hid header, fixed button size
* Taskbar Progress for install PUP/PKG (#37)
* Add Taskbar Progress for both PKG and PUP installer
* fix missing ifdefs for windows
* add mainwindow icon + thumbnail toolbar
* add game specific icons to the GSFrame
* fix icon crash
* fix appIcon's aspect ratio in SetAppIconFromPath
* Fix black borders in RGB32 icons
* rename thumbar related buttons
* EmuSettings (#35)
* Core tab done minus doing the library list.
* Graphics tab.
* Audio tab
* Input tab
* Added the other tabs
* LLE part one-- load existing libraries sorted. (I'd finish it but I'm going to look at a PR by mega)
* add search and add other libraries that aren't checked.
* Finish adding lle selecting things.
* marking my territory (#38)
fixed settingsdialog glitch and width
added groupbox to gui buttons
removed parents from layouts
* add debuggerframe + RSXDebugger (#34)
* Add Debuggerframe
* add RSXDebugger
* add RSXDebugger fo real
* RSXDebugger improved
minor adjustments
* add utf8 conversions like neko told me to
hopefully i did not utf8-ise too many things xD
* fix some variables
* maybe fix image buffers in RSXDebugger
* fixed image view (pretty sure)
* fixed image buffer (hopefully)
* QT Opengl frame (#41)
* fix RSX Debugger headers (#40)
* fix some debugger layout issues
fix RSX Debugger headers + some comments
* add kd-11's SPU options
fix D3D12 showing on non-compatible systems
tidy up coretab
* improve D3D12 behaviour in graphicstab:
adapter selection and D3D12 render won't show on non-compatible systems
add monospace font to cgDisasm
* enable update only on visibility
* Rpcs3 qt llvm build (#42)
* LLVM pushed so mega can test
* probably is what is needed with Release LLVM
* should probably have RPCS3-Qt be using release-llvm
* include zlib the same way.
* don't talk to me about how I made this happen.
* I applied the magical treatment to debug mode too. Though, it's entirely probably that doing it once in LLVM-release mode made this entirely redundant
* hack
* progress bar for LLVM spawns but doesn't close yet.
* fix msgDialog (#43)
fix oskDialog
* Minor bug fixzz
* fix osk and msgdialog for real (#44)
* fix msgDialog
fix oskDialog
* fix OskDialog part 2
fix MsgDialog part 2
* This bug is evil, and it should be ashamed of itself.
* Refactor YAML. Commented out gui options that aren't added to config yet (add em back later when we merge that in)
* Fix pad stuff.
* add SaveDataUtility (#45)
* add SaveDataUtility
* fix slots
* fix slots again
fix lists not showing stuff
fix dialogs not showing
add colClicked
refactor stuff and polish some layouts
* add SaveDataDialog.h and SaveDataDialog.cpp
* tidy up mainwindow
* add callback
* fix RegisterEditor (#47)
* fix RegisterEditor
* fix other dialogs' immortality (gasp...vampires)
* remove debug leftovers
* fix InstructionEditor (#46)
* fix InstructionEditor
* fix typo
* Fix MouseClickEvents in RSXDebugger (#50)
* Fix MouseClickEvents in RSXDebugger
Fix focus on MemoryViewer and RSXDebugger
Adjust PadButtonWidth
* fix another comment
* fix debuggerframe events (#49)
* Fix pad settings bro (#48)
* Fix pad settings bro
* fix comment
* Icons and Menu-Additions (#39)
* Add Icons and iconlogic to cornerWidget and actions
* add cornerWidget toggle
fix dockwidget action state on start
remove DoSettings
* fix game removal bug
remove tableitem focus rectangle
therefore add TableItemDelegate.h
* remove grid and focus rectangle from autopausedialog
* add fullscreen checkbox to misctab
minor padsettings layout improvements
* Add show category submenu to view menu
Add gamelist filter accordingly
fix minor bug where play icon was displayed despite pause label
add boolean b_fullscreen to mainwindow for later use in GSFrame
* fix headers in autopausesettings
fix remove bug in autopausesettings
add delete keypressevent in autopausesettings
fix missing tr() and minor refactoring in gamelist
* add default Icons for play/pause/stop/restart
* Fix fullscreen start. Some stuff was wrong with settings, just trust me.
* remove fullscreen leftovers and fix merge
* SPU stuff. (There was also a weird thing with config.h in GLGSFrame.h with an include that I removed to fix build)
* please neko's lambda fetishes (#53)
* please neko's lambda fetish in mainwindow
* please neko's lambda fetish in gamelistframe
* please neko's lambda fetish in logframe
* fix neko's lambda fetish in debuggerframe
* pleasefixdofetishsomething in Autopausesettingsdialog
* fix sth sth lambda in cg disasm
* lambda stuff in instructioneditor
* lambda kernelexplorer
* lambda-ise memoryviewer
* lambda rsxdebugger
* lambda savedatautil
this could be done even more, but the functions are not implemented
* Rpcs3 qt fixes -- shadow taskbar bug (#52)
* SShadow's bug of taskbar progress staying fixed on cancelling pkg install.
* other taskbar
* i'm still a baka
* Fix a warning
* qtQt refactoring (#54)
* fix neko's snake fetish
* File names should match headers. Are these the names I want? Not necessarily. But, this is much less confusing.
* i thought I committed everything with stage all.........................
* remove unused utilities
* The most important commit of them all.
* Disable legacy opengl buffers when not using opengl.
* fix code review comment
* Quick crash patch. Neko removed autopause. SO, I remove it too from emusettings/misc tab
* Merge lovely things from master (#55)
* Configuration simplified
* untrivial parts of the merge
* no need for these options anymore
* Minor change to fix column widths at startup (not sure why it doesn't work already, but adding the true makes it work so......... whatever)
* here ya go
* FIx hitting okay in settings causing graphics to messup (#57)
* fixes + msgdialog taskbarprogress (#56)
* fix ok button in taskbar
add taskicon progressbar for msgdialog
add tablewidgetitem to rsxdebugger
fix comments in save_data_utility.cpp
* fix d3d adapter default
* fix taskicon progressbar not being destroyed properly
* add last_path to filedialogs
* fix msgdialog crash on ok (#58)
* fix thread stopping in debbugerFrame (#59)
* Move Emu.init to be first. This will fix the qt stuff seeming to ignore the virtual filesystem in the config. (VFS to be made soon maybe) (#60)
* Fix full screen opening on double RIGHT click.
* fix other instances of double click ...
* Fix locaiton of gui config. (#61)
* fix d3d bug (#62)
* fix d3d bug
* small utf8 addition
* Fix cmake for qt (#64)
* Initial CMake fix
* Fix compilation with GCC
* Get rid of awful hack
* Update cotire with qt support
* Maybe fix travis
* Emergency Hack Relief Program Activated
* Fix travis build (#65)
* make about dialog great again (#67)
and add previous additions
* Fix library sort / smart gamelist context menu (#63)
* fix library sort
* add Title to custom game config dialog
* disable options on gamelist context menu
* use namespace for category Strings
* introduce sstr
* fix some tr nonsense
* Rpcs3qt Appveyor (#68)
Fix appyveyor build!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
* possible fix for gamelist icons (#69)
add warning for appicon
* Fix clang build (#66)
Hcorion, the build savior.
* Rpcs3 qt resources (#70)
* Resource files attempt 1
* Autorcc should probably be on?
* forgot the most important file lol
* Forgot an instance of the icon in the code...
* Patch fix for clang build.
* vulkan/d3d12 combobox merge (#71)
* add vulkan adapterbox and merge with d3d12 box
* fix adapter text on other renderer
* gather render strings
* attempt fix on gamelist row height
* adjust adapter behaviour to new guideline
* Compiler of Peace.
* High critical hit rate.
* Mugi eating strawberries is savage.
* Apply KD-11 Hotfix (#73)
* Most of Ani Adjusts (#72)
* Most of the adjustments are made here.
* fix gamelist rowheight
* fix msg dialog layout and disable_cancel
* cleanup
* fix disable cancle again
* fix debuggerframe buttons and doubleclick
* Add a fun little bonus feature :) (#74)
* category filters simplyfied (#75)
* Cleaning up cmake a bit.
* fixezzzzzz (#76)
* upgrade Info Boxes
* upgrade file explorer
* refactor GetSettings and SetSettings
* second refactoring
* cleanup
* travis is a grammar nazi
* second travis shenanigans
* third travis weirdo thingy
* travis 4 mega fun
* travis 5 default to def
* finish refactoring for settings
fix gamelist headers
* hotfix msgdialog and infobox (#77)
* msgdialog fix 1
* fix zombie infobox
* Rpcs3 Qt Welcome Page (#78)
* Add a welcome dialog.
* Add enter to end of file
* i'm an idiot
* last mistake i hope
* sponsored via --> funded by
* RPCS3 does not condone piracy.
* Mega Adjusts
* Ani Adjustments and a few refactorings
* Yay
* Add Gamelist Icon Sizes (#79)
* Reverting Mega's suggestion. If people can use alt-f4 to get around this dialog, they can probably use an emulator too.
* Fix firmware file choice dialog in QT GUI (#80)
* ani adjusts 2 + minor icon size simplifications (#81)
FPS Additions
* Update Travis to Qt 5.9 (#82)
