RPCSX/rpcsx
1
0
Fork 0
mirror of https://github.com/RPCSX/rpcsx.git synced 2026-04-04 22:19:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Debugger: Implement SPU breakpoints

Browse source
This commit is contained in:
Eladash 2021-10-15 02:26:51 +03:00 • committed by Ivan
parent ec6d6adebc
commit ccb2724fc4
10 changed files with 136 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

68
rpcs3/rpcs3qt/breakpoint_list.cpp
View file

@ -3,6 +3,7 @@
#include "Emu/CPU/CPUDisAsm.h"
#include "Emu/Cell/PPUThread.h"
#include "Emu/Cell/SPUThread.h"
#include <QMenu>
#include <QMessageBox>
@ -11,7 +12,7 @@ constexpr auto qstr = QString::fromStdString;
extern bool is_using_interpreter(u32 id_type);
breakpoint_list::breakpoint_list(QWidget* parent, breakpoint_handler* handler) : QListWidget(parent), m_breakpoint_handler(handler)
breakpoint_list::breakpoint_list(QWidget* parent, breakpoint_handler* handler) : QListWidget(parent), m_ppu_breakpoint_handler(handler)
{
setEditTriggers(QAbstractItemView::NoEditTriggers);
setContextMenuPolicy(Qt::CustomContextMenu);
@ -42,14 +43,14 @@ void breakpoint_list::ClearBreakpoints()
{
auto* currentItem = takeItem(0);
const u32 loc = currentItem->data(Qt::UserRole).value<u32>();
m_breakpoint_handler->RemoveBreakpoint(loc);
m_ppu_breakpoint_handler->RemoveBreakpoint(loc);
delete currentItem;
}
}
void breakpoint_list::RemoveBreakpoint(u32 addr)
{
m_breakpoint_handler->RemoveBreakpoint(addr);
m_ppu_breakpoint_handler->RemoveBreakpoint(addr);
for (int i = 0; i < count(); i++)
{
@ -67,7 +68,7 @@ void breakpoint_list::RemoveBreakpoint(u32 addr)
bool breakpoint_list::AddBreakpoint(u32 pc)
{
if (!m_breakpoint_handler->AddBreakpoint(pc))
if (!m_ppu_breakpoint_handler->AddBreakpoint(pc))
{
return false;
}
@ -98,10 +99,55 @@ void breakpoint_list::HandleBreakpointRequest(u32 loc)
return;
}
if (m_cpu->id_type() != 1)
if (!is_using_interpreter(m_cpu->id_type()))
{
// TODO: SPU breakpoints
QMessageBox::warning(this, tr("Unimplemented Breakpoints For Thread Type!"), tr("Cannot set breakpoints on non-PPU thread currently, sorry."));
QMessageBox::warning(this, tr("Interpreters-Only Feature!"), tr("Cannot set breakpoints on non-interpreter decoders."));
return;
}
switch (m_cpu->id_type())
{
case 2:
{
if (loc >= SPU_LS_SIZE || loc % 4)
{
QMessageBox::warning(this, tr("Invalid Memory For Breakpoints!"), tr("Cannot set breakpoints on non-SPU executable memory!"));
return;
}
const auto spu = static_cast<spu_thread*>(m_cpu);
auto& list = spu->local_breakpoints;
if (list[loc / 4].test_and_invert())
{
if (std::none_of(list.begin(), list.end(), [](auto& val){ return val.load(); }))
{
spu->has_active_local_bps = false;
}
}
else
{
if (!spu->has_active_local_bps.exchange(true))
{
spu->state.atomic_op([](bs_t<cpu_flag>& flags)
{
if (flags & cpu_flag::pending)
{
flags += cpu_flag::pending_recheck;
}
else
{
flags += cpu_flag::pending;
}
});
}
}
return;
}
case 1: break;
default:
QMessageBox::warning(this, tr("Unimplemented Breakpoints For Thread Type!"), tr("Cannot set breakpoints on a thread not an PPU/SPU currently, sorry."));
return;
}
@ -111,13 +157,7 @@ void breakpoint_list::HandleBreakpointRequest(u32 loc)
return;
}
if (!is_using_interpreter(m_cpu->id_type()))
{
QMessageBox::warning(this, tr("Interpreters-Only Feature!"), tr("Cannot set breakpoints on non-interpreter decoders."));
return;
}
if (m_breakpoint_handler->HasBreakpoint(loc))
if (m_ppu_breakpoint_handler->HasBreakpoint(loc))
{
RemoveBreakpoint(loc);
}