RPCSX/rpcsx
1
0
Fork 0
mirror of https://github.com/RPCSX/rpcsx.git synced 2026-04-09 08:25:16 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix various explicitness, laziness, hard codes

Browse source
This commit is contained in:
sampletext32 2020-04-10 21:48:32 +03:00 • committed by Ivan
parent 5524cd1e75
commit c69691f19b
6 changed files with 26 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

12
rpcs3/rpcs3qt/cheat_manager.cpp
View file

@ -245,12 +245,12 @@ bool cheat_engine::resolve_script(u32& final_offset, const u32 offset, const std
while (index < red_script.size())
{
if (red_script[index] >= '0' && red_script[index] <= '9')
if (std::isdigit(static_cast<u8>(red_script[index])))
{
std::string num_string;
for (; index < red_script.size(); index++)
{
if (red_script[index] < '0' || red_script[index] > '9')
if (!std::isdigit(static_cast<u8>(red_script[index])))
break;
num_string += red_script[index];
@ -348,15 +348,15 @@ std::vector<u32> cheat_engine::search(const T value, const std::vector<u32>& to_
else
{
// Looks through mapped memory
for (u32 page_ind = (0x10000 / 4096); page_ind < (0xF0000000 / 4096); page_ind++)
for (u32 page_start = 0x10000; page_start < 0xF0000000; page_start += 4096)
{
if (vm::check_addr(page_ind * 4096))
if (vm::check_addr(page_start))
{
// Assumes the values are aligned
for (u32 index = 0; index < 4096; index += sizeof(T))
{
if (*vm::get_super_ptr<T>((page_ind * 4096) + index) == value_swapped)
results.push_back((page_ind * 4096) + index);
if (*vm::get_super_ptr<T>(page_start + index) == value_swapped)
results.push_back(page_start + index);
}
}
}