RPCSX/rpcsx
1
0
Fork 0
mirror of https://github.com/RPCSX/rpcsx.git synced 2026-04-04 22:19:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix various explicitness, laziness, hard codes

Browse source
This commit is contained in:
sampletext32 2020-04-10 21:48:32 +03:00 • committed by Ivan
parent 5524cd1e75
commit c69691f19b
6 changed files with 26 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

6
rpcs3/Emu/GDB.cpp
View file

@ -543,7 +543,7 @@ bool gdb_thread::cmd_thread_info(gdb_cmd& cmd)
std::string result;
const auto on_select = [&](u32, cpu_thread& cpu)
{
if (result.length()) {
if (!result.empty()) {
result += ",";
}
result += u64_to_padded_hex(static_cast<u64>(cpu.id));
@ -572,7 +572,7 @@ bool gdb_thread::cmd_read_register(gdb_cmd& cmd)
auto ppu = static_cast<named_thread<ppu_thread>*>(th.get());
u32 rid = hex_to_u32(cmd.data);
std::string result = get_reg(ppu, rid);
if (!result.length()) {
if (result.empty()) {
GDB.warning("Wrong register id %d.", rid);
return send_cmd_ack("E01");
}
@ -622,7 +622,7 @@ bool gdb_thread::cmd_read_memory(gdb_cmd& cmd)
//result += "xx";
}
}
if (len && !result.length()) {
if (len && result.empty()) {
//nothing read
return send_cmd_ack("E01");
}