RPCSX/rpcsx
1
0
Fork 0
mirror of https://github.com/RPCSX/rpcsx.git synced 2026-04-05 14:37:08 +00:00
Code Issues Projects Releases Packages Wiki Activity

Debugger: Optimize cpu_thread::dump_regs()

Browse source 
Reuse string buffer. Copies and reallocations are expensive with such large strings.
This commit is contained in:
Eladash 2022-06-22 12:00:06 +03:00 • committed by Megamouse
parent 794cbd8708
commit 5e01ffdfd8
12 changed files with 35 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

12
rpcs3/Emu/Cell/PPUThread.cpp
View file

@ -936,10 +936,8 @@ std::array<u32, 2> op_branch_targets(u32 pc, ppu_opcode_t op)
return res;
}
std::string ppu_thread::dump_regs() const
void ppu_thread::dump_regs(std::string& ret) const
{
std::string ret;
PPUDisAsm dis_asm(cpu_disasm_mode::normal, vm::g_sudo_addr);
for (uint i = 0; i < 32; ++i)
@ -1107,8 +1105,6 @@ std::string ppu_thread::dump_regs() const
*(&ret.back() - (4 - (addr % 16 / 4)) * 9 - (8 - (addr % 128 / 16)) * std::size("[0x00]"sv)) = '*';
}
}
return ret;
}
std::string ppu_thread::dump_callstack() const
@ -1259,9 +1255,9 @@ std::string ppu_thread::dump_misc() const
return ret;
}
std::string ppu_thread::dump_all() const
void ppu_thread::dump_all(std::string& ret) const
{
std::string ret = cpu_thread::dump_all();
cpu_thread::dump_all(ret);
if (!call_history.data.empty())
{
@ -1271,8 +1267,6 @@ std::string ppu_thread::dump_all() const
fmt::append(ret, "%s", call_history);
}
return ret;
}
extern thread_local std::string(*g_tls_log_prefix)();