[orbis-kernel] Improve kdelete safety

This commit is contained in:
Ivan Chikish 2023-07-15 19:05:14 +03:00
parent 9717128c1f
commit 191a9459af
5 changed files with 12 additions and 5 deletions

View file

@ -54,9 +54,16 @@ template <typename T, typename... Args> T *knew(Args &&...args) {
return res;
}
// clang-format off
template <typename T> void kdelete(T *ptr) {
auto total_size = sizeof(T);
if constexpr (requires(T *t) { t->_total_size = sizeof(T); })
total_size = ptr->_total_size;
else
static_assert(std::is_final_v<T>, "Uncertain type size");
ptr->~T();
utils::kfree(ptr, sizeof(T));
utils::kfree(ptr, total_size);
}
// clang-format on
} // namespace orbis

View file

@ -21,7 +21,7 @@ enum {
kEvfWaitModeClearPat = 0x20,
};
struct EventFlag {
struct EventFlag final {
char name[32];
bool isDeleted = false;

View file

@ -40,7 +40,7 @@ struct FileOps {
Thread *thread) = nullptr;
};
struct File {
struct File final {
FileOps *ops;
Ref<RcBase> device;
std::atomic<unsigned> refs{0};

View file

@ -22,7 +22,7 @@ struct NamedObjInfo {
uint16_t ty;
};
struct Process {
struct Process final {
KernelContext *context = nullptr;
pid_t pid = -1;
sysentvec *sysent = nullptr;

View file

@ -2,7 +2,7 @@
namespace orbis {
inline namespace utils {
template <typename T> struct LinkedNode {
template <typename T> struct LinkedNode final {
T object;
LinkedNode *next = nullptr;
LinkedNode *prev = nullptr;