SPU debugger: Implement MFC journal

* Allow to dump up to 1820 commands with up 128 bytes of data each, using key D with the debugger.

rpcs3/rpcs3qt/debugger_frame.cpp

@@ -7,6 +7,7 @@
 #include "breakpoint_list.h"
 #include "breakpoint_handler.h"
 #include "call_stack_list.h"
+#include "input_dialog.h"
 #include "qt_utils.h"
 
 #include "Emu/System.h"
@@ -28,6 +29,7 @@
 #include <QMenu>
 #include <QVBoxLayout>
 #include <QTimer>
+#include <charconv>
 
 #include "util/asm.hpp"
 
@@ -259,6 +261,7 @@ void debugger_frame::keyPressEvent(QKeyEvent* event)
 		QLabel* l = new QLabel(tr(
 			"Keys Ctrl+G: Go to typed address."
 			"\nKeys Alt+S: Capture SPU images of selected SPU."
+			"\nKey D: SPU MFC commands logger, MFC debug setting must be enabled."
 			"\nKey E: Instruction Editor: click on the instruction you want to modify, then press E."
 			"\nKey F: Dedicated floating point mode switch for SPU threads."
 			"\nKey R: Registers Editor for selected thread."
@@ -311,6 +314,76 @@ void debugger_frame::keyPressEvent(QKeyEvent* event)
 	{
 		switch (event->key())
 		{
+		case Qt::Key_D:
+		{
+			if (cpu->id_type() == 2 && g_cfg.core.mfc_debug && !cpu->is_stopped())
+			{
+				input_dialog dlg(4, "", tr("Max MFC cmds logged"),
+					tr("Decimal only, max allowed is 1820."), "0", this);
+
+				QFont mono = QFontDatabase::systemFont(QFontDatabase::FixedFont);
+				mono.setPointSize(8);
+				dlg.set_input_font(mono, false);
+				dlg.set_clear_button_enabled(false);
+				dlg.set_button_enabled(QDialogButtonBox::StandardButton::Ok, false);
+				dlg.set_validator(new QRegExpValidator(QRegExp("^[1-9][0-9]*$")));
+
+				u32 max = 0;
+
+				connect(&dlg, &input_dialog::text_changed, [&](const QString& changed)
+				{
+					bool ok = false;
+					const u32 dummy = changed.toUInt(&ok, 10);
+					ok = ok && dummy && dummy <= spu_thread::max_mfc_dump_idx;
+					dlg.set_button_enabled(QDialogButtonBox::StandardButton::Ok, ok);
+
+					if (ok)
+					{
+						max = dummy;
+					}
+				});
+
+				if (dlg.exec() != QDialog::Accepted)
+				{
+					max = 0;
+				}
+
+				auto spu = static_cast<spu_thread*>(cpu);
+
+				auto ptr = reinterpret_cast<const mfc_cmd_dump*>(vm::g_stat_addr + spu->vm_offset());
+
+				std::string ret;
+
+				for (u64 count = 0, idx = spu->mfc_dump_idx - 1; idx != umax && count < max; count++, idx--)
+				{
+					auto dump = ptr[idx % spu_thread::max_mfc_dump_idx];
+
+					const u32 pc = std::exchange(dump.cmd.eah, 0);
+					fmt::append(ret, "\n(%d) PC 0x%05x: [%s]", count, pc, dump.cmd);
+
+					if (dump.cmd.cmd == MFC_PUTLLC_CMD)
+					{
+						fmt::append(ret, " %s", dump.cmd.tag == MFC_PUTLLC_SUCCESS ? "(passed)" : "(failed)");
+					}
+
+					const auto data = reinterpret_cast<const be_t<u32>*>(dump.data);
+
+					for (usz i = 0; i < utils::aligned_div(std::min<u32>(dump.cmd.size, 128), 4); i += 4)
+					{
+						fmt::append(ret, "\n[0x%02x] %08x %08x %08x %08x", i * sizeof(data[0])
+							, data[i + 0], data[i + 1], data[i + 2], data[i + 3]);
+					}
+				}
+
+				if (ret.empty())
+				{
+					ret = "No MFC commands have been logged";
+				}
+
+				spu_log.warning("SPU MFC dump of '%s': %s", spu->get_name(), ret);
+			}
+			return;
+		}
 		case Qt::Key_E:
 		{
 			if (cpu->id_type() == 1 || cpu->id_type() == 2)

rpcs3/rpcs3qt/emu_settings_type.h

@@ -17,6 +17,7 @@ enum class emu_settings_type
 	PreferredSPUThreads,
 	PPUDebug,
 	SPUDebug,
+	MFCDebug,
 	MaxLLVMThreads,
 	EnableTSX,
 	AccurateGETLLAR,
@@ -163,6 +164,7 @@ static const QMap<emu_settings_type, cfg_location> settings_location =
 	{ emu_settings_type::PreferredSPUThreads,      { "Core", "Preferred SPU Threads"}},
 	{ emu_settings_type::PPUDebug,                 { "Core", "PPU Debug"}},
 	{ emu_settings_type::SPUDebug,                 { "Core", "SPU Debug"}},
+	{ emu_settings_type::MFCDebug,                 { "Core", "MFC Debug"}},
 	{ emu_settings_type::MaxLLVMThreads,           { "Core", "Max LLVM Compile Threads"}},
 	{ emu_settings_type::EnableTSX,                { "Core", "Enable TSX"}},
 	{ emu_settings_type::AccurateGETLLAR,          { "Core", "Accurate GETLLAR"}},

rpcs3/rpcs3qt/settings_dialog.cpp

@@ -1745,6 +1745,9 @@ settings_dialog::settings_dialog(std::shared_ptr<gui_settings> gui_settings, std
 	m_emu_settings->EnhanceCheckBox(ui->spuDebug, emu_settings_type::SPUDebug);
 	SubscribeTooltip(ui->spuDebug, tooltips.settings.spu_debug);
 
+	m_emu_settings->EnhanceCheckBox(ui->mfcDebug, emu_settings_type::MFCDebug);
+	SubscribeTooltip(ui->mfcDebug, tooltips.settings.mfc_debug);
+
 	m_emu_settings->EnhanceCheckBox(ui->setDAZandFTZ, emu_settings_type::SetDAZandFTZ);
 	SubscribeTooltip(ui->setDAZandFTZ, tooltips.settings.set_daz_and_ftz);
 

rpcs3/rpcs3qt/settings_dialog.ui

@@ -3453,6 +3453,13 @@
               </property>
              </widget>
             </item>
+            <item>
+             <widget class="QCheckBox" name="mfcDebug">
+              <property name="text">
+               <string>MFC Debug</string>
+              </property>
+             </widget>
+            </item>
             <item>
              <widget class="QCheckBox" name="setDAZandFTZ">
               <property name="text">

rpcs3/rpcs3qt/tooltips.h

@@ -74,6 +74,7 @@ public:
 
 		const QString ppu_debug                    = tr("Creates PPU logs.\nOnly useful to developers.\nNever use this.");
 		const QString spu_debug                    = tr("Creates SPU logs.\nOnly useful to developers.\nNever use this.");
+		const QString mfc_debug                    = tr("Creates MFC logs.\nOnly useful to developers.\nNever use this.");
 		const QString set_daz_and_ftz              = tr("Sets special MXCSR flags to debug errors in SSE operations.\nOnly used in PPU thread when it's not precise.\nOnly useful to developers.\nNever use this.");
 		const QString accurate_getllar             = tr("Accurately processes SPU MFC_GETLLAR operation.");
 		const QString accurate_spu_dma             = tr("Accurately processes SPU DMA operations.");