meshcore-open/lib/screens
Zach 818f514702 The first issue was that the toggle switch states weren't being initialized when settings were refreshed from the device. The code would correctly update the interval values themselves, but failed to set the corresponding boolean flags that control whether the toggles appear as "on" or "off". This meant that if you refreshed settings from a device that had advertisements disabled (with an interval of zero), the toggles would incorrectly show as enabled even though the device was actually broadcasting no advertisements. We fixed this by adding two lines that explicitly set _advertEnable = _advertInterval > 0 and _floodAdvertEnable = _floodAdvertInterval > 0 after parsing the interval values from device responses.
The second critical bug was in the validation logic that checks whether responses from the device contain valid data. The validator was rejecting any interval values of zero because it checked interval > 0, but zero is now a meaningful and valid value that indicates advertisements are disabled. Without this fix, any time a device reported back that advertisements were disabled, the app would silently discard that information as invalid, leaving the UI out of sync with reality. We changed the validation to use interval >= 0 instead and updated the comment to explicitly document that zero means disabled.

The third fix was a minor code style issue where a single-line if statement was missing braces, causing a linter warning. This doesn't affect functionality but ensures the code meets project standards.
2026-02-01 17:08:53 -07:00
..
app_debug_log_screen.dart Add localization support and translation script 2026-01-11 17:13:50 -07:00
app_settings_screen.dart feat: add Russian and Ukrainian to language selector 2026-01-28 22:26:14 -07:00
ble_debug_log_screen.dart Add localization support and translation script 2026-01-11 17:13:50 -07:00
channel_chat_screen.dart feat: optimize reaction message format to reduce airtime 2026-01-28 23:21:04 -07:00
channel_message_path_screen.dart Add localization support and translation script 2026-01-11 17:13:50 -07:00
channels_screen.dart Replace action buttons with a popup menu for better UI/UX on channels and map screens 2026-01-31 15:25:34 -08:00
chat_screen.dart feat: optimize reaction message format to reduce airtime 2026-01-28 23:21:04 -07:00
community_qr_scanner_screen.dart feat: Add community management features with QR code scanning 2026-01-19 20:56:07 -07:00
contacts_screen.dart fix commit 2026-02-01 16:57:17 -07:00
device_screen.dart Add localization support and translation script 2026-01-11 17:13:50 -07:00
map_cache_screen.dart Add localization support and translation script 2026-01-11 17:13:50 -07:00
map_screen.dart Replace action buttons with a popup menu for better UI/UX on channels and map screens 2026-01-31 15:25:34 -08:00
neighbours_screen.dart Add untranslated messages file and update localization keys 2026-01-19 19:13:22 -07:00
repeater_cli_screen.dart Add localization support and translation script 2026-01-11 17:13:50 -07:00
repeater_hub_screen.dart Refactor autofocus logic in login dialogs for better platform handling 2026-01-26 10:40:10 -08:00
repeater_settings_screen.dart The first issue was that the toggle switch states weren't being initialized when settings were refreshed from the device. The code would correctly update the interval values themselves, but failed to set the corresponding boolean flags that control whether the toggles appear as "on" or "off". This meant that if you refreshed settings from a device that had advertisements disabled (with an interval of zero), the toggles would incorrectly show as enabled even though the device was actually broadcasting no advertisements. We fixed this by adding two lines that explicitly set _advertEnable = _advertInterval > 0 and _floodAdvertEnable = _floodAdvertInterval > 0 after parsing the interval values from device responses. 2026-02-01 17:08:53 -07:00
repeater_status_screen.dart Refactor timeout calculations for repeater and login frames to ensure minimum message size is respected; remove obsolete widget test file. 2026-01-11 17:40:19 -07:00
scanner_screen.dart fix: address PR review issues 2026-01-28 21:29:18 -07:00
settings_screen.dart localization: update GPS settings messages and improve handling of custom variables 2026-01-19 18:56:06 -07:00
telemetry_screen.dart Fix issues flagged by flutter analyze 2026-01-17 11:00:34 -05:00