diff --git a/qemu/scripts/qapi-visit.py b/qemu/scripts/qapi-visit.py index 877ace16..1e756940 100644 --- a/qemu/scripts/qapi-visit.py +++ b/qemu/scripts/qapi-visit.py @@ -46,9 +46,11 @@ void visit_type_%(c_name)s_members(Visitor *v, %(c_name)s *obj, Error **errp) if base: ret += mcgen(''' visit_type_%(c_type)s_members(v, (%(c_type)s *)obj, &err); + if (err) { + goto out; + } ''', c_type=base.c_name()) - ret += gen_err_check() for memb in members: if memb.optional: @@ -59,10 +61,12 @@ void visit_type_%(c_name)s_members(Visitor *v, %(c_name)s *obj, Error **errp) push_indent() ret += mcgen(''' visit_type_%(c_type)s(v, "%(name)s", &obj->%(c_name)s, &err); + if (err) { + goto out; + } ''', c_type=memb.type.c_name(), name=memb.name, c_name=c_name(memb.name)) - ret += gen_err_check() if memb.optional: pop_indent() ret += mcgen(''' diff --git a/qemu/scripts/qapi.py b/qemu/scripts/qapi.py index 9e700afa..67f0db82 100644 --- a/qemu/scripts/qapi.py +++ b/qemu/scripts/qapi.py @@ -1669,14 +1669,6 @@ def gen_params(arg_type, extra): return ret -def gen_err_check(label='out', skiperr=False): - return mcgen(''' - if (err) { - goto out; - } -''') - - # # Common command line parsing #