From 991683af73a784d08d79e283d7f2de865411b508 Mon Sep 17 00:00:00 2001 From: Richard Henderson Date: Fri, 11 May 2018 10:37:34 -0400 Subject: [PATCH] target/m68k: Fix build Werror with gcc 8.0.1 The Werror stems from the compiler finding a path through the second switch via a missing default case in which src1 is uninitialized, and not being able to prove that the missing default case is unreachable due to the first switch. Simplify the second switch to merge default with OS_LONG, which returns directly. This removes the unreachable path. Backports commit 5cbc61110738accb16ff8ed1f08a32906d02790f from qemu. --- qemu/target/m68k/translate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qemu/target/m68k/translate.c b/qemu/target/m68k/translate.c index 3a6295f2..16c21113 100644 --- a/qemu/target/m68k/translate.c +++ b/qemu/target/m68k/translate.c @@ -2369,7 +2369,7 @@ DISAS_INSN(arith_im) im = tcg_const_i32(tcg_ctx, read_im32(env, s)); break; default: - abort(); + g_assert_not_reached(); } if (with_SR) { @@ -2389,7 +2389,8 @@ DISAS_INSN(arith_im) } src1 = gen_get_sr(s); break; - case OS_LONG: + default: + /* OS_LONG; others already g_assert_not_reached. */ disas_undef(env, s, insn); return; }