From 812f3e4fed143be3ef3c14ce06fd3a9a70f9794d Mon Sep 17 00:00:00 2001 From: Aleksandar Markovic Date: Thu, 8 Aug 2019 19:45:12 -0400 Subject: [PATCH] target/mips: Add 'fall through' comments for handling nanoMips' SHXS, SWXS This was found by GCC 8.3 static analysis. Missed in commit fb32f8c8560. Backports commit 45152d050213a1221a5a900283976454bf6308bf from qemu --- qemu/target/mips/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu/target/mips/translate.c b/qemu/target/mips/translate.c index c5a661ad..eb02e0f1 100644 --- a/qemu/target/mips/translate.c +++ b/qemu/target/mips/translate.c @@ -20256,12 +20256,14 @@ static void gen_p_lsx(DisasContext *ctx, int rd, int rs, int rt) switch (extract32(ctx->opcode, 7, 4)) { case NM_SHXS: check_nms(ctx); + /* fall through */ case NM_LHXS: case NM_LHUXS: tcg_gen_shli_tl(tcg_ctx, t0, t0, 1); break; case NM_SWXS: check_nms(ctx); + /* fall through */ case NM_LWXS: case NM_LWC1XS: case NM_SWC1XS: