From 4a1996502fbcb9734179cc40f40b634f7faae26a Mon Sep 17 00:00:00 2001 From: Peter Maydell Date: Thu, 25 Feb 2021 13:18:49 -0500 Subject: [PATCH] target/arm: Remove dead code relating to SABA and UABA In commit cfdb2c0c95ae9205b0 ("target/arm: Vectorize SABA/UABA") we replaced the old handling of SABA/UABA with a vectorized implementation which returns early rather than falling into the loop-ever-elements code. We forgot to delete the part of the old looping code that did the accumulate step, and Coverity correctly warns (CID 1428955) that this code is now dead. Delete it. Fixes: cfdb2c0c95ae9205b0 Backports commit ced7e8edb282765685d2ba0206a11f8692d8ec1c from qemu --- qemu/target/arm/translate-a64.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/qemu/target/arm/translate-a64.c b/qemu/target/arm/translate-a64.c index dd60b3ce..0ec4eb13 100644 --- a/qemu/target/arm/translate-a64.c +++ b/qemu/target/arm/translate-a64.c @@ -11661,18 +11661,6 @@ static void disas_simd_3same_int(DisasContext *s, uint32_t insn) genfn(tcg_ctx, tcg_res, tcg_op1, tcg_op2); } - if (opcode == 0xf) { - /* SABA, UABA: accumulating ops */ - static NeonGenTwoOpFn * const fns[3] = { - gen_helper_neon_add_u8, - gen_helper_neon_add_u16, - tcg_gen_add_i32, - }; - - read_vec_element_i32(s, tcg_op1, rd, pass, MO_32); - fns[size](tcg_ctx, tcg_res, tcg_op1, tcg_res); - } - write_vec_element_i32(s, tcg_res, rd, pass, MO_32); tcg_temp_free_i32(tcg_ctx, tcg_res);