From 1c9c8d3f10a104cf09b3085f5ea35dd4459664b8 Mon Sep 17 00:00:00 2001 From: Richard Henderson Date: Tue, 27 Feb 2018 12:00:25 -0500 Subject: [PATCH] cputlb: Replace SHIFT with DATA_SIZE Backports commit dea2198201b3e0151d75b42774c51cf2ffe2ca4b from qemu --- qemu/cputlb.c | 16 ++++++++-------- qemu/softmmu_template.h | 7 ++----- 2 files changed, 10 insertions(+), 13 deletions(-) diff --git a/qemu/cputlb.c b/qemu/cputlb.c index 2c131c4e..cb8acd4e 100644 --- a/qemu/cputlb.c +++ b/qemu/cputlb.c @@ -518,16 +518,16 @@ static bool victim_tlb_hit(CPUArchState *env, size_t mmu_idx, size_t index, #define MMUSUFFIX _mmu -#define SHIFT 0 +#define DATA_SIZE 1 #include "softmmu_template.h" -#define SHIFT 1 +#define DATA_SIZE 2 #include "softmmu_template.h" -#define SHIFT 2 +#define DATA_SIZE 4 #include "softmmu_template.h" -#define SHIFT 3 +#define DATA_SIZE 8 #include "softmmu_template.h" #undef MMUSUFFIX @@ -536,14 +536,14 @@ static bool victim_tlb_hit(CPUArchState *env, size_t mmu_idx, size_t index, #define GETPC() ((uintptr_t)0) #define SOFTMMU_CODE_ACCESS -#define SHIFT 0 +#define DATA_SIZE 1 #include "softmmu_template.h" -#define SHIFT 1 +#define DATA_SIZE 2 #include "softmmu_template.h" -#define SHIFT 2 +#define DATA_SIZE 4 #include "softmmu_template.h" -#define SHIFT 3 +#define DATA_SIZE 8 #include "softmmu_template.h" diff --git a/qemu/softmmu_template.h b/qemu/softmmu_template.h index 5f087696..f5eb43da 100644 --- a/qemu/softmmu_template.h +++ b/qemu/softmmu_template.h @@ -28,8 +28,6 @@ #include "exec/memory.h" #include "uc_priv.h" -#define DATA_SIZE (1 << SHIFT) - #if DATA_SIZE == 8 #define SUFFIX q #define LSUFFIX q @@ -138,7 +136,7 @@ static inline DATA_TYPE glue(io_read, SUFFIX)(CPUArchState *env, } cpu->mem_io_vaddr = addr; - memory_region_dispatch_read(mr, physaddr, &val, 1 << SHIFT, + memory_region_dispatch_read(mr, physaddr, &val, DATA_SIZE, iotlbentry->attrs); return (DATA_TYPE)val; } @@ -547,7 +545,7 @@ static inline void glue(io_write, SUFFIX)(CPUArchState *env, cpu->mem_io_vaddr = addr; cpu->mem_io_pc = retaddr; - memory_region_dispatch_write(mr, physaddr, val, 1 << SHIFT, + memory_region_dispatch_write(mr, physaddr, val, DATA_SIZE, iotlbentry->attrs); } @@ -838,7 +836,6 @@ void helper_be_st_name(CPUArchState *env, target_ulong addr, DATA_TYPE val, #endif /* !defined(SOFTMMU_CODE_ACCESS) */ #undef READ_ACCESS_TYPE -#undef SHIFT #undef DATA_TYPE #undef SUFFIX #undef LSUFFIX