yuzu-mirror/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-mirror/mbedtls.git synced 2025-12-06 07:12:32 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
21819 commits 89 branches 205 tags 114 MiB
Commit graph

7486 commits

Author SHA1 Message Date
Werner Lewis 6baf12b18d Move legacy mod functions back to test_suite_mpi 
Signed-off-by: Werner Lewis <werner.lewis@arm.com>
 2022-10-19 15:20:01 +01:00
Werner Lewis ffe4478936 Move mpi_core_bitlen tests to bignum_core files 
Signed-off-by: Werner Lewis <werner.lewis@arm.com>
 2022-10-19 15:20:01 +01:00
Werner Lewis 1b20e7e645 Redefine result() method to return List 
Many bignum tests have multiple calculated result values, so return
these as a list, rather than formatting as a string.

Signed-off-by: Werner Lewis <werner.lewis@arm.com>
 2022-10-19 15:20:01 +01:00
Werner Lewis 99e8178fa7 Add module for bignum_core test generation 
Separate file is added for classes used to generate cases for tests
in bignum_core.function. Common elements of the BignumOperation class
are added to classes in a new common file, for use across files.

Signed-off-by: Werner Lewis <werner.lewis@arm.com>
 2022-10-19 15:20:01 +01:00
Werner Lewis 0c6ea12145 Move bignum_mod tests into separate files 
Signed-off-by: Werner Lewis <werner.lewis@arm.com>
 2022-10-19 15:20:01 +01:00
Werner Lewis c9b6a0aef9 Move bignum_mod_raw tests into separate files 
Signed-off-by: Werner Lewis <werner.lewis@arm.com>
 2022-10-19 15:20:01 +01:00
Werner Lewis c6004a2ab3 Move bignum_core tests into separate files 
Test cases for mpi_core_add_if, mpi_core_mla, mpi_core_sub,
mpi_core_montmul are not copied into new files, these are generated in
subsequent commits.

Signed-off-by: Werner Lewis <werner.lewis@arm.com>
 2022-10-19 15:19:53 +01:00
Gilles Peskine 149c1516e7
Merge pull request #6435 from mpg/improve-outcome-analysis 
Improve outcome analysis for driver-only builds
 2022-10-19 15:54:17 +02:00
Gilles Peskine db2996357c
Merge pull request #6289 from gabor-mezei-arm/6237_Add_conditional_assign_and_swap_for_bignum 
Bignum: Add safe conditional assign and swap for the new MPI types
 2022-10-19 15:51:19 +02:00
Andrzej Kurek b8a97e7520 depends.py: rename domains argument to tasks 
Tasks can consist of domains and/or jobs.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek 629c412e81 depends.py documentation fixes 
Now that the format of exclusive groups has been changed,
update the documentation using it too.

Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek b489f958b8 depends.py: remove config options that are unset anyway 
Over the lifespan of this script these options have been removed
from the "full" configuration.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek a44c5bcdb7 depends.py: rename config_pl usage to config_py 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek 22b959d9a5 depends.py - add SHA256 dependency of LMS 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek 65b2ac1f1d Change the way exclusive groups are defined in depends.py 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek f4b18672ff depends.py: fix TLS 1.3 requirements 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek a0cb4fa302 Improve depends.py readability 
Switch from SHA224 & SHA384 testing to SHA256 and SHA512.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek b50754ae86 Switch from x509_CRT_PARSE to KEY_EXCHANGE_WITH_CERT_ENABLED 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek e5535e3123 Add MBEDTLS_DES_C exclusive group dependencies 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek a2a9688501 Fix the memory allocation in test_suite_ssl 
ASSERT_ALLOC calculates the size itself, and the parameter indicates number of elements.
```
mbedtls_calloc( sizeof( *( pointer ) ),  ( length ) );  
```
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek 6454a90c6d Remove pre-1_2 TLS dependencies from depends.py 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek 658442fe78 Remove unnecessary ECP_C dependencies 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek e5a5cc1944 Remove the dependency of tls1_3 key evolution tests on curve25519 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek daf43fbe21 Move the location of MBEDTLS_ECP_C dependencies 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek 2d637c4cbb Fix unchecked allocation in test_suite_ssl 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek 01af84a0ca depends.py: Add script documentation 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek 2f8ac287b6 Disable MBEDTLS_TEST_HOOKS in depends.py 
This option was increasing testing duration
by about 40%.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek eabeb30c65 Fix SHA512 vs SHA384 dependencies 
When building SHA512 without SHA384,
there are some code paths that resulted
in unused variables or usage of undefined code.
This commit fixes that.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek 228b12ce54 Rework depends.py to run more tests with hashes 
The test coverage reduction introduced in
dc25cee lowered the coverage of hash tests
due to intertwining dependencies.
This commit introduces a new class for building
a domain using both the complementary
and exclusive classes.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek fe46949686 depends.py: disable part of the test jobs 
Disable exclusive jobs that run with a single
config disabled. A lot more bugs should be found by running jobs with only one config
of a family enabled.
This will also lessen the burden on the CI.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek fcbd2acbc2 Split depends.py all.sh job into seven 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek 202932f521 Use upper case for constants in depends.py 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek 3322c22087 Improve depends.py structrue 
Apply most improvements suggested by pylint.
Use config.py instead of config.pl.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:09 -04:00
Andrzej Kurek 0e8b2d74f0 Fix python formatting and indentation 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Andrzej Kurek 3cca0c8e68 Add an all.sh component running depends.pl 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Andrzej Kurek e05b17fb85 Update depends.py 
Remove old and add new dependencies.
Introduce a way to handle non-trivial problems 
stemming from exclusive group testing.
Exclude SHA256 and SHA512, as these are tested
in SHA224 and SHA384 jobs, respectively.
Change config.h to mbedtls_config.h).
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Andrzej Kurek e64bd43495 Add missing ECP and ECDH dependencies in ssl test suites 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Andrzej Kurek 8e44139ca0 Add missing CURVE25519 requirements to TLS 1.3 tests 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Andrzej Kurek 84f30f2eb0 Add missing SHA256 dependency 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Andrzej Kurek e38b788b79 Add missing key exchange dependencies 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Andrzej Kurek 90e8204476 Add missing SHA256 and ECDSA_C dependencies in test_suite_ssl 
Most of the tests (including those using endpoint_init functions) parse
certificates that require MBEDTLS_SHA256_C to be present.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Andrzej Kurek 0abebebe6d Refactor ssl test suite to use pointers more 
This way it's easier to track structures that are partially set up.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Andrzej Kurek f502bcb13e Fix missing AES dependencies 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Gilles Peskine 34a1557df6 Add domains for symmetric ciphers 
Add a domain for cipher base algorithms (block permutations and stream
ciphers), a domain for block cipher chaining modes and a domain for
block cipher padding modes.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Gilles Peskine c3b4deeb6c When exercising key exchanges, don't build the test suites 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Gilles Peskine 584c24ace4 Declare more reverse dependencies 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Gilles Peskine b1284cf6bc Don't test builds with only deprecated hashes 
Don't try to build with only SHA-1 or with only RIPEMD160 or with only
MD{2,4,5}.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Gilles Peskine bf7537d0a9 Use the full config as the baseline for all jobs 
Start each job from the full config minus some memory management
settings and the job-specific settings.

The original content of config.h no longer influences the
configurations used for the jobs (but it still influences what jobs
may run, in that the set of jobs is partly built by parsing #define
and //#define lines in config.h).
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Gilles Peskine e85163bb5c Simplify final passed/failed reporting 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Gilles Peskine 0fa7cbeeb9 Add basic support for colored output 
Show "pass" lines in green and "fail" lines in red.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Gilles Peskine 54aa5c6957 Factor running config.pl into its own function 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Gilles Peskine 46c8256547 Flush log output after each line 
Otherwise the output can be out of order when redirected.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Gilles Peskine b39e3ecee6 New script to exercise compilation options 
Unify curves.pl, key-exchanges.pl, depends-pkalgs.pl and
depends-hashes.pl into a single, newly-written script.

For curves, key exchanges and hashes, in addition to testing
all-but-one settings in the group like the old scripts, also run the
tests with a single option in the group.

Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Andrzej Kurek e40b92178d Fix missing padding dependencies 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Andrzej Kurek 252283f2aa Fix missing cipher mode dependencies 
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
 2022-10-19 08:35:08 -04:00
Przemek Stekiel 8258ea7b7d test_suite_psa_crypto: adapt dependenies and guards so the test can run in the driver-only build 
Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>
 2022-10-19 13:20:20 +02:00
Manuel Pégourié-Gonnard 0dc40773d6 Improve comments & messages 
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
 2022-10-19 12:12:21 +02:00
Manuel Pégourié-Gonnard deef905a1c Update is_builtin_calling_md() for PKCS#1 v2.1 
Since https://github.com/Mbed-TLS/mbedtls/pull/6141 it can "fall back"
to PSA when MD is not available (but will use MD if available, to
preserve backwards compatibility).

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
 2022-10-19 11:02:15 +02:00
Manuel Pégourié-Gonnard 98b91d40d6 RSA PKCS#1 v1.5 no longer depends on MD 
This has been the case since
https://github.com/Mbed-TLS/mbedtls/pull/6065 which forgot to update the
documentation, and also is_builtin_calling_md(), so update those.

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
 2022-10-19 10:59:30 +02:00
Gabor Mezei 4dceede71b
Fix overly replacement in the documentation 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2022-10-18 16:44:17 +02:00
Przemek Stekiel 98b1af4e34 test_suite_debug: adapt dependenies so the test can run in the driver-only build 
Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>
 2022-10-18 14:52:41 +02:00
Janos Follath 7cd1ebe0bb
Merge pull request #6296 from gilles-peskine-arm/test_data_generation-pr_6093_followup 
Minor fixes to test_data_generation.py
 2022-10-18 13:38:28 +01:00
Manuel Pégourié-Gonnard d92fb01419 Skip bits not needed in outcome-analysis.sh 
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
 2022-10-18 12:10:45 +02:00
David Horstmann 3cd67584bc Improve X509 DN test naming 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-10-17 17:59:10 +01:00
David Horstmann d0e3d45e96 Add explanatory comments to raw DER test data 
Break down the DER-encoded ASN.1 test data into its structure in a
comment and explain it, to make it easier to understand where the data
came from and how it is corrupted.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-10-17 17:55:04 +01:00
Gilles Peskine 47da7bfac8
Merge pull request #6434 from gilles-peskine-arm/lmots_import_export_test-memory_leak 
LMS: Fix memory leak if unit test fails
 2022-10-17 17:57:59 +02:00
Gabor Mezei 0c74e084d5
Fix condition 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2022-10-17 16:09:58 +02:00
Gilles Peskine 503d09b52d Fix memory leak if unit test fails 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2022-10-17 12:27:43 +02:00
Manuel Pégourié-Gonnard 6c6f04b651
Merge pull request #6419 from mpg/fix-assert-alloc-usage 
Fix usage of ASSERT_ALLOC()
 2022-10-17 12:10:48 +02:00
Gilles Peskine 8874cd570e
Merge pull request #4826 from RcColes/development 
Add LMS implementation
 2022-10-14 18:33:01 +02:00
Gabor Mezei ffb4aa0ddc
Rename variables to have unambiguous names 
Use bytes instead of len in the variable names.

Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2022-10-14 16:39:04 +02:00
Gabor Mezei 8bcd7cca94
Use count instead of bytes in ASSERT_ALLOC argument 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2022-10-14 16:18:10 +02:00
Manuel Pégourié-Gonnard b3c30907d6
Merge pull request #6383 from mprse/aead_driver_test 
Enable testing of AEAD drivers with libtestdriver1
 2022-10-14 11:11:01 +02:00
Manuel Pégourié-Gonnard 47b8de834d Fix usage of ASSERT_ALLOC() 
The second argument is the number of elements of the type the first
argument is pointing to, so we shouldn't be using sizeof there.

This was resulting in overly large allocations.

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
 2022-10-14 09:35:55 +02:00
Gilles Peskine fa65237fd4 Fix which config header MBEDTLS_LMS_xxx is unset from 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2022-10-13 22:05:38 +02:00
Gilles Peskine 31c2dcb611 Fix file names in reproduction instructions in test data 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2022-10-13 20:48:15 +02:00
Gilles Peskine 2875aa7b01 Fix instructions and test data for pyhsslms interop tests 
The test data was invalid because it had the extra 4-byte prefix for HSS.
Regenerate it (which produces completely new signatures since it is
randomized).

Rearrange the reproduction instructions for the second test case so that it
shows more clearly how to generate a second signature with the same private
key.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2022-10-13 20:45:05 +02:00
Raef Coles 8bccc999d9
Don't mention error type in LMS test comments 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 17:57:31 +01:00
Raef Coles 6d7d94a821
Use correct export length in LMS export tests 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 17:55:46 +01:00
Raef Coles aa9d52bcdc
Rename LMS private key files to match library name 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 17:53:40 +01:00
Raef Coles f8bfe2783b
Remove bad character from LMS test case 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 17:35:28 +01:00
Raef Coles d543697092
Fix minor type in LMS test description 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 17:06:42 +01:00
Raef Coles a2514f622f
Update pyhsslms test instructions with script 
Due to tool name conflict hampering data reproduction

Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 17:04:21 +01:00
Raef Coles ce18e528ff Rename LMS private key files 
And remove now-unnecessary modification to check_files.py

Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 16:45:05 +01:00
Raef Coles e4d96b804c Update LMS and LMOTS test comments 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 16:45:05 +01:00
Raef Coles 493724e3c2
Check correct output size in LMOTS export test 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 15:43:07 +01:00
Raef Coles ed0e4591dc
Add output length test for LMS export too-big test 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 15:05:47 +01:00
Ronald Cron 49e4184812
Merge pull request #6299 from xkqian/tls13_add_servername_check 
Add server name check when proposing pre-share key
 2022-10-13 16:00:59 +02:00
Raef Coles 33f7d66304
Add output check to export too-big buffer tests 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 14:30:36 +01:00
Raef Coles 1d88ea870f
Remove unneeded NULL pointer checks in LMS tests 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 14:30:35 +01:00
Raef Coles d1c1f7f7be
Disable LMS in all.sh tests that lack _WANT_SHA256 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 14:30:31 +01:00
Raef Coles a21671123a
Remove sudo pip3 in LM(OT)S tests instructions 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 14:30:27 +01:00
Raef Coles 1b43a7448d
Clean up LMS and LMOTS feature dependencies 
Remove SHA256 dependencies from tests, fix incorrect boolean logic in
check_config, and change depends_hashes.pl to disable LMS in one test

Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 14:30:26 +01:00
Raef Coles 6b2c573b3d
And export buffer too large test to LMS and LMOTS 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 14:30:24 +01:00
Raef Coles 534f66f3f0
Fix assert arguments in LMS and LMOTS export tests 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 14:30:23 +01:00
Raef Coles d1c2a80319
Remove duplicated assert from LMOTS tests 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 14:30:21 +01:00
Raef Coles 20d2e06ca4
Add cleanup frees in LMS and LMOTS tests 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 14:30:20 +01:00
Raef Coles 781f7bedb0
Properly mark LMOTS leak test as failed 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 14:30:18 +01:00
Raef Coles d137c86125
Don't skip LMS tests due to out of memory error 
Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 14:30:17 +01:00
Raef Coles 76563399fd
Fix LMS and LMOTS test dependencies 
Mark them as depending on PSA_WANT_ALG_SHA256 so that
test_depends_hashes_psa doesn't fail

Signed-off-by: Raef Coles <raef.coles@arm.com>
 2022-10-13 14:30:15 +01:00