mirror of
https://github.com/yuzu-mirror/breakpad.git
synced 2026-02-03 05:54:14 +01:00
bad9e55ea5
A bunch of gtest assert statements fail due to signed warnings as
unadorned constants are treated as signed integers. Mark them all
unsigned to avoid that.
One example (focus on the "[with ...]" blocks that show the types):
In file included from src/breakpad_googletest_includes.h:33:0,
from src/common/memory_unittest.cc:30:
src/testing/gtest/include/gtest/gtest.h: In instantiation of 'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int]':
src/testing/gtest/include/gtest/gtest.h:1524:23: required from 'static testing::AssertionResult testing::internal::EqHelper<true>::Compare(const char*, const char*, const T1&, const T2&, typename testing::internal::EnableIf<(! testing::internal::is_pointer<T2>::value)>::type*) [with T1 = int; T2 = long unsigned int; typename testing::internal::EnableIf<(! testing::internal::is_pointer<T2>::value)>::type = void]'
src/common/memory_unittest.cc:41:246: required from here
src/testing/gtest/include/gtest/gtest.h:1448:16: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
if (expected == actual) {
^
cc1plus: some warnings being treated as errors
Makefile:5180: recipe for target 'src/common/src_client_linux_linux_client_unittest_shlib-memory_unittest.o' failed
make[2]: *** [src/common/src_client_linux_linux_client_unittest_shlib-memory_unittest.o] Error 1
R=ted.mielczarek@gmail.com
Review URL: https://codereview.chromium.org/2013893003 .
125 lines
3.9 KiB
C++
125 lines
3.9 KiB
C++
// Copyright (c) 2009, Google Inc.
|
|
// All rights reserved.
|
|
//
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following disclaimer
|
|
// in the documentation and/or other materials provided with the
|
|
// distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived from
|
|
// this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
#include "breakpad_googletest_includes.h"
|
|
#include "common/memory.h"
|
|
|
|
using namespace google_breakpad;
|
|
|
|
namespace {
|
|
typedef testing::Test PageAllocatorTest;
|
|
}
|
|
|
|
TEST(PageAllocatorTest, Setup) {
|
|
PageAllocator allocator;
|
|
EXPECT_EQ(0U, allocator.pages_allocated());
|
|
}
|
|
|
|
TEST(PageAllocatorTest, SmallObjects) {
|
|
PageAllocator allocator;
|
|
|
|
EXPECT_EQ(0U, allocator.pages_allocated());
|
|
for (unsigned i = 1; i < 1024; ++i) {
|
|
uint8_t *p = reinterpret_cast<uint8_t*>(allocator.Alloc(i));
|
|
ASSERT_FALSE(p == NULL);
|
|
memset(p, 0, i);
|
|
}
|
|
}
|
|
|
|
TEST(PageAllocatorTest, LargeObject) {
|
|
PageAllocator allocator;
|
|
|
|
EXPECT_EQ(0U, allocator.pages_allocated());
|
|
uint8_t *p = reinterpret_cast<uint8_t*>(allocator.Alloc(10000));
|
|
ASSERT_FALSE(p == NULL);
|
|
EXPECT_EQ(3U, allocator.pages_allocated());
|
|
for (unsigned i = 1; i < 10; ++i) {
|
|
uint8_t *p = reinterpret_cast<uint8_t*>(allocator.Alloc(i));
|
|
ASSERT_FALSE(p == NULL);
|
|
memset(p, 0, i);
|
|
}
|
|
}
|
|
|
|
namespace {
|
|
typedef testing::Test WastefulVectorTest;
|
|
}
|
|
|
|
TEST(WastefulVectorTest, Setup) {
|
|
PageAllocator allocator_;
|
|
wasteful_vector<int> v(&allocator_);
|
|
ASSERT_TRUE(v.empty());
|
|
ASSERT_EQ(v.size(), 0u);
|
|
}
|
|
|
|
TEST(WastefulVectorTest, Simple) {
|
|
PageAllocator allocator_;
|
|
EXPECT_EQ(0U, allocator_.pages_allocated());
|
|
wasteful_vector<unsigned> v(&allocator_);
|
|
|
|
for (unsigned i = 0; i < 256; ++i) {
|
|
v.push_back(i);
|
|
ASSERT_EQ(i, v.back());
|
|
ASSERT_EQ(&v.back(), &v[i]);
|
|
}
|
|
ASSERT_FALSE(v.empty());
|
|
ASSERT_EQ(v.size(), 256u);
|
|
EXPECT_EQ(1U, allocator_.pages_allocated());
|
|
for (unsigned i = 0; i < 256; ++i)
|
|
ASSERT_EQ(v[i], i);
|
|
}
|
|
|
|
TEST(WastefulVectorTest, UsesPageAllocator) {
|
|
PageAllocator allocator_;
|
|
wasteful_vector<unsigned> v(&allocator_);
|
|
EXPECT_EQ(1U, allocator_.pages_allocated());
|
|
|
|
v.push_back(1);
|
|
ASSERT_TRUE(allocator_.OwnsPointer(&v[0]));
|
|
}
|
|
|
|
TEST(WastefulVectorTest, AutoWastefulVector) {
|
|
PageAllocator allocator_;
|
|
EXPECT_EQ(0U, allocator_.pages_allocated());
|
|
|
|
auto_wasteful_vector<unsigned, 4> v(&allocator_);
|
|
EXPECT_EQ(0U, allocator_.pages_allocated());
|
|
|
|
v.push_back(1);
|
|
EXPECT_EQ(0U, allocator_.pages_allocated());
|
|
EXPECT_FALSE(allocator_.OwnsPointer(&v[0]));
|
|
|
|
v.resize(4);
|
|
EXPECT_EQ(0U, allocator_.pages_allocated());
|
|
EXPECT_FALSE(allocator_.OwnsPointer(&v[0]));
|
|
|
|
v.resize(10);
|
|
EXPECT_EQ(1U, allocator_.pages_allocated());
|
|
EXPECT_TRUE(allocator_.OwnsPointer(&v[0]));
|
|
}
|