mirror of
https://github.com/yuzu-mirror/breakpad.git
synced 2026-01-10 18:40:03 +01:00
Processor shows incorrect source file name if a frame have an inlined frame and their source files are different. Consider this example: FILE 0 /tmp/a.h FILE 1 /tmp/a.cpp INLINE_ORIGIN 0 0 foo() FUNC 1110 a 0 main INLINE 0 22 0 1110 7 1110 7 3 0 1117 3 23 1 When querying the address 0x1110, we know this line 0x1110 corresponds to /tmp/a.h line 3 and it's inside a inlined function foo() which is defined at /tmp/a.h and called at line 22. But we don't know at which file it's being called at line 22. So, we will get stacks like this: void foo() /tmp/a.h:3 int main() /tmp/a.h:22 The correct stacks should be this: void foo() /tmp/a.h:3 int main() /tmp/a.cpp:22 In this change: 1. Remove file_id field for INLINE_ORIGIN record. 2. Add call_site_file_id for INLINE record to represents the file where this call being inlined. After adding call_site_file_id to it (as third field), it looks like this: FILE 0 /tmp/a.h FILE 1 /tmp/a.cpp INLINE_ORIGIN 0 foo() FUNC 1110 a 0 main INLINE 0 22 1 0 1110 7 1110 7 3 0 1117 3 23 1 Bug: 1190878 Change-Id: Ibbb697d2f7e1b6ac3208cac6fae4353c8743198d Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3232838 Reviewed-by: Joshua Peraza <jperaza@chromium.org> |
||
|---|---|---|
| .. | ||
| basic_source_line_resolver.h | ||
| call_stack.h | ||
| code_module.h | ||
| code_modules.h | ||
| dump_context.h | ||
| dump_object.h | ||
| exception_record.h | ||
| exploitability.h | ||
| fast_source_line_resolver.h | ||
| memory_region.h | ||
| microdump.h | ||
| microdump_processor.h | ||
| minidump.h | ||
| minidump_processor.h | ||
| proc_maps_linux.h | ||
| process_result.h | ||
| process_state.h | ||
| source_line_resolver_base.h | ||
| source_line_resolver_interface.h | ||
| stack_frame.h | ||
| stack_frame_cpu.h | ||
| stack_frame_symbolizer.h | ||
| stackwalker.h | ||
| symbol_supplier.h | ||
| system_info.h | ||