yuzu-mirror/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-mirror/breakpad.git synced 2025-12-31 21:50:04 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
breakpad/src/client
History
Justin Cohen 0f1f43edd2 Revert "Support PE modules in core files when running core2md" 
This reverts commit 0808030bee.

Reason for revert: Breaks Android Compile

ld.lld: error: undefined symbol: google_breakpad::PEFile::TryGetDebugInfo(char const*, google_breakpad::_RSDS_DEBUG_FORMAT*)
>>> referenced by minidump_writer.cc
>>>               client/minidump_writer.o:((anonymous namespace)::MinidumpWriter::FillRawModule(google_breakpad::MappingInfo const&, bool, unsigned int, MDRawModule*, unsigned char const*)) in archive obj/third_party/breakpad/libclient.a


https://ci.chromium.org/ui/p/chromium/builders/try/android-marshmallow-arm64-rel/1188618/overview

Original change's description:
> Support PE modules in core files when running core2md
>
> Core files generated from `wine` contain both ELF and PE modules. Module
> format can be guessed by checking the file contents. If the module
> corresponds to PE-file conditions (has specific fields set up as
> described in https://code.google.com/archive/p/corkami/wikis/PE.wiki)
> we'll create a MDCVInfoPDB70 record in the minidump for it, but if
> the file cannot be opened, is too short or is not a PE file, we'll
> fall back to ELF procedure.
>
> Added /src/client/linux/minidump_writer/pe_file.{cc,h} to
> src_client_linux_libbreakpad_client_a_SOURCES and
> src_client_linux_linux_client_unittest_shlib_SOURCES.
> Makefile.in and aclocal.m4 were generated by running 'aclocal && automake'.
>
> Test: build core2md and use it to convert a core file into dmp, validate
> that the generated dmp file can be opened. Ran './configure & make'.
>
> Change-Id: I225ffeea3f582deed40ecdfe7ab77f5754e90cbe
> Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3629189
> Reviewed-by: Joshua Peraza <jperaza@chromium.org>

Change-Id: I7105ed615a338263f112243bd8dc9e86b906fcb1
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3695862
Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
2022-06-08 18:11:47 +00:00
..
apple/Framework Mac: Add support for in-process crash reporting to Breakpad. 2014-09-15 22:48:18 +00:00
ios Add missing config for encoding_util.h/m in iOS client project 2021-11-22 18:47:26 +00:00
linux Revert "Support PE modules in core files when running core2md" 2022-06-08 18:11:47 +00:00
mac namespace implementations of FileID 2022-01-28 17:11:22 +00:00
solaris/handler namespace implementations of FileID 2022-01-28 17:11:22 +00:00
windows Fix an instance of -Wunused-but-set-variable. 2021-07-26 16:01:35 +00:00
minidump_file_writer-inl.h fix pointer style to match the style guide 2020-07-15 06:20:02 +00:00
minidump_file_writer.cc fix pointer style to match the style guide 2020-07-15 06:20:02 +00:00
minidump_file_writer.h fix pointer style to match the style guide 2020-07-15 06:20:02 +00:00
minidump_file_writer_unittest.cc fix pointer style to match the style guide 2020-07-15 06:20:02 +00:00