From fd1abfe6aa66b2348d9f93f8e5065def06b1a11d Mon Sep 17 00:00:00 2001
From: Adrian <78108584+AdrianCassar@users.noreply.github.com>
Date: Fri, 20 Jun 2025 23:05:29 +0100
Subject: [PATCH] [Lint/CI] Use LLVM v19 for Linux & Lint

---
 .github/workflows/Linux_build.yml  | 2 +-
 src/xenia/base/math.h              | 2 +-
 src/xenia/base/threading_posix.cc  | 2 +-
 src/xenia/kernel/util/shim_utils.h | 9 ++++-----
 4 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/Linux_build.yml b/.github/workflows/Linux_build.yml
index 860237000..75d45a842 100644
--- a/.github/workflows/Linux_build.yml
+++ b/.github/workflows/Linux_build.yml
@@ -49,7 +49,7 @@ jobs:
       - uses: actions/checkout@main
       - name: Setup
         run: |
-          LLVM_VERSION=18 # Same as Windows
+          LLVM_VERSION=19 # Same as Windows
           UBUNTU_BASE=jammy
           wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | sudo tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc
           sudo apt-add-repository "deb http://apt.llvm.org/${UBUNTU_BASE}/ llvm-toolchain-${UBUNTU_BASE}-$LLVM_VERSION main"
diff --git a/src/xenia/base/math.h b/src/xenia/base/math.h
index 913df6cf8..becb8a6a7 100644
--- a/src/xenia/base/math.h
+++ b/src/xenia/base/math.h
@@ -629,7 +629,7 @@ static constexpr uint32_t PregenerateUint32Div(uint32_t _denom,
     int s;
   } magu{};
   magu.a = 0;
-  nc = -1 - ((uint32_t) - (int32_t)d) % d;
+  nc = -1 - ((uint32_t)-(int32_t)d) % d;
   p = 31;
   q1 = 0x80000000 / nc;
   r1 = 0x80000000 - q1 * nc;
diff --git a/src/xenia/base/threading_posix.cc b/src/xenia/base/threading_posix.cc
index 1d4e5cfe8..e4fa59141 100644
--- a/src/xenia/base/threading_posix.cc
+++ b/src/xenia/base/threading_posix.cc
@@ -122,7 +122,7 @@ static void signal_handler(int signal, siginfo_t* info, void* context);
 
 void install_signal_handler(SignalType type) {
   if (signal_handler_installed[static_cast<size_t>(type)]) return;
-  struct sigaction action {};
+  struct sigaction action{};
   action.sa_flags = SA_SIGINFO;
   action.sa_sigaction = signal_handler;
   sigemptyset(&action.sa_mask);
diff --git a/src/xenia/kernel/util/shim_utils.h b/src/xenia/kernel/util/shim_utils.h
index 8cfd17e63..babd68c9a 100644
--- a/src/xenia/kernel/util/shim_utils.h
+++ b/src/xenia/kernel/util/shim_utils.h
@@ -631,11 +631,10 @@ using xe::cpu::ExportTag;
                    xe::kernel::shim::KernelModuleId::module_name,          \
                    ordinals::name>(&name##_entry))>>;                      \
   const auto EXPORT_##module_name##_##name = RegisterExport_##module_name( \
-      _register_##module_name##_##name ::RegisterExport<                   \
-          &name##_entry, tags | (static_cast<xe::cpu::ExportTag::type>(    \
-                                     xe::cpu::ExportCategory::category)    \
-                                 << xe::cpu::ExportTag::CategoryShift)>(   \
-          #name));
+      _register_##module_name##_##name ::RegisterExport < &name##_entry,   \
+      tags | (static_cast<xe::cpu::ExportTag::type>(                       \
+                  xe::cpu::ExportCategory::category)                       \
+              << xe::cpu::ExportTag::CategoryShift) > (#name));
 
 #define DECLARE_EMPTY_REGISTER_EXPORTS(module_name, group_name) \
   void xe::kernel::module_name::Register##group_name##Exports(  \