xenia-project/xenia
1
0
Fork 0
mirror of https://github.com/xenia-project/xenia.git synced 2025-12-06 07:12:03 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Base] Fix wait for callback return

Browse source 
- If wait item has disarmed itself and is then disarmed by another
  thread, still wait for the callback to return to meet guaratees
This commit is contained in:
Joel Linn 2022-04-17 19:35:42 +02:00 committed by Rick Gibbed
parent 3b4dc7da3b
commit e3dd873892
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/xenia/base/threading_timer_queue.cc
View file

@ -184,7 +184,9 @@ void TimerQueueWaitItem::Disarm() {
// once Disarm() has returned.
while (!state_.compare_exchange_weak(state, State::kDisarmed,
std::memory_order_acq_rel)) {
if (state == State::kInCallbackSelfDisarmed || state == State::kDisarmed) {
if (state == State::kDisarmed) {
// Do not break for kInCallbackSelfDisarmed and keep spinning in order to
// meet guarantees
break;
}
state = State::kIdle;