From c8b544ffd41ba1c33ceb577c967234e9d7aa96d9 Mon Sep 17 00:00:00 2001 From: Ben Vanik Date: Fri, 1 Jan 2016 12:45:06 -0800 Subject: [PATCH] Fixing casts. This is why I need tests. --- src/xenia/kernel/xboxkrnl/xboxkrnl_io.cc | 4 ++-- src/xenia/kernel/xboxkrnl/xboxkrnl_threading.cc | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/xenia/kernel/xboxkrnl/xboxkrnl_io.cc b/src/xenia/kernel/xboxkrnl/xboxkrnl_io.cc index efef510b6..9bef4bd53 100644 --- a/src/xenia/kernel/xboxkrnl/xboxkrnl_io.cc +++ b/src/xenia/kernel/xboxkrnl/xboxkrnl_io.cc @@ -198,7 +198,7 @@ dword_result_t NtReadFile(dword_t file_handle, dword_t event_handle, size_t bytes_read = 0; result = file->Read( buffer, buffer_length, - byte_offset_ptr ? static_cast(*byte_offset_ptr) : -1, + byte_offset_ptr ? static_cast(*byte_offset_ptr) : -1, &bytes_read, apc_context); if (io_status_block) { io_status_block->status = result; @@ -289,7 +289,7 @@ dword_result_t NtWriteFile(dword_t file_handle, dword_t event_handle, size_t bytes_written = 0; result = file->Write( buffer, buffer_length, - byte_offset_ptr ? static_cast(*byte_offset_ptr) : -1, + byte_offset_ptr ? static_cast(*byte_offset_ptr) : -1, &bytes_written, apc_context); if (XSUCCEEDED(result)) { info = (int32_t)bytes_written; diff --git a/src/xenia/kernel/xboxkrnl/xboxkrnl_threading.cc b/src/xenia/kernel/xboxkrnl/xboxkrnl_threading.cc index 54cd15f76..e9db2fc31 100644 --- a/src/xenia/kernel/xboxkrnl/xboxkrnl_threading.cc +++ b/src/xenia/kernel/xboxkrnl/xboxkrnl_threading.cc @@ -832,7 +832,7 @@ dword_result_t KeWaitForSingleObject(lpvoid_t object_ptr, dword_t wait_reason, return X_STATUS_ABANDONED_WAIT_0; } - uint64_t timeout = timeout_ptr ? static_cast(*timeout_ptr) : 0u; + uint64_t timeout = timeout_ptr ? static_cast(*timeout_ptr) : 0u; X_STATUS result = object->Wait(wait_reason, processor_mode, alertable, timeout_ptr ? &timeout : nullptr); @@ -850,7 +850,7 @@ dword_result_t NtWaitForSingleObjectEx(dword_t object_handle, dword_t wait_mode, auto object = kernel_state()->object_table()->LookupObject(object_handle); if (object) { - uint64_t timeout = timeout_ptr ? static_cast(*timeout_ptr) : 0u; + uint64_t timeout = timeout_ptr ? static_cast(*timeout_ptr) : 0u; result = object->Wait(3, wait_mode, alertable, timeout_ptr ? &timeout : nullptr); } else { @@ -885,7 +885,7 @@ dword_result_t KeWaitForMultipleObjects(dword_t count, lpdword_t objects_ptr, objects.push_back(std::move(object_ref)); } - uint64_t timeout = timeout_ptr ? static_cast(*timeout_ptr) : 0u; + uint64_t timeout = timeout_ptr ? static_cast(*timeout_ptr) : 0u; result = XObject::WaitMultiple(uint32_t(objects.size()), reinterpret_cast(objects.data()), wait_type, wait_reason, processor_mode, @@ -915,7 +915,7 @@ dword_result_t NtWaitForMultipleObjectsEx(dword_t count, lpdword_t handles, objects.push_back(std::move(object)); } - uint64_t timeout = timeout_ptr ? uint64_t(*timeout_ptr) : 0; + uint64_t timeout = timeout_ptr ? static_cast(*timeout_ptr) : 0u; result = XObject::WaitMultiple( count, reinterpret_cast(objects.data()), wait_type, 6, wait_mode, alertable, timeout_ptr ? &timeout : nullptr); @@ -937,7 +937,7 @@ dword_result_t NtSignalAndWaitForSingleObjectEx(dword_t signal_handle, auto wait_object = kernel_state()->object_table()->LookupObject(wait_handle); if (signal_object && wait_object) { - uint64_t timeout = timeout_ptr ? static_cast(*timeout_ptr) : 0u; + uint64_t timeout = timeout_ptr ? static_cast(*timeout_ptr) : 0u; result = XObject::SignalAndWait(signal_object.get(), wait_object.get(), 3, 1, alertable, timeout_ptr ? &timeout : nullptr);