xenia-project/xenia
1
0
Fork 0
mirror of https://github.com/xenia-project/xenia.git synced 2025-12-06 07:12:03 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge branch 'xenia-canary:canary_experimental' into canary_experimental

Browse source
This commit is contained in:
chrisps 2022-10-30 09:05:40 -07:00 committed by GitHub
parent f5cc54bdae 55877f4c61
commit 65b9d93551
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 36 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
src/xenia/apu/xma_context.cc
View file

@ -62,8 +62,8 @@ int XmaContext::Setup(uint32_t id, Memory* memory, uint32_t guest_ptr) {
// Allocate ffmpeg stuff: // Allocate ffmpeg stuff:
av_packet_ = av_packet_alloc(); av_packet_ = av_packet_alloc();
assert_not_null(av_packet_); assert_not_null(av_packet_);
//chrispy: preallocate this buffer so that ffmpeg isn't reallocating it for every packet, // chrispy: preallocate this buffer so that ffmpeg isn't reallocating it for
//these allocations were causing RtlSubsegmentInitialize // every packet, these allocations were causing RtlSubsegmentInitialize
av_packet_->buf = av_buffer_alloc(128 * 1024); av_packet_->buf = av_buffer_alloc(128 * 1024);
// find the XMA2 audio decoder // find the XMA2 audio decoder
av_codec_ = avcodec_find_decoder(AV_CODEC_ID_XMAFRAMES); av_codec_ = avcodec_find_decoder(AV_CODEC_ID_XMAFRAMES);
@ -93,7 +93,6 @@ int XmaContext::Setup(uint32_t id, Memory* memory, uint32_t guest_ptr) {
} }
bool XmaContext::Work() { bool XmaContext::Work() {
if (!is_enabled() || !is_allocated()) { if (!is_enabled() || !is_allocated()) {
return false; return false;
} }
@ -178,7 +177,7 @@ void XmaContext::SwapInputBuffer(XMA_CONTEXT_DATA* data) {
data->input_buffer_1_valid = 0; data->input_buffer_1_valid = 0;
} }
data->current_buffer ^= 1; data->current_buffer ^= 1;
data->input_buffer_read_offset = 0; data->input_buffer_read_offset = kBitsPerHeader;
} }
bool XmaContext::TrySetupNextLoop(XMA_CONTEXT_DATA* data, bool XmaContext::TrySetupNextLoop(XMA_CONTEXT_DATA* data,
@ -235,6 +234,7 @@ bool XmaContext::ValidFrameOffset(uint8_t* block, size_t size_bytes,
GetFramePacketNumber(block, size_bytes, frame_offset_bits); GetFramePacketNumber(block, size_bytes, frame_offset_bits);
if (packet_num == -1) { if (packet_num == -1) {
// Invalid packet number // Invalid packet number
XELOGAPU("ValidFrameOffset: Invalid packet number");
return false; return false;
} }
@ -243,6 +243,7 @@ bool XmaContext::ValidFrameOffset(uint8_t* block, size_t size_bytes,
uint32_t first_frame_offset = xma::GetPacketFrameOffset(packet); uint32_t first_frame_offset = xma::GetPacketFrameOffset(packet);
if (first_frame_offset == -1 || first_frame_offset > kBitsPerPacket) { if (first_frame_offset == -1 || first_frame_offset > kBitsPerPacket) {
XELOGAPU("ValidFrameOffset: Invalid frame offset {}", first_frame_offset);
// Packet only contains a partial frame, so no frames can start here. // Packet only contains a partial frame, so no frames can start here.
return false; return false;
} }
@ -255,12 +256,16 @@ bool XmaContext::ValidFrameOffset(uint8_t* block, size_t size_bytes,
} }
if (stream.BitsRemaining() < 15) { if (stream.BitsRemaining() < 15) {
XELOGAPU("ValidFrameOffset: No room for next frame header {}",
first_frame_offset);
// Not enough room for another frame header. // Not enough room for another frame header.
return false; return false;
} }
uint64_t size = stream.Read(15); uint64_t size = stream.Read(15);
if ((size - 15) > stream.BitsRemaining()) { if ((size - 15) > stream.BitsRemaining()) {
XELOGAPU("ValidFrameOffset: Last frame {} - {}", first_frame_offset,
size);
// Last frame. // Last frame.
return false; return false;
} else if (size == 0x7FFF) { } else if (size == 0x7FFF) {
@ -324,9 +329,6 @@ void XmaContext::Decode(XMA_CONTEXT_DATA* data) {
// No available data. // No available data.
if (!data->input_buffer_0_valid && !data->input_buffer_1_valid) { if (!data->input_buffer_0_valid && !data->input_buffer_1_valid) {
// 4156081D checks specifically for offset 0x20 when both input buffers
// are invalid.
data->input_buffer_read_offset = kBitsPerHeader;
return; return;
} }
@ -416,6 +418,10 @@ void XmaContext::Decode(XMA_CONTEXT_DATA* data) {
BitStream stream(current_input_buffer, current_input_size * 8); BitStream stream(current_input_buffer, current_input_size * 8);
stream.SetOffset(data->input_buffer_read_offset); stream.SetOffset(data->input_buffer_read_offset);
if (data->input_buffer_read_offset == current_input_size * 8) {
SwapInputBuffer(data);
return;
}
// if we had a buffer swap try to skip packets first // if we had a buffer swap try to skip packets first
if (packets_skip_ > 0) { if (packets_skip_ > 0) {
packet_idx = packet_idx =
@ -424,7 +430,7 @@ void XmaContext::Decode(XMA_CONTEXT_DATA* data) {
while (packets_skip_ > 0) { while (packets_skip_ > 0) {
packets_skip_--; packets_skip_--;
packet_idx++; packet_idx++;
if (packet_idx >= current_input_packet_count) { if (packet_idx > current_input_packet_count) {
if (!reuse_input_buffer) { if (!reuse_input_buffer) {
// Last packet. Try setup once more. // Last packet. Try setup once more.
reuse_input_buffer = TrySetupNextLoop(data, true); reuse_input_buffer = TrySetupNextLoop(data, true);
@ -627,8 +633,8 @@ void XmaContext::Decode(XMA_CONTEXT_DATA* data) {
// assert_true(frame_is_split == (frame_idx == -1)); // assert_true(frame_is_split == (frame_idx == -1));
// dump_raw(av_frame_, id()); // dump_raw(av_frame_, id());
ConvertFrame((const uint8_t**)av_frame_->data, bool(data->is_stereo), ConvertFrame((const uint8_t**)av_frame_->data,
raw_frame_.data()); bool(av_frame_->channels > 1), raw_frame_.data());
// decoded_consumed_samples_ += kSamplesPerFrame; // decoded_consumed_samples_ += kSamplesPerFrame;
auto byte_count = kBytesPerFrameChannel << data->is_stereo; auto byte_count = kBytesPerFrameChannel << data->is_stereo;
@ -639,21 +645,18 @@ void XmaContext::Decode(XMA_CONTEXT_DATA* data) {
total_samples += id_ == 0 ? kSamplesPerFrame : 0; total_samples += id_ == 0 ? kSamplesPerFrame : 0;
uint32_t offset = data->input_buffer_read_offset; uint32_t offset =
// if (offset % (kBytesPerSample * 8) == 0) { std::max(kBitsPerHeader, data->input_buffer_read_offset);
// offset = xma::GetPacketFrameOffset(packet);
//}
offset = static_cast<uint32_t>( offset = static_cast<uint32_t>(
GetNextFrame(current_input_buffer, current_input_size, offset)); GetNextFrame(current_input_buffer, current_input_size, offset));
// assert_true((offset == 0) ==
// (frame_is_split || (frame_idx + 1 >= frame_count)));
if (frame_idx + 1 >= frame_count) { if (frame_idx + 1 >= frame_count) {
// Skip to next packet (no split frame) // Skip to next packet (no split frame)
packets_skip_ = xma::GetPacketSkipCount(packet) + 1; packets_skip_ = xma::GetPacketSkipCount(packet) + 1;
while (packets_skip_ > 0) { while (packets_skip_ > 0) {
packets_skip_--; packets_skip_--;
packet_idx++; packet_idx++;
if (packet_idx >= current_input_packet_count) { if (packet_idx > current_input_packet_count) {
if (!reuse_input_buffer) { if (!reuse_input_buffer) {
// Last packet. Try setup once more. // Last packet. Try setup once more.
reuse_input_buffer = TrySetupNextLoop(data, true); reuse_input_buffer = TrySetupNextLoop(data, true);
@ -661,6 +664,8 @@ void XmaContext::Decode(XMA_CONTEXT_DATA* data) {
if (!reuse_input_buffer) { if (!reuse_input_buffer) {
SwapInputBuffer(data); SwapInputBuffer(data);
} }
data->input_buffer_read_offset =
std::max(kBitsPerHeader, data->input_buffer_read_offset);
return; return;
} }
} }
@ -670,7 +675,7 @@ void XmaContext::Decode(XMA_CONTEXT_DATA* data) {
} }
if (offset == 0 || frame_idx == -1) { if (offset == 0 || frame_idx == -1) {
// Next packet but we already skipped to it // Next packet but we already skipped to it
if (packet_idx >= current_input_packet_count) { if (packet_idx > current_input_packet_count) {
// Buffer is fully used // Buffer is fully used
if (!reuse_input_buffer) { if (!reuse_input_buffer) {
// Last packet. Try setup once more. // Last packet. Try setup once more.
@ -679,12 +684,17 @@ void XmaContext::Decode(XMA_CONTEXT_DATA* data) {
if (!reuse_input_buffer) { if (!reuse_input_buffer) {
SwapInputBuffer(data); SwapInputBuffer(data);
} }
data->input_buffer_read_offset =
std::max(kBitsPerHeader, data->input_buffer_read_offset);
break; break;
} }
offset = offset =
xma::GetPacketFrameOffset(packet) + packet_idx * kBitsPerPacket; xma::GetPacketFrameOffset(packet) + packet_idx * kBitsPerPacket;
} }
// TODO buffer bounds check // TODO buffer bounds check
if (offset >= (current_input_size << 3)) {
offset = uint32_t(current_input_size << 3);
}
assert_true(data->input_buffer_read_offset < offset); assert_true(data->input_buffer_read_offset < offset);
data->input_buffer_read_offset = offset; data->input_buffer_read_offset = offset;
} }

17
src/xenia/gpu/dxbc_shader_translator.cc
View file

@ -693,15 +693,14 @@ void DxbcShaderTranslator::StartPixelShader() {
if (i == param_gen_interpolator) { if (i == param_gen_interpolator) {
continue; continue;
} }
a_.OpMov( a_.OpMov(uses_register_dynamic_addressing ? dxbc::Dest::X(0, i)
uses_register_dynamic_addressing ? dxbc::Dest::X(0, i) : dxbc::Dest::R(i),
: dxbc::Dest::R(i), (i < xenos::kMaxInterpolators &&
(i < xenos::kMaxInterpolators && (interpolator_mask & (UINT32_C(1) << i)))
(interpolator_mask & (UINT32_C(1) << i))) ? dxbc::Src::V1D(in_reg_ps_interpolators_ +
? dxbc::Src::V1D( xe::bit_count(interpolator_mask &
in_reg_ps_interpolators_ + ((UINT32_C(1) << i) - 1)))
xe::bit_count((interpolator_mask & (UINT32_C(1) << i)) - 1)) : dxbc::Src::LF(0.0f));
: dxbc::Src::LF(0.0f));
} }
// Write the pixel parameters to the specified interpolator register // Write the pixel parameters to the specified interpolator register