From 86b33327a49e904c9157ec253b0904a34bae5922 Mon Sep 17 00:00:00 2001 From: Ahmet Inan Date: Mon, 22 Apr 2024 09:13:24 +0200 Subject: [PATCH] looks nicer --- app/src/main/java/xdsopl/robot36/Decoder.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/xdsopl/robot36/Decoder.java b/app/src/main/java/xdsopl/robot36/Decoder.java index 66e44fc..ccfd0dd 100644 --- a/app/src/main/java/xdsopl/robot36/Decoder.java +++ b/app/src/main/java/xdsopl/robot36/Decoder.java @@ -87,8 +87,7 @@ public class Decoder { return mean; } - private double scanLineStdDev(int[] lines) { - double mean = scanLineMean(lines); + private double scanLineStdDev(int[] lines, double mean) { double stdDev = 0; for (int diff : lines) stdDev += (diff - mean) * (diff - mean); @@ -131,9 +130,10 @@ public class Decoder { pulses[pulses.length - 1] = index; if (lines[0] == 0) return false; - if (scanLineStdDev(lines) > scanLineToleranceSamples) + double mean = scanLineMean(lines); + if (scanLineStdDev(lines, mean) > scanLineToleranceSamples) return false; - int meanSamples = (int) Math.round(scanLineMean(lines)); + int meanSamples = (int) Math.round(mean); Mode mode = detectMode(modes, meanSamples); curMode = mode.getName(); if (pulses[0] >= meanSamples) {