sochix/TLSharp
1
0
Fork 0
mirror of https://github.com/sochix/TLSharp.git synced 2025-12-06 08:02:00 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: show a more meaningful exception when running for 1st time

Browse source 
Instead of throwing a System.FormatException, capture the URL
thrown by the library itself so that the developer configures
the API_ID and API_HASH and places them in the app.config file.
This commit is contained in:
Andres G. Aragoneses 2016-10-23 23:23:10 +08:00
parent 96c63b3f66
commit 0e32291d11
2 changed files with 40 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
TLSharp.Core/TelegramClient.cs
View file

@ -35,11 +35,11 @@ namespace TLSharp.Core
TLContext.Init();
_apiHash = apiHash;
_apiId = apiId;
if (_apiId == 0)
throw new InvalidOperationException("Your API_ID is invalid. Do a configuration first https://github.com/sochix/TLSharp#quick-configuration");
if (_apiId == default(int))
throw new MissingApiConfigurationException("API_ID");
if (string.IsNullOrEmpty(_apiHash))
throw new InvalidOperationException("Your API_ID is invalid. Do a configuration first https://github.com/sochix/TLSharp#quick-configuration");
throw new MissingApiConfigurationException("API_HASH");
_session = Session.TryLoadOrCreateNew(store, sessionUserId);
_transport = new TcpTransport(_session.ServerAddress, _session.Port);
}
@ -250,6 +250,15 @@ namespace TLSharp.Core
_session.Save();
}
}
public class MissingApiConfigurationException : Exception
{
public const string InfoUrl = "https://github.com/sochix/TLSharp#quick-configuration";
internal MissingApiConfigurationException(string invalidParamName):
base($"Your {invalidParamName} setting is missing. Adjust the configuration first, see {InfoUrl}")
{
}
}
}

36
TLSharp.Tests/TLSharpTests.cs
View file

@ -1,4 +1,5 @@

using System;
using System.Configuration;
using System.Diagnostics;
using System.IO;
@ -39,7 +40,23 @@ namespace TLSharp.Tests
public void Init()
{
// Setup your API settings and phone numbers in app.config
GatherTestConfiguration();
}
private TelegramClient NewClient()
{
try
{
return new TelegramClient(ApiId, ApiHash);
}
catch (MissingApiConfigurationException)
{
throw new Exception($"Please add your API settings to the `app.config` file. (More info: {MissingApiConfigurationException.InfoUrl})");
}
}
private void GatherTestConfiguration()
{
ApiHash = ConfigurationManager.AppSettings[nameof(ApiHash)];
if (string.IsNullOrEmpty(ApiHash))
Debug.WriteLine("ApiHash not configured in app.config! Some tests may fail.");
@ -47,7 +64,8 @@ namespace TLSharp.Tests
var apiId = ConfigurationManager.AppSettings[nameof(ApiId)];
if (string.IsNullOrEmpty(apiId))
Debug.WriteLine("ApiId not configured in app.config! Some tests may fail.");
ApiId = int.Parse(apiId);
else
ApiId = int.Parse(apiId);
NumberToAuthenticate = ConfigurationManager.AppSettings[nameof(NumberToAuthenticate)];
if (string.IsNullOrEmpty(NumberToAuthenticate))
@ -77,7 +95,7 @@ namespace TLSharp.Tests
[TestMethod]
public async Task AuthUser()
{
var client = new TelegramClient(ApiId, ApiHash);
var client = NewClient();
await client.ConnectAsync();
@ -93,7 +111,7 @@ namespace TLSharp.Tests
[TestMethod]
public async Task SendMessageTest()
{
var client = new TelegramClient(ApiId, ApiHash);
var client = NewClient();
await client.ConnectAsync();
@ -118,7 +136,7 @@ namespace TLSharp.Tests
[TestMethod]
public async Task SendMessageToChannelTest()
{
var client = new TelegramClient(ApiId, ApiHash);
var client = NewClient();
await client.ConnectAsync();
@ -134,7 +152,7 @@ namespace TLSharp.Tests
[TestMethod]
public async Task SendPhotoToContactTest()
{
var client = new TelegramClient(ApiId, ApiHash);
var client = NewClient();
await client.ConnectAsync();
@ -152,7 +170,7 @@ namespace TLSharp.Tests
[TestMethod]
public async Task SendBigFileToContactTest()
{
var client = new TelegramClient(ApiId, ApiHash);
var client = NewClient();
await client.ConnectAsync();
@ -176,7 +194,7 @@ namespace TLSharp.Tests
[TestMethod]
public async Task DownloadFileFromContactTest()
{
var client = new TelegramClient(ApiId, ApiHash);
var client = NewClient();
await client.ConnectAsync();
@ -215,7 +233,7 @@ namespace TLSharp.Tests
[TestMethod]
public async Task SignUpNewUser()
{
var client = new TelegramClient(ApiId, ApiHash);
var client = NewClient();
await client.ConnectAsync();
var hash = await client.SendCodeRequestAsync(NotRegisteredNumberToSignUp);
@ -232,7 +250,7 @@ namespace TLSharp.Tests
[TestMethod]
public async Task CheckPhones()
{
var client = new TelegramClient(ApiId, ApiHash);
var client = NewClient();
await client.ConnectAsync();
var result = await client.IsPhoneRegisteredAsync(NumberToAuthenticate);