From 796c4780fd187bfc93e004704b305e9f1f5872d7 Mon Sep 17 00:00:00 2001 From: Endolf Date: Sun, 22 Jul 2018 16:12:47 +0100 Subject: [PATCH] Close resources as per PR #10 --- .../java/games/input/PluginClassLoader.java | 32 ++++++++++--------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/coreAPI/src/main/java/net/java/games/input/PluginClassLoader.java b/coreAPI/src/main/java/net/java/games/input/PluginClassLoader.java index 33902a9..da5eb62 100644 --- a/coreAPI/src/main/java/net/java/games/input/PluginClassLoader.java +++ b/coreAPI/src/main/java/net/java/games/input/PluginClassLoader.java @@ -117,13 +117,14 @@ class PluginClassLoader extends ClassLoader { if (!file.exists()) { throw new ClassNotFoundException(name); } - FileInputStream fileInputStream = new FileInputStream(file); - assert file.length() <= Integer.MAX_VALUE; - int length = (int)file.length(); - byte[] bytes = new byte[length]; - int length2 = fileInputStream.read(bytes); - assert length == length2; - return bytes; + try(FileInputStream fileInputStream = new FileInputStream(file)) { + assert file.length() <= Integer.MAX_VALUE; + int length = (int) file.length(); + byte[] bytes = new byte[length]; + int length2 = fileInputStream.read(bytes); + assert length == length2; + return bytes; + } } /** @@ -141,14 +142,15 @@ class PluginClassLoader extends ClassLoader { JarFile jarfile = new JarFile(jarFiles[i]); JarEntry jarentry = jarfile.getJarEntry(name + ".class"); if (jarentry != null) { - InputStream jarInputStream = jarfile.getInputStream(jarentry); - assert jarentry.getSize() <= Integer.MAX_VALUE; - int length = (int)jarentry.getSize(); - assert length >= 0; - byte[] bytes = new byte[length]; - int length2 = jarInputStream.read(bytes); - assert length == length2; - return bytes; + try(InputStream jarInputStream = jarfile.getInputStream(jarentry)) { + assert jarentry.getSize() <= Integer.MAX_VALUE; + int length = (int) jarentry.getSize(); + assert length >= 0; + byte[] bytes = new byte[length]; + int length2 = jarInputStream.read(bytes); + assert length == length2; + return bytes; + } } } throw new FileNotFoundException(name);