From aa699f5ffb4637a3760d6cc8721116a276d464a3 Mon Sep 17 00:00:00 2001 From: Endolf Date: Thu, 24 May 2018 20:52:18 +0100 Subject: [PATCH 1/6] Remove the log call that added extra new lines --- .../java/games/input/AbstractController.java | 4 +-- .../games/input/ControllerEnvironment.java | 3 -- .../input/DefaultControllerEnvironment.java | 6 ++-- .../games/input/OSXEnvironmentPlugin.java | 6 ++-- .../games/input/LinuxEnvironmentPlugin.java | 16 ++++----- .../java/games/input/LinuxEventDevice.java | 2 +- .../games/input/LinuxForceFeedbackEffect.java | 2 +- .../java/games/input/LinuxJoystickPOV.java | 2 +- .../java/net/java/games/input/LinuxPOV.java | 2 +- .../input/DirectInputEnvironmentPlugin.java | 2 +- .../net/java/games/input/IDirectInput.java | 2 +- .../java/games/input/IDirectInputDevice.java | 2 +- .../java/games/input/IDirectInputEffect.java | 2 +- .../input/RawInputEnvironmentPlugin.java | 2 +- .../games/input/WinTabButtonComponent.java | 2 +- .../net/java/games/input/WinTabDevice.java | 34 +++++++++---------- .../games/input/WinTabEnvironmentPlugin.java | 2 +- 17 files changed, 44 insertions(+), 47 deletions(-) diff --git a/coreAPI/src/main/java/net/java/games/input/AbstractController.java b/coreAPI/src/main/java/net/java/games/input/AbstractController.java index 02233df..5315d4e 100644 --- a/coreAPI/src/main/java/net/java/games/input/AbstractController.java +++ b/coreAPI/src/main/java/net/java/games/input/AbstractController.java @@ -183,7 +183,7 @@ public abstract class AbstractController implements Controller { setDeviceEventQueueSize(size); event_queue = new EventQueue(size); } catch (IOException e) { - ControllerEnvironment.logln("Failed to create new event queue of size " + size + ": " + e); + ControllerEnvironment.log("Failed to create new event queue of size " + size + ": " + e); } } @@ -233,7 +233,7 @@ public abstract class AbstractController implements Controller { } return true; } catch (IOException e) { - ControllerEnvironment.logln("Failed to poll device: " + e.getMessage()); + ControllerEnvironment.log("Failed to poll device: " + e.getMessage()); return false; } } diff --git a/coreAPI/src/main/java/net/java/games/input/ControllerEnvironment.java b/coreAPI/src/main/java/net/java/games/input/ControllerEnvironment.java index 17208f7..510436e 100644 --- a/coreAPI/src/main/java/net/java/games/input/ControllerEnvironment.java +++ b/coreAPI/src/main/java/net/java/games/input/ControllerEnvironment.java @@ -70,9 +70,6 @@ import java.util.logging.Logger; * */ public abstract class ControllerEnvironment { - static void logln(String msg) { - log(msg + "\n"); - } static void log(String msg) { Logger.getLogger(ControllerEnvironment.class.getName()).info(msg); diff --git a/coreAPI/src/main/java/net/java/games/input/DefaultControllerEnvironment.java b/coreAPI/src/main/java/net/java/games/input/DefaultControllerEnvironment.java index 8540cec..468f24c 100644 --- a/coreAPI/src/main/java/net/java/games/input/DefaultControllerEnvironment.java +++ b/coreAPI/src/main/java/net/java/games/input/DefaultControllerEnvironment.java @@ -162,7 +162,7 @@ class DefaultControllerEnvironment extends ControllerEnvironment { addControllers(ce.getControllers()); loadedPlugins.add(ce.getClass().getName()); } else { - logln(ceClass.getName() + " is not supported"); + log(ceClass.getName() + " is not supported"); } } } catch (Throwable e) { @@ -203,7 +203,7 @@ class DefaultControllerEnvironment extends ControllerEnvironment { Class[] envClasses = plugins.getExtends(ControllerEnvironment.class); for(int i=0;i Date: Thu, 24 May 2018 20:54:29 +0100 Subject: [PATCH 2/6] Only deploy on master branch --- Jenkinsfile | 1 + 1 file changed, 1 insertion(+) diff --git a/Jenkinsfile b/Jenkinsfile index 10433d0..0871c79 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -71,6 +71,7 @@ pipeline { agent { label "linux" } + when { branch 'master' } steps { unstash 'windows-natives' unstash 'osx-natives' From bd61698f168cf842ebe69399c9cd9379e28622fd Mon Sep 17 00:00:00 2001 From: Endolf Date: Thu, 24 May 2018 21:33:54 +0100 Subject: [PATCH 3/6] Only sign on deploy --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index b4fb428..84f3983 100644 --- a/pom.xml +++ b/pom.xml @@ -137,7 +137,7 @@ sign-artifacts - verify + deploy sign From 5b799195e34ffdffb49e8447e1defe74f8d6376e Mon Sep 17 00:00:00 2001 From: Endolf Date: Thu, 24 May 2018 21:54:32 +0100 Subject: [PATCH 4/6] Build core first --- Jenkinsfile | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Jenkinsfile b/Jenkinsfile index 0871c79..ca226fc 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -7,6 +7,19 @@ pipeline { } options { buildDiscarder(logRotator(numToKeepStr: '5')) } stages { + stage('Build core') { + agent { + label "osx" + } + steps { + sh 'mvn -B -Dmaven.antrun.skip -Dmaven.source.skip -Dmaven.test.skip -DskipTests -DskipITs -pl coreAPI/ package' + } + post { + success { + archiveArtifacts artifacts: 'coreAPI/target/apidocs', fingerprint: true + } + } + } stage('Build natives') { parallel { stage('Build Windows natives') { From 771499a7cac0d6c254354d891a52439ca2340156 Mon Sep 17 00:00:00 2001 From: Endolf Date: Thu, 24 May 2018 21:57:01 +0100 Subject: [PATCH 5/6] Fix the javadoc jenkins archive --- Jenkinsfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Jenkinsfile b/Jenkinsfile index ca226fc..49bdb21 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -16,7 +16,7 @@ pipeline { } post { success { - archiveArtifacts artifacts: 'coreAPI/target/apidocs', fingerprint: true + archiveArtifacts artifacts: 'coreAPI/target/apidocs/**/*', fingerprint: true } } } From 5eb89d4e124d113f7c46396b244408cc5d997f84 Mon Sep 17 00:00:00 2001 From: Endolf Date: Thu, 24 May 2018 22:41:39 +0100 Subject: [PATCH 6/6] Disable logging option --- .../java/net/java/games/input/ControllerEnvironment.java | 6 ++++++ examples/pom.xml | 1 + 2 files changed, 7 insertions(+) diff --git a/coreAPI/src/main/java/net/java/games/input/ControllerEnvironment.java b/coreAPI/src/main/java/net/java/games/input/ControllerEnvironment.java index 510436e..795c9f1 100644 --- a/coreAPI/src/main/java/net/java/games/input/ControllerEnvironment.java +++ b/coreAPI/src/main/java/net/java/games/input/ControllerEnvironment.java @@ -43,6 +43,7 @@ import java.security.AccessController; import java.security.PrivilegedAction; import java.util.ArrayList; import java.util.Iterator; +import java.util.logging.Level; import java.util.logging.Logger; /** @@ -90,6 +91,11 @@ public abstract class ControllerEnvironment { * Protected constructor for subclassing. */ protected ControllerEnvironment() { + if(System.getProperty("jinput.loglevel") != null) { + String loggerName = ControllerEnvironment.class.getPackage().getName(); + Level level = Level.parse(System.getProperty("jinput.loglevel")); + Logger.getLogger(loggerName).setLevel(level); + } } /** diff --git a/examples/pom.xml b/examples/pom.xml index 3ce0cef..0589f16 100644 --- a/examples/pom.xml +++ b/examples/pom.xml @@ -109,6 +109,7 @@ -classpath -Djava.library.path=${project.build.directory}/natives + -Djinput.loglevel=OFF net.java.games.input.example.ReadAllEvents