oobabooga/text-generation-webui
1
0
Fork 0
mirror of https://github.com/oobabooga/text-generation-webui.git synced 2026-03-08 06:33:51 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Security: restrict API model loading args to UI-exposed parameters

Browse source 
The /v1/internal/model/load endpoint previously allowed setting any
shared.args attribute, including security-sensitive flags like
trust_remote_code. Now only keys from list_model_elements() are accepted.
This commit is contained in:
oobabooga 2026-03-06 01:56:13 -03:00
parent 66fb79fe15
commit 521ddbb722
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
extensions/openai/models.py
View file

@ -1,4 +1,4 @@
from modules import shared
from modules import shared, ui
from modules.logging_colors import logger
from modules.LoRA import add_lora_to_model
from modules.models import load_model, unload_model
@ -46,9 +46,13 @@ def _load_model(data):
update_model_parameters(model_settings)
# Update shared.args with custom model loading settings
# Security: only allow keys that correspond to model loading
# parameters exposed in the UI. Never allow security-sensitive
# flags like trust_remote_code to be set via the API.
allowed_keys = set(ui.list_model_elements())
if args:
for k in args:
if hasattr(shared.args, k):
if k in allowed_keys and hasattr(shared.args, k):
setattr(shared.args, k, args[k])
shared.model, shared.tokenizer = load_model(model_name)