From 00c0895f5b927ece3e6742d09a2d4a253837be2d Mon Sep 17 00:00:00 2001 From: Sacha Weatherstone Date: Mon, 31 Oct 2022 18:25:09 +1000 Subject: [PATCH 1/2] update readme --- .github/pull_request_template.md | 6 +++++- README.md | 9 +++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 595d758..b6d8b2c 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,9 +1,13 @@ + ## What does this PR do? + -> [Related Issue](https://github.com/meshtastic/Meshtastic-protobufs/issues/0) + +> [Related Issue](https://github.com/meshtastic/protobufs/issues/0) ## Checklist before merging + - [ ] All top level messages commented - [ ] All enum members have unique descriptions - [ ] Formatting is consistant with the defined protolint rules diff --git a/README.md b/README.md index 947e6e3..a2d0b49 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ -# Meshtastic-protobufs +# Meshtastic Protobuf Definitions -[![CI](https://img.shields.io/github/workflow/status/meshtastic/Meshtastic-protobufs/CI?label=actions&logo=github&color=yellow)](https://github.com/meshtastic/Meshtastic-protobufs/actions/workflows/ci.yml) -[![CLA assistant](https://cla-assistant.io/readme/badge/meshtastic/Meshtastic-protobufs)](https://cla-assistant.io/meshtastic/Meshtastic-protobufs) +[![CI](https://img.shields.io/github/workflow/status/meshtastic/protobufs/CI?label=actions&logo=github&color=yellow)](https://github.com/meshtastic/protobufs/actions/workflows/ci.yml) +[![CLA assistant](https://cla-assistant.io/readme/badge/meshtastic/protobufs)](https://cla-assistant.io/meshtastic/protobufs) [![Fiscal Contributors](https://opencollective.com/meshtastic/tiers/badge.svg?label=Fiscal%20Contributors&color=deeppink)](https://opencollective.com/meshtastic/) [![Vercel](https://img.shields.io/static/v1?label=Powered%20by&message=Vercel&style=flat&logo=vercel&color=000000)](https://vercel.com?utm_source=meshtastic&utm_campaign=oss) @@ -13,8 +13,9 @@ The [Protobuf](https://developers.google.com/protocol-buffers) message definitio ## Stats -![Alt](https://repobeats.axiom.co/api/embed/22ac2d1a4668b8a5fc7832e8800c0e528a45d78a.svg "Repobeats analytics image") +![Alt](https://repobeats.axiom.co/api/embed/47e9ee1d81d9c0fdd2b4b5b4c673adb1756f6db5.svg "Repobeats analytics image") ## Linter Setup + Linting is performed by [protolint](https://github.com/yoheimuta/protolint) Once installed, the Visual Studio Code extension [Proto Lint](https://marketplace.visualstudio.com/items?itemName=Plex.vscode-protolint) will perform linting automatically on save. From fe5260d5611f3a8dd6153ca55eeb9e2fcbfe6b98 Mon Sep 17 00:00:00 2001 From: Sacha Weatherstone Date: Mon, 31 Oct 2022 18:51:54 +1000 Subject: [PATCH 2/2] Update comment --- portnums.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/portnums.proto b/portnums.proto index 15747f6..5096be7 100644 --- a/portnums.proto +++ b/portnums.proto @@ -131,7 +131,7 @@ enum PortNum { /* * Private applications should use portnums >= 256. * To simplify initial development and testing you can use "PRIVATE_APP" - * in your code without needing to rebuild protobuf files (via [regen-protos.sh](https://github.com/meshtastic/Meshtastic-device/blob/master/bin/regen-protos.sh)) + * in your code without needing to rebuild protobuf files (via [regen-protos.sh](https://github.com/meshtastic/firmware/blob/master/bin/regen-protos.sh)) */ PRIVATE_APP = 256;