From 3aca01ac82487de8aa3d5eefdd907b4d80714501 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thomas=20G=C3=B6ttgens?= <tgoettgens@gmail.com>
Date: Thu, 24 Nov 2022 00:33:07 +0100
Subject: [PATCH 1/3] Protos for pin definitions. Expert mode override existing
 definitions or add them on other boards.

---
 config.proto        | 23 +++++++++++++++++++++++
 module_config.proto |  6 +++++-
 2 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/config.proto b/config.proto
index 64c23d9..c4d69ba 100644
--- a/config.proto
+++ b/config.proto
@@ -57,6 +57,18 @@ message Config {
      */
     bool debug_log_enabled = 3;
 
+    /*
+     * For boards without a hard wired button, this is the pin number that will be used
+     * Boards that have more than one button can swap the function with this one. defaults to BUTTON_PIN if defined.
+     */
+    uint32 button_gpio = 4;
+
+        /*
+     * For boards without a PWM buzzer, this is the pin number that will be used
+     * Defaults to PIN_BUZZER if defined.
+     */
+    uint32 buzzer_gpio = 5;
+
   }
 
   /*
@@ -175,6 +187,17 @@ message Config {
      */
     uint32 position_flags = 7;
 
+    /*
+     * (Re)define GPS_RX_PIN for your board.
+     */
+    uint32 rx_gpio = 8;
+ 
+    /*
+     * (Re)define GPS_TX_PIN for your board.
+     */
+    uint32 tx_gpio = 9;
+ 
+
   }
 
   /*
diff --git a/module_config.proto b/module_config.proto
index 304cf07..1f4334c 100644
--- a/module_config.proto
+++ b/module_config.proto
@@ -184,7 +184,6 @@ message ModuleConfig {
 
     /*
      * Preferences for the ExternalNotificationModule
-     * FIXME - Move this out of UserPreferences and into a section for module configuration.
      */
     bool enabled = 1;
 
@@ -212,6 +211,11 @@ message ModuleConfig {
      * TODO: REPLACE
      */
     bool alert_bell = 6;
+
+    /*
+     * TODO: REPLACE
+     */
+    bool use_pwm = 7;
  
 
   }

From f39c027d82f23fea4e98f551aa4083620445237e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thomas=20G=C3=B6ttgens?= <tgoettgens@gmail.com>
Date: Thu, 24 Nov 2022 10:20:05 +0100
Subject: [PATCH 2/3] Whitespace change

---
 config.proto | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config.proto b/config.proto
index c4d69ba..71b697c 100644
--- a/config.proto
+++ b/config.proto
@@ -63,7 +63,7 @@ message Config {
      */
     uint32 button_gpio = 4;
 
-        /*
+    /*
      * For boards without a PWM buzzer, this is the pin number that will be used
      * Defaults to PIN_BUZZER if defined.
      */

From 25377930b51bd1c3ea2cefce73e4cc4898323082 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thomas=20G=C3=B6ttgens?= <tgoettgens@gmail.com>
Date: Thu, 24 Nov 2022 10:21:47 +0100
Subject: [PATCH 3/3] fix #240

---
 module_config.options | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/module_config.options b/module_config.options
index fb1f856..d2dd110 100644
--- a/module_config.options
+++ b/module_config.options
@@ -2,5 +2,5 @@
 *CannedMessageConfig.messages max_size:200
 
 *MQTTConfig.address max_size:32
-*MQTTConfig.username max_size:32
-*MQTTConfig.password max_size:32
+*MQTTConfig.username max_size:64
+*MQTTConfig.password max_size:64