meshtastic/protobufs
1
0
Fork 0
mirror of https://github.com/meshtastic/protobufs.git synced 2026-04-20 22:13:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add device_battery_num_cells

Browse source 
Currently in firmware we hard-code NUM_CELLS (usually to 1), and our code for calculating battery charge uses this variable in ways like "voltage = v / NUM_CELLS;"

If the battery voltage is one cell around our 4V normal, that works fine.

However, as reported in https://github.com/meshtastic/firmware/issues/5360 it's not uncommon for solar installs that have multiple batteries set up in a way that looks like 1 cell at 12V to our current code. So, battery charge % is always 100%.

Allowing num_cells as a configuration option will allow those users to specify how many batteries they have and receive accurate readings.
This commit is contained in:
Tom Fifield 2024-12-24 12:10:00 +11:00
parent c55f120a9c
commit 22300b0843
2 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
meshtastic/config.options
View file

@ -15,6 +15,7 @@
*LoRaConfig.channel_num int_size:16
*PowerConfig.device_battery_ina_address int_size:8
*PowerConfig.device_battery_num_cells int_size:8
*SecurityConfig.public_key max_size:32
*SecurityConfig.private_key max_size:32

5
meshtastic/config.proto
View file

@ -430,6 +430,11 @@ message Config {
*/
uint32 device_battery_ina_address = 9;
/*
* Number of battery cells in use. Battery charge is calculated using (v / num_cells).
*/
uint32 device_battery_num_cells = 10;
/*
* If non-zero, we want powermon log outputs. With the particular (bitfield) sources enabled.
* Note: we picked an ID of 32 so that lower more efficient IDs can be used for more frequently used options.