From aaaacaa0dd9bce7d2c4d85bbef1b26f50a56a844 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 6 Apr 2026 00:22:39 +0000 Subject: [PATCH] Improve readability of firmware version checks in Connect.swift Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/449fe2d6-dec9-4509-920e-e6196ca11d65 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> --- Meshtastic/Views/Connect/Connect.swift | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Meshtastic/Views/Connect/Connect.swift b/Meshtastic/Views/Connect/Connect.swift index ec1f3d78..5227a52d 100644 --- a/Meshtastic/Views/Connect/Connect.swift +++ b/Meshtastic/Views/Connect/Connect.swift @@ -376,10 +376,10 @@ struct Connect: View { Logger.data.error("💥 Error fetching node info: \(error.localizedDescription, privacy: .public)") } // Check firmware version on connection - invalidFirmwareVersion = !accessoryManager.checkIsVersionSupported(forVersion: accessoryManager.minimumVersion) - if !invalidFirmwareVersion { - showSecurityVersionNag = !accessoryManager.checkIsVersionSupported(forVersion: accessoryManager.securityVersion) - } + let meetsMinimumVersion = accessoryManager.checkIsVersionSupported(forVersion: accessoryManager.minimumVersion) + let meetsSecurityVersion = accessoryManager.checkIsVersionSupported(forVersion: accessoryManager.securityVersion) + invalidFirmwareVersion = !meetsMinimumVersion + showSecurityVersionNag = meetsMinimumVersion && !meetsSecurityVersion } } }