From 98afec1b811d663777d4b6ff18c30b5cc9cf596a Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 19 Apr 2026 00:30:13 +0000 Subject: [PATCH] Fix code review feedback: simplify signal icon logic and fix spelling Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/07fad82b-9a10-4db0-a0b0-445d8ef28e50 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> --- Meshtastic Watch App/Views/DeviceConnectionView.swift | 10 +--------- Meshtastic Watch App/Views/FoxhuntCompassView.swift | 2 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/Meshtastic Watch App/Views/DeviceConnectionView.swift b/Meshtastic Watch App/Views/DeviceConnectionView.swift index 6000f2e3..e7da814a 100644 --- a/Meshtastic Watch App/Views/DeviceConnectionView.swift +++ b/Meshtastic Watch App/Views/DeviceConnectionView.swift @@ -143,15 +143,7 @@ struct DeviceConnectionView: View { @ViewBuilder private func signalIcon(rssi: Int) -> some View { - let imageName: String - if rssi > -65 { - imageName = "wifi" - } else if rssi > -85 { - imageName = "wifi" - } else { - imageName = "wifi.exclamationmark" - } - Image(systemName: imageName) + Image(systemName: rssi > -85 ? "wifi" : "wifi.exclamationmark") .font(.system(size: 12)) .foregroundStyle(rssi > -65 ? .green : (rssi > -85 ? .yellow : .red)) } diff --git a/Meshtastic Watch App/Views/FoxhuntCompassView.swift b/Meshtastic Watch App/Views/FoxhuntCompassView.swift index 58294b8f..b7117060 100644 --- a/Meshtastic Watch App/Views/FoxhuntCompassView.swift +++ b/Meshtastic Watch App/Views/FoxhuntCompassView.swift @@ -261,7 +261,7 @@ private struct WatchCompassLabel { // MARK: - Color helper extension Color { - /// Quick luminance check so centre text is readable on the distance colour. + /// Quick luminance check so center text is readable on the distance color. var isWatchLight: Bool { // Approximate: yellow and lighter colours are "light" if self == .yellow || self == .orange || self == .white { return true }