From 8c6f61ff5cf475a874c2b101d7d20181a149ec08 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Mon, 6 Apr 2026 00:21:38 +0000
Subject: [PATCH] Address code review feedback: use @ObservedObject for
 LocationsHandler, fix firmware label

Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/449fe2d6-dec9-4509-920e-e6196ca11d65

Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>
---
 Meshtastic/Views/Onboarding/DeviceOnboarding.swift | 6 ++----
 Meshtastic/Views/Settings/Firmware.swift           | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/Meshtastic/Views/Onboarding/DeviceOnboarding.swift b/Meshtastic/Views/Onboarding/DeviceOnboarding.swift
index d82fe542..b4a29651 100644
--- a/Meshtastic/Views/Onboarding/DeviceOnboarding.swift
+++ b/Meshtastic/Views/Onboarding/DeviceOnboarding.swift
@@ -14,6 +14,7 @@ struct DeviceOnboarding: View {
 	}
 	
 	@EnvironmentObject var accessoryManager: AccessoryManager
+	@ObservedObject private var locationsHandler: LocationsHandler = .shared
 	@State var navigationPath: [SetupGuide] = []
 	@State var locationStatus = LocationsHandler.shared.manager.authorizationStatus
 	@AppStorage("provideLocation") private var provideLocation: Bool = false
@@ -239,10 +240,7 @@ struct DeviceOnboarding: View {
 						title: String(localized: "Battery Usage"),
 						subtitle: String(localized: "Enabling background activity may increase battery usage. You can toggle this at any time in the app settings.")
 					)
-					Toggle(isOn: Binding(
-						get: { LocationsHandler.shared.backgroundActivity },
-						set: { LocationsHandler.shared.backgroundActivity = $0 }
-					)) {
+					Toggle(isOn: $locationsHandler.backgroundActivity) {
 						Label {
 							Text("Enable Background Activity")
 						} icon: {
diff --git a/Meshtastic/Views/Settings/Firmware.swift b/Meshtastic/Views/Settings/Firmware.swift
index 79ca14e1..41c34897 100644
--- a/Meshtastic/Views/Settings/Firmware.swift
+++ b/Meshtastic/Views/Settings/Firmware.swift
@@ -62,7 +62,7 @@ struct Firmware: View {
 						.foregroundStyle(.red)
 						.font(.title2)
 						.padding(.bottom)
-					Text("Current Firmware Version: \(connectedVersion), Latest Firmware Version: \(accessoryManager.minimumVersion)")
+					Text("Current Firmware Version: \(connectedVersion), Minimum Required Version: \(accessoryManager.minimumVersion)")
 						.fixedSize(horizontal: false, vertical: true)
 						.font(.title3)
 						.padding(.bottom)