2023-09-12 00:02:31 -07:00
|
|
|
//
|
|
|
|
|
// NodeMapSwiftUI.swift
|
|
|
|
|
// Meshtastic
|
|
|
|
|
//
|
|
|
|
|
// Copyright(c) Garth Vander Houwen 9/11/23.
|
|
|
|
|
//
|
|
|
|
|
|
|
|
|
|
import SwiftUI
|
2026-04-16 12:10:00 -07:00
|
|
|
import SwiftData
|
2023-09-12 00:02:31 -07:00
|
|
|
import CoreLocation
|
|
|
|
|
import MapKit
|
|
|
|
|
|
2.7.6 Working Changes (#1479)
* Bump version
* Message list performance fixes into 2.7.6 (#1475)
* Remove extra want config call when adding a contact
* App badge and unnecessary notification fixes (#1455)
* - Fix for app badge not going to zero if a message arrives while you have that chat open
- Fix for push notifications popping up when a message is received while that chat is open
* Fix for cancelling notifications, works now. And scroll to bottom of conversation upon new message
* Fix: Channels help grammer fix (#1452)
* remove outdated TCP not available on Apple devices (#1450)
* Update initial onboarding view
* remove toggle gating for mac
* Update crash reporting opt out in real time
* Update onboarding text
* Use mDNS text records for node name
* TCP IP and port on the connection screen
* Hide app icon chooser on mac
* Infinite loop hang bugfixes and performance improvements for both `UserMessageList` and `ChannelMessageList` (#1465)
* 2.7.5 Working Changes (#1460)
* Remove extra want config call when adding a contact
* App badge and unnecessary notification fixes (#1455)
* - Fix for app badge not going to zero if a message arrives while you have that chat open
- Fix for push notifications popping up when a message is received while that chat is open
* Fix for cancelling notifications, works now. And scroll to bottom of conversation upon new message
* Fix: Channels help grammer fix (#1452)
* remove outdated TCP not available on Apple devices (#1450)
* Update initial onboarding view
* remove toggle gating for mac
* Update crash reporting opt out in real time
* Update onboarding text
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
* UserEntity: add mostRecentMessage and unreadMessages with early exit when lastMessage is nil, and fetch 1 row (not N) otherwise
* UserList: replace 5 slow calls to user.messageList with new fast calls
* NodeList: always put the connected node at the top of list (if it matches the node filters)
* ChannelEntity: add faster mostRecentPrivateMessage and unreadMessages which fetch 1 row (not N)
* ChannelList: replace 5 calls to channel.allPrivateMessage with new fast calls
* Fix incorrect appState.unreadDirectMessages calculations
* MyInfoEntity: also fix unreadMessages count here to be fast, and use it for appState.unreadChannelMessages
* UserMessageList: use @FetchRequest to prevent the N^2 behavior that was happening in calls to allPrivateMessages
* Refactor ChannelEntityExtension and MyInfoEntityExtension to be more similar to UserEntityExtension
* Remove SwiftUI-infinite-loop-causing `.id(redrawTapbacksTrigger)` in ChannelMessageList and UserMessageList (duplicate row ids)
* MyInfoEntityExtension: exclude emoji tapbacks (which never get marked as read anyway) from unread message count
* Add SaveChannelLinkData so MessageText and MeshtasticApp can use .sheet(item: ...) and avoid infinite loop hang due to Binding rebuild
* ChannelMessageList and UserMessageList: switch to stable messageId for ForEach SwiftUI row identity
* ChannelMessageList and UserMessageList: debouncedScrollToBottom; keyboardWillShowNotification/keyboardDidShowNotification
* ChannelMessageList and UserMessageList: scroll to bottom onFirstAppear
* ChannelMessageList and UserMessageList: block spurious markMessagesAsRead when this View is not active
---------
Co-authored-by: Garth Vander Houwen <garth@meshtastic.com>
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
* message-list-performance: revert scrolling changes (#1472)
* Revert e0f0b4a0f749d2e83946f2c1297e5c97c9fdf46e (ChannelMessageList and UserMessageList: scroll to bottom onFirstAppear)
* Revert "ChannelMessageList and UserMessageList: debouncedScrollToBottom; keyboardWillShowNotification/keyboardDidShowNotification"
This reverts commit ee1a7c44157eb6970ec2111fc1ac4d67a44a8238.
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
Co-authored-by: Mike Robbins <mrobbins@alum.mit.edu>
* Explicitly set unmessagable, seems unnessary
* Add back missing mesh map features
* Fix: "Retrieving nodes" significantly slower after reconnect extracted from #1424 (#1477)
* Fix: "Retrieving nodes" significantly slower after reconnect (#1424)
The node database retrieval was calling context.save() for every single
NodeInfo packet received (250 saves for 250 nodes). This caused severe
performance degradation on reconnect when CoreData had accumulated state.
Root Cause:
- nodeInfoPacket() called context.save() immediately for each node
- With 250 nodes, this meant 250 individual CoreData save operations
- On first connection, CoreData is fresh and fast
- On reconnect, CoreData has accumulated change tracking, undo management,
and memory pressure, making each save progressively slower
- This resulted in 10+ second retrieval times vs 1-2 seconds initially
Solution:
- Added deferSave parameter to nodeInfoPacket() function
- During database retrieval (.retrievingDatabase state), defer all saves
- Perform a single batch save when database retrieval completes
(when NONCE_ONLY_DB configCompleteID is received)
- This reduces 250 saves to 1 save
Performance Impact:
- Eliminates N individual saves during node database sync
- Reduces database retrieval time back to 1-2 seconds on reconnect
- Matches first-connection performance consistently
Fixes #1424
* Revert *MessageListUnified files
---------
Co-authored-by: Martin Bogomolni <martinbogo@gmail.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
* Hide route lines filter from mesh map
* Mesh Map: fuzz imprecise locations so they're distinguishable and clickable at the highest zoom levels (#1478)
Co-authored-by: Garth Vander Houwen <garth@meshtastic.com>
* Fix bad merge
* Update Meshtastic/Extensions/CoreData/UserEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Nodes/Helpers/Map/MapContent/MeshMapContent.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/ChannelEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/MyInfoEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/ChannelEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Keep list of previous manual connections (#1484)
* Keep list of previous manual connections
* More descriptive manual connection rows
* Merge fixes and new way to show IP on Connect view
---------
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
* Show who relayed messages (#1486)
* Add identification for node that relayed text messages and add count for ammount of relayers of your message
* Ack Relays
* upsertPositionPacket: don't use future timestamps to set node's lastHeard (#1488)
* R1 NEO
* Neo
* Update Meshtastic/Views/Settings/AppSettings.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Remove bad if
* Git rid of extra environment variable
* Update Meshtastic/Accessory/Transports/TCP/TCPTransport.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* MeshMap performance: quick wins (#1490)
* MeshMap: change onMapCameraChange frequency to .onEnd so that zooming doesn't cause continuous SwiftUI reevaluation on every frame
* MeshMapContent: factor out reducedPrecisionMapCircles into a separate function
* MeshMapContent: when multiple reducedPrecisionCircles have the same (lat,lon,radius), just draw one (big perf boost in dense areas)
* NodeMap performance improvements for high # positions history (#1480)
* NodeMapContent: move Route Lines out of ForEach
* NodeMapContent: move Convex Hull out of ForEach
* NodeMapContent: Replace `position.nodePosition?` with `node`
* NodeMapContent: drop unnecessary LazyVStack in showNodeHistory
* NodeMapContent: hoist out nodeColorSwift
* Move lineCoords, loraCoords calculations within showRouteLines, showConvexHull respectively
* Hoist out repeated node.metadata?.positionFlags lookups / PositionFlags creation
* NodeMapContent: remove unused @State
* NodeMapSwiftUI: add NodeMapContentEquatableWrapper and NodeMapContentSignature to prevent frequent NodeMapContent recomputation and infinite render loops
* NodeMapSwiftUI: disable animation during SwiftUI transactions
* NodeMapContent: hoist nodeBorderColor and set allowsHitTesting(false) on history point views
* NodeMapContent: prerenderHistoryPointCircle and prerenderHistoryPointArrow to avoid thousands of vector draw operations
* NodeMapContent: Shared coordinate list for Route Lines and Convex Hull
* NodeMapContent.prerenderHistoryPointArrow: add .frame(width: 16, height: 16)
* Fix wantRangeTestPackets to correctly follow rangeTestConfig.enabled (#1489)
* Fix interval drop down formatter
* Clean up channel qr code functionality.
* perferredPeripheralId fix
* Set opt in
* Retry once 5 second timer. dont throw the error
* Queue for peripherals
* Fix: hoplimit of dms would always fallback to hops away of the node even when configured hops was higher (#1495)
* fix hops setting in dms
* Fix hops for exchange position
* Final fix
* Don't favorite client base
* Update device hardware
* Prevent nil environment metrics
* Bump datadog sdk
* fix setting device telemetry enabled (#1515)
* Update Muzi R1 Neo to actively supported
* fix setting device telemetry enabled
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Don't subscribe to mqtt topic if downlink is not on (#1501)
* Dont sub if no downlink
* moved reload mqtt connect config
* Preview enabled in connected devices (#1509)
* Update Muzi R1 Neo to actively supported
* Preview enabled in connected devices
* Fixing indentation
* Fixing indentation
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* UpdateCoreData.updateAnyPacketFrom: mirror firmware's lastHeard/snr/rssi/hopsAway update logic from NodeDB::updateFrom (#1492)
* `CLIENT_BASE` add-favorite/role-change confirmation dialog (#1493)
* FavoriteNodeButton: refactor task out
* AccessoryManager.connectedDeviceRole helper
* FavoriteNodeButton: show confirmation dialog when a CLIENT_BASE is trying to add a favorite
* addContactFromURL: add comment referencing upcoming change in https://github.com/meshtastic/firmware/pull/8495
* DeviceConfig: role picker: show a warning when selecting CLIENT_BASE, similar to warning shown for ROUTER
* Adjust device configuration Client Base warning text
* Compass view (#1521)
* Added compass view
* Added Compass View
* Node colors in compass
* Update Muzi R1 Neo to actively supported
* Update PositionPopover.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Helpers/CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Helpers/CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Benjamin Faershtein <119711889+RCGV1@users.noreply.github.com>
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Remove discovery queue
* revert problematic retry functionalliy
* format file
* Update & improve zh-Hans translation (#1523)
* Update Muzi R1 Neo to actively supported
* update & improve zh-Hans translation
rt
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Update protobufs to 2.7.1
* Add long-turbo preset
* Disable Range Test module when primary channel is public/unsecured (#1512)
* Update Muzi R1 Neo to actively supported
* Disable Range Test module when primary channel is public/unsecured
Updated RangeTestConfig.swift to determine whether the primary channel (index 0) is operating without encryption or with a 1-byte minimal PSK.
Disabled Range Test UI controls when on a public/default channel to prevent user interaction.
Added safety enforcement in the save operation: Range Test enabled flag is automatically forced to false before sending updates to the device.
Introduced a computed property isPrimaryChannelPublic following existing code patterns and security indicators (e.g., hexDescription PSK length).
Matches the behavior implemented in the Android client for consistent policy across platforms.
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Add new device images
* Remove print statement, get rid of cut and paste error
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
Co-authored-by: Mike Robbins <mrobbins@alum.mit.edu>
Co-authored-by: Martin Bogomolni <martinbogo@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: jake-b <1012393+jake-b@users.noreply.github.com>
Co-authored-by: Benjamin Faershtein <119711889+RCGV1@users.noreply.github.com>
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: Charles Pinesky <25388414+Vaidios@users.noreply.github.com>
Co-authored-by: Radio <35003866+radiolee@users.noreply.github.com>
Co-authored-by: Jason Houk <dubsectordevelopment@gmail.com>
2025-12-21 12:15:01 -08:00
|
|
|
struct NodeMapContentSignature: Equatable {
|
|
|
|
|
// Used to decide if NodeMapContent needs to be reevaluated.
|
|
|
|
|
// Only include fields that are used within NodeMapContent (or approximations like positionCount and lastPositionTime).
|
|
|
|
|
let nodeNum: Int64
|
|
|
|
|
let positionCount: Int
|
|
|
|
|
let lastPositionTime: Date?
|
|
|
|
|
let showNodeHistory: Bool
|
|
|
|
|
let showRouteLines: Bool
|
|
|
|
|
let showConvexHull: Bool
|
|
|
|
|
let favorite: Bool
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
private struct NodeMapContentEquatableWrapper<Content: View>: View, Equatable {
|
|
|
|
|
// Prevent slow, needless recomputation of NodeMapContent if the NodeMapContentSignature hasn't changed.
|
|
|
|
|
let signature: NodeMapContentSignature
|
|
|
|
|
@ViewBuilder let content: () -> Content
|
|
|
|
|
static func == (lhs: NodeMapContentEquatableWrapper<Content>, rhs: NodeMapContentEquatableWrapper<Content>) -> Bool { lhs.signature == rhs.signature }
|
|
|
|
|
var body: some View { content() }
|
|
|
|
|
}
|
|
|
|
|
|
2023-09-12 00:02:31 -07:00
|
|
|
struct NodeMapSwiftUI: View {
|
2026-04-16 12:10:00 -07:00
|
|
|
@Environment(\.modelContext) private var context
|
Transports Interface to Support TCP for all Platforms and Serial on Mac (#1341)
* Initial implementation of transports
* Initial LogRadio implementation
* Fixes for Settings view (caused by debug commenting)
* Refinement of the object and actor model
* Connect view text and tab updates
* Fix mac catalyst and tests
* Warning and logging clean-up
* In progress commit
* Serial Transport and Reconnect draft work
* Serial transport and reconnection draft work
* Quick fix for BLE - still more work to do
* interim commit
* More in progress changes
* Minor improvements
* Pretty good initial implementation
* Bump version beyond the app store
* Fix for disconnection swipeAction
* Tweaks to TCPConnection implementation
* Retry for NONCE_ONLY_DB
* Revert json string change
* Simplified some of the API + "Anti-discovery"
* Tweaks for devices leaving the discovery process
* Bump version
* iOS26 Tweaks
* Tweaks and bug fixes
* Add link with slash sf symbol
* update symbol image on connect view
* BLE disconnect handling
* Log privacy attributes
* Onboarding and minor fixes.
* change database to nodes, add emoji to tcp logs
* Error handling improvements
* More logging emojis
* Suppressed unnecessary errors on disconnect
* Heartbeat emoji
* Add bluetooth symbol
* add privacy attributes to [TCP] logs, add custom bluetooth logo
* Improve routing logs
* Emoji for connect logs
* Heartbeat emoji
* Add CBCentralManagerScanOptionAllowDuplicatesKey options to central for bluetooth
* fix nav errors by switching from observableobject to state
* Update connection indicator icon
* fix for BLE disconnects
* Connection process fixes
* More fixes/tweaks to connection process
* Strict concurrency
* Fix some warnings, remove wifi warning
* delete stale keys
* interim commit
* Update privacy for log, fix wrong space
* fix a couple of linting items
* Switch to targeted
* interim commit
* BLE Signal strenth on connect view
* Remove BLE RSSI from long press menu
* Modem lights
* minor spacing tweak
* Additional BLE logging and a scanning fix.
* Discovery and BLE RSSI improvements
* Background suspension
* Update isConnected to enable UI during db load
* update protobufs
* Replace config if statements with switches, Fix unknown module config logging, make dark mode modem circle stroke color white so they are visible
* Additional logging cleanup
* hast
* Set unmessagable to true if the longname has the unmessagable emoji
* Connect error handling improvements
* Admin popup list icon and activity lights updates
* Revert use of .toolbar back to .navigationBarItems
* More public logging
* Better BLE error handling
* Node DB progress meter
* minor tweak to activity light interaction timing
* Fix comment linting, remove stale keys
* Remove stale keys
* Easy linting fixes
* Two more simple linting fixes
* clean up meshtasticapp
* More public logging
* Replay config
* Logging
* Fix for unselected node on Settings
* Tweak to progress meter based on device idiom
* Update protos
* Session replay redaction of messages
* Serial fix for old devices, and a let statement
* Mask text too
* Fix typo
* BLE poweredOff is now an auto-reconnectable error
* Update logging
* Fix for peerRemovedPairingInformation
* Logging for BLE peripheral:didUpdateValueFor errors.
* Fix for inconsistent swipe disconnect behavior
* periperal:didUpdateValueFor error handling
* Fix for BLEConnection continuation guarding
* BLEConnection actor deadlock on disconnect
* Heartbeat nonce
* Fix for swipe disconnect and task cancellation
* Fix for swipe actions not honoring .disabled()
* Tell BLETransport when BLEConnection is cancelled
* Update navigation logging
* Logging updates
* Bump version to 2.7.0
* Organize into folders and heartbeat stuff
* Minor improvements to manual TCP connection
* Auto-connect toggle
* Possible BLE bug, still waiting to see in logs
* Concurrency tweaks
* Concurrency improvements
* requestDeviceMetadata fix. fixes remote admin
* Minor typo fixes
* "All" button for log filters: category and level
* More robust continuation handling for BLE
* @FetchRequest based ChannelMessageList
* Update info.plist and device hardware file
* Move auto connect toggle to app settings and debug mode, tint properly with the accent color
* Add label to auto connect toggle
* Update log for node info received from ourselves over the mesh
* Remove unused scrollViewProxy
* Update Meshtastic/Views/Onboarding/DeviceOnboarding.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update target for connect view
* Properly Set datadog environment
* Comment out ble manager
* Adjust cyclomatic complexity thresholds in .swiftlint.yml
* Linting fixes, delete ble manager
* Make session replay debug only
---------
Co-authored-by: jake-b <jake-b@users.noreply.github.com>
Co-authored-by: jake <jake@jakes-Mac-mini.local>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-08-27 08:09:02 -07:00
|
|
|
@EnvironmentObject var accessoryManager: AccessoryManager
|
2023-09-18 16:53:02 -07:00
|
|
|
/// Parameters
|
2026-04-16 12:10:00 -07:00
|
|
|
@Bindable var node: NodeInfoEntity
|
2023-09-18 16:53:02 -07:00
|
|
|
@State var showUserLocation: Bool = false
|
2023-09-19 17:06:47 -07:00
|
|
|
@State var positions: [PositionEntity] = []
|
|
|
|
|
/// Map State User Defaults
|
2.7.6 Working Changes (#1479)
* Bump version
* Message list performance fixes into 2.7.6 (#1475)
* Remove extra want config call when adding a contact
* App badge and unnecessary notification fixes (#1455)
* - Fix for app badge not going to zero if a message arrives while you have that chat open
- Fix for push notifications popping up when a message is received while that chat is open
* Fix for cancelling notifications, works now. And scroll to bottom of conversation upon new message
* Fix: Channels help grammer fix (#1452)
* remove outdated TCP not available on Apple devices (#1450)
* Update initial onboarding view
* remove toggle gating for mac
* Update crash reporting opt out in real time
* Update onboarding text
* Use mDNS text records for node name
* TCP IP and port on the connection screen
* Hide app icon chooser on mac
* Infinite loop hang bugfixes and performance improvements for both `UserMessageList` and `ChannelMessageList` (#1465)
* 2.7.5 Working Changes (#1460)
* Remove extra want config call when adding a contact
* App badge and unnecessary notification fixes (#1455)
* - Fix for app badge not going to zero if a message arrives while you have that chat open
- Fix for push notifications popping up when a message is received while that chat is open
* Fix for cancelling notifications, works now. And scroll to bottom of conversation upon new message
* Fix: Channels help grammer fix (#1452)
* remove outdated TCP not available on Apple devices (#1450)
* Update initial onboarding view
* remove toggle gating for mac
* Update crash reporting opt out in real time
* Update onboarding text
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
* UserEntity: add mostRecentMessage and unreadMessages with early exit when lastMessage is nil, and fetch 1 row (not N) otherwise
* UserList: replace 5 slow calls to user.messageList with new fast calls
* NodeList: always put the connected node at the top of list (if it matches the node filters)
* ChannelEntity: add faster mostRecentPrivateMessage and unreadMessages which fetch 1 row (not N)
* ChannelList: replace 5 calls to channel.allPrivateMessage with new fast calls
* Fix incorrect appState.unreadDirectMessages calculations
* MyInfoEntity: also fix unreadMessages count here to be fast, and use it for appState.unreadChannelMessages
* UserMessageList: use @FetchRequest to prevent the N^2 behavior that was happening in calls to allPrivateMessages
* Refactor ChannelEntityExtension and MyInfoEntityExtension to be more similar to UserEntityExtension
* Remove SwiftUI-infinite-loop-causing `.id(redrawTapbacksTrigger)` in ChannelMessageList and UserMessageList (duplicate row ids)
* MyInfoEntityExtension: exclude emoji tapbacks (which never get marked as read anyway) from unread message count
* Add SaveChannelLinkData so MessageText and MeshtasticApp can use .sheet(item: ...) and avoid infinite loop hang due to Binding rebuild
* ChannelMessageList and UserMessageList: switch to stable messageId for ForEach SwiftUI row identity
* ChannelMessageList and UserMessageList: debouncedScrollToBottom; keyboardWillShowNotification/keyboardDidShowNotification
* ChannelMessageList and UserMessageList: scroll to bottom onFirstAppear
* ChannelMessageList and UserMessageList: block spurious markMessagesAsRead when this View is not active
---------
Co-authored-by: Garth Vander Houwen <garth@meshtastic.com>
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
* message-list-performance: revert scrolling changes (#1472)
* Revert e0f0b4a0f749d2e83946f2c1297e5c97c9fdf46e (ChannelMessageList and UserMessageList: scroll to bottom onFirstAppear)
* Revert "ChannelMessageList and UserMessageList: debouncedScrollToBottom; keyboardWillShowNotification/keyboardDidShowNotification"
This reverts commit ee1a7c44157eb6970ec2111fc1ac4d67a44a8238.
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
Co-authored-by: Mike Robbins <mrobbins@alum.mit.edu>
* Explicitly set unmessagable, seems unnessary
* Add back missing mesh map features
* Fix: "Retrieving nodes" significantly slower after reconnect extracted from #1424 (#1477)
* Fix: "Retrieving nodes" significantly slower after reconnect (#1424)
The node database retrieval was calling context.save() for every single
NodeInfo packet received (250 saves for 250 nodes). This caused severe
performance degradation on reconnect when CoreData had accumulated state.
Root Cause:
- nodeInfoPacket() called context.save() immediately for each node
- With 250 nodes, this meant 250 individual CoreData save operations
- On first connection, CoreData is fresh and fast
- On reconnect, CoreData has accumulated change tracking, undo management,
and memory pressure, making each save progressively slower
- This resulted in 10+ second retrieval times vs 1-2 seconds initially
Solution:
- Added deferSave parameter to nodeInfoPacket() function
- During database retrieval (.retrievingDatabase state), defer all saves
- Perform a single batch save when database retrieval completes
(when NONCE_ONLY_DB configCompleteID is received)
- This reduces 250 saves to 1 save
Performance Impact:
- Eliminates N individual saves during node database sync
- Reduces database retrieval time back to 1-2 seconds on reconnect
- Matches first-connection performance consistently
Fixes #1424
* Revert *MessageListUnified files
---------
Co-authored-by: Martin Bogomolni <martinbogo@gmail.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
* Hide route lines filter from mesh map
* Mesh Map: fuzz imprecise locations so they're distinguishable and clickable at the highest zoom levels (#1478)
Co-authored-by: Garth Vander Houwen <garth@meshtastic.com>
* Fix bad merge
* Update Meshtastic/Extensions/CoreData/UserEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Nodes/Helpers/Map/MapContent/MeshMapContent.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/ChannelEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/MyInfoEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/ChannelEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Keep list of previous manual connections (#1484)
* Keep list of previous manual connections
* More descriptive manual connection rows
* Merge fixes and new way to show IP on Connect view
---------
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
* Show who relayed messages (#1486)
* Add identification for node that relayed text messages and add count for ammount of relayers of your message
* Ack Relays
* upsertPositionPacket: don't use future timestamps to set node's lastHeard (#1488)
* R1 NEO
* Neo
* Update Meshtastic/Views/Settings/AppSettings.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Remove bad if
* Git rid of extra environment variable
* Update Meshtastic/Accessory/Transports/TCP/TCPTransport.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* MeshMap performance: quick wins (#1490)
* MeshMap: change onMapCameraChange frequency to .onEnd so that zooming doesn't cause continuous SwiftUI reevaluation on every frame
* MeshMapContent: factor out reducedPrecisionMapCircles into a separate function
* MeshMapContent: when multiple reducedPrecisionCircles have the same (lat,lon,radius), just draw one (big perf boost in dense areas)
* NodeMap performance improvements for high # positions history (#1480)
* NodeMapContent: move Route Lines out of ForEach
* NodeMapContent: move Convex Hull out of ForEach
* NodeMapContent: Replace `position.nodePosition?` with `node`
* NodeMapContent: drop unnecessary LazyVStack in showNodeHistory
* NodeMapContent: hoist out nodeColorSwift
* Move lineCoords, loraCoords calculations within showRouteLines, showConvexHull respectively
* Hoist out repeated node.metadata?.positionFlags lookups / PositionFlags creation
* NodeMapContent: remove unused @State
* NodeMapSwiftUI: add NodeMapContentEquatableWrapper and NodeMapContentSignature to prevent frequent NodeMapContent recomputation and infinite render loops
* NodeMapSwiftUI: disable animation during SwiftUI transactions
* NodeMapContent: hoist nodeBorderColor and set allowsHitTesting(false) on history point views
* NodeMapContent: prerenderHistoryPointCircle and prerenderHistoryPointArrow to avoid thousands of vector draw operations
* NodeMapContent: Shared coordinate list for Route Lines and Convex Hull
* NodeMapContent.prerenderHistoryPointArrow: add .frame(width: 16, height: 16)
* Fix wantRangeTestPackets to correctly follow rangeTestConfig.enabled (#1489)
* Fix interval drop down formatter
* Clean up channel qr code functionality.
* perferredPeripheralId fix
* Set opt in
* Retry once 5 second timer. dont throw the error
* Queue for peripherals
* Fix: hoplimit of dms would always fallback to hops away of the node even when configured hops was higher (#1495)
* fix hops setting in dms
* Fix hops for exchange position
* Final fix
* Don't favorite client base
* Update device hardware
* Prevent nil environment metrics
* Bump datadog sdk
* fix setting device telemetry enabled (#1515)
* Update Muzi R1 Neo to actively supported
* fix setting device telemetry enabled
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Don't subscribe to mqtt topic if downlink is not on (#1501)
* Dont sub if no downlink
* moved reload mqtt connect config
* Preview enabled in connected devices (#1509)
* Update Muzi R1 Neo to actively supported
* Preview enabled in connected devices
* Fixing indentation
* Fixing indentation
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* UpdateCoreData.updateAnyPacketFrom: mirror firmware's lastHeard/snr/rssi/hopsAway update logic from NodeDB::updateFrom (#1492)
* `CLIENT_BASE` add-favorite/role-change confirmation dialog (#1493)
* FavoriteNodeButton: refactor task out
* AccessoryManager.connectedDeviceRole helper
* FavoriteNodeButton: show confirmation dialog when a CLIENT_BASE is trying to add a favorite
* addContactFromURL: add comment referencing upcoming change in https://github.com/meshtastic/firmware/pull/8495
* DeviceConfig: role picker: show a warning when selecting CLIENT_BASE, similar to warning shown for ROUTER
* Adjust device configuration Client Base warning text
* Compass view (#1521)
* Added compass view
* Added Compass View
* Node colors in compass
* Update Muzi R1 Neo to actively supported
* Update PositionPopover.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Helpers/CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Helpers/CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Benjamin Faershtein <119711889+RCGV1@users.noreply.github.com>
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Remove discovery queue
* revert problematic retry functionalliy
* format file
* Update & improve zh-Hans translation (#1523)
* Update Muzi R1 Neo to actively supported
* update & improve zh-Hans translation
rt
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Update protobufs to 2.7.1
* Add long-turbo preset
* Disable Range Test module when primary channel is public/unsecured (#1512)
* Update Muzi R1 Neo to actively supported
* Disable Range Test module when primary channel is public/unsecured
Updated RangeTestConfig.swift to determine whether the primary channel (index 0) is operating without encryption or with a 1-byte minimal PSK.
Disabled Range Test UI controls when on a public/default channel to prevent user interaction.
Added safety enforcement in the save operation: Range Test enabled flag is automatically forced to false before sending updates to the device.
Introduced a computed property isPrimaryChannelPublic following existing code patterns and security indicators (e.g., hexDescription PSK length).
Matches the behavior implemented in the Android client for consistent policy across platforms.
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Add new device images
* Remove print statement, get rid of cut and paste error
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
Co-authored-by: Mike Robbins <mrobbins@alum.mit.edu>
Co-authored-by: Martin Bogomolni <martinbogo@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: jake-b <1012393+jake-b@users.noreply.github.com>
Co-authored-by: Benjamin Faershtein <119711889+RCGV1@users.noreply.github.com>
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: Charles Pinesky <25388414+Vaidios@users.noreply.github.com>
Co-authored-by: Radio <35003866+radiolee@users.noreply.github.com>
Co-authored-by: Jason Houk <dubsectordevelopment@gmail.com>
2025-12-21 12:15:01 -08:00
|
|
|
@AppStorage("meshMapShowNodeHistory") private var showNodeHistory = false
|
|
|
|
|
@AppStorage("meshMapShowRouteLines") private var showRouteLines = false
|
|
|
|
|
@AppStorage("enableMapConvexHull") private var showConvexHull = false
|
2023-10-21 15:33:00 -07:00
|
|
|
@AppStorage("enableMapTraffic") private var showTraffic: Bool = false
|
|
|
|
|
@AppStorage("enableMapPointsOfInterest") private var showPointsOfInterest: Bool = false
|
2023-09-15 23:22:49 -07:00
|
|
|
@AppStorage("mapLayer") private var selectedMapLayer: MapLayer = .hybrid
|
2023-09-19 17:06:47 -07:00
|
|
|
// Map Configuration
|
|
|
|
|
@Namespace var mapScope
|
2024-03-27 16:30:58 -07:00
|
|
|
@State var mapStyle: MapStyle = MapStyle.hybrid(elevation: .flat, pointsOfInterest: .all, showsTraffic: true)
|
2023-10-20 18:55:28 -07:00
|
|
|
@State var position = MapCameraPosition.automatic
|
2024-10-11 18:21:33 -07:00
|
|
|
@State var distance = 10000.0
|
2023-10-20 18:55:28 -07:00
|
|
|
@State var scene: MKLookAroundScene?
|
|
|
|
|
@State var isLookingAround = false
|
2023-11-17 18:35:31 -08:00
|
|
|
@State var isShowingAltitude = false
|
2023-10-20 18:55:28 -07:00
|
|
|
@State var isEditingSettings = false
|
2026-04-05 14:40:54 -07:00
|
|
|
@State var isShowingLegend = false
|
2024-02-17 15:37:28 -08:00
|
|
|
@State var isMeshMap = false
|
2025-07-22 03:23:43 +00:00
|
|
|
@State var enabledOverlayConfigs: Set<UUID> = Set()
|
2024-05-29 16:40:07 -05:00
|
|
|
|
2024-03-14 23:17:36 -07:00
|
|
|
@State private var mapRegion = MKCoordinateRegion.init()
|
2024-05-29 16:40:07 -05:00
|
|
|
|
2026-04-16 12:10:00 -07:00
|
|
|
@Query(sort: \WaypointEntity.name, order: .reverse)
|
|
|
|
|
private var waypoints: [WaypointEntity]
|
2024-05-29 16:40:07 -05:00
|
|
|
|
2023-09-12 00:02:31 -07:00
|
|
|
var body: some View {
|
2023-09-14 20:17:14 -07:00
|
|
|
if node.hasPositions {
|
2025-07-22 03:23:43 +00:00
|
|
|
mapWithNavigation
|
|
|
|
|
} else {
|
|
|
|
|
ContentUnavailableView("No Positions", systemImage: "mappin.slash")
|
|
|
|
|
}
|
|
|
|
|
}
|
2025-07-22 06:40:43 +00:00
|
|
|
|
2025-07-22 03:23:43 +00:00
|
|
|
private var mapWithNavigation: some View {
|
|
|
|
|
ZStack {
|
|
|
|
|
MapReader { _ in
|
|
|
|
|
configuredMap
|
|
|
|
|
}
|
|
|
|
|
}
|
2026-04-16 12:10:00 -07:00
|
|
|
.navigationBarTitle(String((node.user?.shortName ?? "Unknown".localized) + (" \(node.positions.count) points")), displayMode: .inline)
|
2025-07-22 03:23:43 +00:00
|
|
|
.navigationBarItems(trailing:
|
2023-09-14 17:06:38 -07:00
|
|
|
ZStack {
|
|
|
|
|
ConnectedDevice(
|
Transports Interface to Support TCP for all Platforms and Serial on Mac (#1341)
* Initial implementation of transports
* Initial LogRadio implementation
* Fixes for Settings view (caused by debug commenting)
* Refinement of the object and actor model
* Connect view text and tab updates
* Fix mac catalyst and tests
* Warning and logging clean-up
* In progress commit
* Serial Transport and Reconnect draft work
* Serial transport and reconnection draft work
* Quick fix for BLE - still more work to do
* interim commit
* More in progress changes
* Minor improvements
* Pretty good initial implementation
* Bump version beyond the app store
* Fix for disconnection swipeAction
* Tweaks to TCPConnection implementation
* Retry for NONCE_ONLY_DB
* Revert json string change
* Simplified some of the API + "Anti-discovery"
* Tweaks for devices leaving the discovery process
* Bump version
* iOS26 Tweaks
* Tweaks and bug fixes
* Add link with slash sf symbol
* update symbol image on connect view
* BLE disconnect handling
* Log privacy attributes
* Onboarding and minor fixes.
* change database to nodes, add emoji to tcp logs
* Error handling improvements
* More logging emojis
* Suppressed unnecessary errors on disconnect
* Heartbeat emoji
* Add bluetooth symbol
* add privacy attributes to [TCP] logs, add custom bluetooth logo
* Improve routing logs
* Emoji for connect logs
* Heartbeat emoji
* Add CBCentralManagerScanOptionAllowDuplicatesKey options to central for bluetooth
* fix nav errors by switching from observableobject to state
* Update connection indicator icon
* fix for BLE disconnects
* Connection process fixes
* More fixes/tweaks to connection process
* Strict concurrency
* Fix some warnings, remove wifi warning
* delete stale keys
* interim commit
* Update privacy for log, fix wrong space
* fix a couple of linting items
* Switch to targeted
* interim commit
* BLE Signal strenth on connect view
* Remove BLE RSSI from long press menu
* Modem lights
* minor spacing tweak
* Additional BLE logging and a scanning fix.
* Discovery and BLE RSSI improvements
* Background suspension
* Update isConnected to enable UI during db load
* update protobufs
* Replace config if statements with switches, Fix unknown module config logging, make dark mode modem circle stroke color white so they are visible
* Additional logging cleanup
* hast
* Set unmessagable to true if the longname has the unmessagable emoji
* Connect error handling improvements
* Admin popup list icon and activity lights updates
* Revert use of .toolbar back to .navigationBarItems
* More public logging
* Better BLE error handling
* Node DB progress meter
* minor tweak to activity light interaction timing
* Fix comment linting, remove stale keys
* Remove stale keys
* Easy linting fixes
* Two more simple linting fixes
* clean up meshtasticapp
* More public logging
* Replay config
* Logging
* Fix for unselected node on Settings
* Tweak to progress meter based on device idiom
* Update protos
* Session replay redaction of messages
* Serial fix for old devices, and a let statement
* Mask text too
* Fix typo
* BLE poweredOff is now an auto-reconnectable error
* Update logging
* Fix for peerRemovedPairingInformation
* Logging for BLE peripheral:didUpdateValueFor errors.
* Fix for inconsistent swipe disconnect behavior
* periperal:didUpdateValueFor error handling
* Fix for BLEConnection continuation guarding
* BLEConnection actor deadlock on disconnect
* Heartbeat nonce
* Fix for swipe disconnect and task cancellation
* Fix for swipe actions not honoring .disabled()
* Tell BLETransport when BLEConnection is cancelled
* Update navigation logging
* Logging updates
* Bump version to 2.7.0
* Organize into folders and heartbeat stuff
* Minor improvements to manual TCP connection
* Auto-connect toggle
* Possible BLE bug, still waiting to see in logs
* Concurrency tweaks
* Concurrency improvements
* requestDeviceMetadata fix. fixes remote admin
* Minor typo fixes
* "All" button for log filters: category and level
* More robust continuation handling for BLE
* @FetchRequest based ChannelMessageList
* Update info.plist and device hardware file
* Move auto connect toggle to app settings and debug mode, tint properly with the accent color
* Add label to auto connect toggle
* Update log for node info received from ourselves over the mesh
* Remove unused scrollViewProxy
* Update Meshtastic/Views/Onboarding/DeviceOnboarding.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update target for connect view
* Properly Set datadog environment
* Comment out ble manager
* Adjust cyclomatic complexity thresholds in .swiftlint.yml
* Linting fixes, delete ble manager
* Make session replay debug only
---------
Co-authored-by: jake-b <jake-b@users.noreply.github.com>
Co-authored-by: jake <jake@jakes-Mac-mini.local>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-08-27 08:09:02 -07:00
|
|
|
deviceConnected: accessoryManager.isConnected,
|
|
|
|
|
name: accessoryManager.activeConnection?.device.shortName ?? "?")
|
2023-09-14 17:06:38 -07:00
|
|
|
})
|
2025-07-22 03:23:43 +00:00
|
|
|
}
|
2025-07-22 06:40:43 +00:00
|
|
|
|
2025-07-22 03:23:43 +00:00
|
|
|
private var configuredMap: some View {
|
|
|
|
|
baseMap
|
|
|
|
|
.overlay(alignment: .bottom) {
|
|
|
|
|
lookAroundView
|
|
|
|
|
}
|
|
|
|
|
.overlay(alignment: .bottom) {
|
|
|
|
|
altitudeView
|
|
|
|
|
}
|
|
|
|
|
.sheet(isPresented: $isEditingSettings) {
|
|
|
|
|
MapSettingsForm(traffic: $showTraffic, pointsOfInterest: $showPointsOfInterest, mapLayer: $selectedMapLayer, meshMap: $isMeshMap, enabledOverlayConfigs: $enabledOverlayConfigs)
|
|
|
|
|
}
|
2026-04-05 14:40:54 -07:00
|
|
|
.sheet(isPresented: $isShowingLegend) {
|
|
|
|
|
MapLegend(isMeshMap: false)
|
|
|
|
|
.presentationDetents([.medium, .large])
|
|
|
|
|
.presentationContentInteraction(.scrolls)
|
|
|
|
|
.presentationDragIndicator(.visible)
|
|
|
|
|
.presentationBackgroundInteraction(.enabled(upThrough: .medium))
|
|
|
|
|
}
|
2025-07-22 03:23:43 +00:00
|
|
|
.onChange(of: selectedMapLayer) { _, newMapLayer in
|
|
|
|
|
updateMapStyle(for: newMapLayer)
|
|
|
|
|
}
|
|
|
|
|
.onChange(of: node) {
|
|
|
|
|
handleNodeChange()
|
|
|
|
|
}
|
|
|
|
|
.onAppear {
|
|
|
|
|
handleAppear()
|
|
|
|
|
}
|
|
|
|
|
.safeAreaInset(edge: .bottom, alignment: .trailing) {
|
|
|
|
|
controlButtons
|
|
|
|
|
}
|
|
|
|
|
.onDisappear {
|
|
|
|
|
UIApplication.shared.isIdleTimerDisabled = false
|
|
|
|
|
}
|
|
|
|
|
}
|
2025-07-22 06:40:43 +00:00
|
|
|
|
2.7.6 Working Changes (#1479)
* Bump version
* Message list performance fixes into 2.7.6 (#1475)
* Remove extra want config call when adding a contact
* App badge and unnecessary notification fixes (#1455)
* - Fix for app badge not going to zero if a message arrives while you have that chat open
- Fix for push notifications popping up when a message is received while that chat is open
* Fix for cancelling notifications, works now. And scroll to bottom of conversation upon new message
* Fix: Channels help grammer fix (#1452)
* remove outdated TCP not available on Apple devices (#1450)
* Update initial onboarding view
* remove toggle gating for mac
* Update crash reporting opt out in real time
* Update onboarding text
* Use mDNS text records for node name
* TCP IP and port on the connection screen
* Hide app icon chooser on mac
* Infinite loop hang bugfixes and performance improvements for both `UserMessageList` and `ChannelMessageList` (#1465)
* 2.7.5 Working Changes (#1460)
* Remove extra want config call when adding a contact
* App badge and unnecessary notification fixes (#1455)
* - Fix for app badge not going to zero if a message arrives while you have that chat open
- Fix for push notifications popping up when a message is received while that chat is open
* Fix for cancelling notifications, works now. And scroll to bottom of conversation upon new message
* Fix: Channels help grammer fix (#1452)
* remove outdated TCP not available on Apple devices (#1450)
* Update initial onboarding view
* remove toggle gating for mac
* Update crash reporting opt out in real time
* Update onboarding text
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
* UserEntity: add mostRecentMessage and unreadMessages with early exit when lastMessage is nil, and fetch 1 row (not N) otherwise
* UserList: replace 5 slow calls to user.messageList with new fast calls
* NodeList: always put the connected node at the top of list (if it matches the node filters)
* ChannelEntity: add faster mostRecentPrivateMessage and unreadMessages which fetch 1 row (not N)
* ChannelList: replace 5 calls to channel.allPrivateMessage with new fast calls
* Fix incorrect appState.unreadDirectMessages calculations
* MyInfoEntity: also fix unreadMessages count here to be fast, and use it for appState.unreadChannelMessages
* UserMessageList: use @FetchRequest to prevent the N^2 behavior that was happening in calls to allPrivateMessages
* Refactor ChannelEntityExtension and MyInfoEntityExtension to be more similar to UserEntityExtension
* Remove SwiftUI-infinite-loop-causing `.id(redrawTapbacksTrigger)` in ChannelMessageList and UserMessageList (duplicate row ids)
* MyInfoEntityExtension: exclude emoji tapbacks (which never get marked as read anyway) from unread message count
* Add SaveChannelLinkData so MessageText and MeshtasticApp can use .sheet(item: ...) and avoid infinite loop hang due to Binding rebuild
* ChannelMessageList and UserMessageList: switch to stable messageId for ForEach SwiftUI row identity
* ChannelMessageList and UserMessageList: debouncedScrollToBottom; keyboardWillShowNotification/keyboardDidShowNotification
* ChannelMessageList and UserMessageList: scroll to bottom onFirstAppear
* ChannelMessageList and UserMessageList: block spurious markMessagesAsRead when this View is not active
---------
Co-authored-by: Garth Vander Houwen <garth@meshtastic.com>
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
* message-list-performance: revert scrolling changes (#1472)
* Revert e0f0b4a0f749d2e83946f2c1297e5c97c9fdf46e (ChannelMessageList and UserMessageList: scroll to bottom onFirstAppear)
* Revert "ChannelMessageList and UserMessageList: debouncedScrollToBottom; keyboardWillShowNotification/keyboardDidShowNotification"
This reverts commit ee1a7c44157eb6970ec2111fc1ac4d67a44a8238.
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
Co-authored-by: Mike Robbins <mrobbins@alum.mit.edu>
* Explicitly set unmessagable, seems unnessary
* Add back missing mesh map features
* Fix: "Retrieving nodes" significantly slower after reconnect extracted from #1424 (#1477)
* Fix: "Retrieving nodes" significantly slower after reconnect (#1424)
The node database retrieval was calling context.save() for every single
NodeInfo packet received (250 saves for 250 nodes). This caused severe
performance degradation on reconnect when CoreData had accumulated state.
Root Cause:
- nodeInfoPacket() called context.save() immediately for each node
- With 250 nodes, this meant 250 individual CoreData save operations
- On first connection, CoreData is fresh and fast
- On reconnect, CoreData has accumulated change tracking, undo management,
and memory pressure, making each save progressively slower
- This resulted in 10+ second retrieval times vs 1-2 seconds initially
Solution:
- Added deferSave parameter to nodeInfoPacket() function
- During database retrieval (.retrievingDatabase state), defer all saves
- Perform a single batch save when database retrieval completes
(when NONCE_ONLY_DB configCompleteID is received)
- This reduces 250 saves to 1 save
Performance Impact:
- Eliminates N individual saves during node database sync
- Reduces database retrieval time back to 1-2 seconds on reconnect
- Matches first-connection performance consistently
Fixes #1424
* Revert *MessageListUnified files
---------
Co-authored-by: Martin Bogomolni <martinbogo@gmail.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
* Hide route lines filter from mesh map
* Mesh Map: fuzz imprecise locations so they're distinguishable and clickable at the highest zoom levels (#1478)
Co-authored-by: Garth Vander Houwen <garth@meshtastic.com>
* Fix bad merge
* Update Meshtastic/Extensions/CoreData/UserEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Nodes/Helpers/Map/MapContent/MeshMapContent.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/ChannelEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/MyInfoEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/ChannelEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Keep list of previous manual connections (#1484)
* Keep list of previous manual connections
* More descriptive manual connection rows
* Merge fixes and new way to show IP on Connect view
---------
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
* Show who relayed messages (#1486)
* Add identification for node that relayed text messages and add count for ammount of relayers of your message
* Ack Relays
* upsertPositionPacket: don't use future timestamps to set node's lastHeard (#1488)
* R1 NEO
* Neo
* Update Meshtastic/Views/Settings/AppSettings.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Remove bad if
* Git rid of extra environment variable
* Update Meshtastic/Accessory/Transports/TCP/TCPTransport.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* MeshMap performance: quick wins (#1490)
* MeshMap: change onMapCameraChange frequency to .onEnd so that zooming doesn't cause continuous SwiftUI reevaluation on every frame
* MeshMapContent: factor out reducedPrecisionMapCircles into a separate function
* MeshMapContent: when multiple reducedPrecisionCircles have the same (lat,lon,radius), just draw one (big perf boost in dense areas)
* NodeMap performance improvements for high # positions history (#1480)
* NodeMapContent: move Route Lines out of ForEach
* NodeMapContent: move Convex Hull out of ForEach
* NodeMapContent: Replace `position.nodePosition?` with `node`
* NodeMapContent: drop unnecessary LazyVStack in showNodeHistory
* NodeMapContent: hoist out nodeColorSwift
* Move lineCoords, loraCoords calculations within showRouteLines, showConvexHull respectively
* Hoist out repeated node.metadata?.positionFlags lookups / PositionFlags creation
* NodeMapContent: remove unused @State
* NodeMapSwiftUI: add NodeMapContentEquatableWrapper and NodeMapContentSignature to prevent frequent NodeMapContent recomputation and infinite render loops
* NodeMapSwiftUI: disable animation during SwiftUI transactions
* NodeMapContent: hoist nodeBorderColor and set allowsHitTesting(false) on history point views
* NodeMapContent: prerenderHistoryPointCircle and prerenderHistoryPointArrow to avoid thousands of vector draw operations
* NodeMapContent: Shared coordinate list for Route Lines and Convex Hull
* NodeMapContent.prerenderHistoryPointArrow: add .frame(width: 16, height: 16)
* Fix wantRangeTestPackets to correctly follow rangeTestConfig.enabled (#1489)
* Fix interval drop down formatter
* Clean up channel qr code functionality.
* perferredPeripheralId fix
* Set opt in
* Retry once 5 second timer. dont throw the error
* Queue for peripherals
* Fix: hoplimit of dms would always fallback to hops away of the node even when configured hops was higher (#1495)
* fix hops setting in dms
* Fix hops for exchange position
* Final fix
* Don't favorite client base
* Update device hardware
* Prevent nil environment metrics
* Bump datadog sdk
* fix setting device telemetry enabled (#1515)
* Update Muzi R1 Neo to actively supported
* fix setting device telemetry enabled
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Don't subscribe to mqtt topic if downlink is not on (#1501)
* Dont sub if no downlink
* moved reload mqtt connect config
* Preview enabled in connected devices (#1509)
* Update Muzi R1 Neo to actively supported
* Preview enabled in connected devices
* Fixing indentation
* Fixing indentation
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* UpdateCoreData.updateAnyPacketFrom: mirror firmware's lastHeard/snr/rssi/hopsAway update logic from NodeDB::updateFrom (#1492)
* `CLIENT_BASE` add-favorite/role-change confirmation dialog (#1493)
* FavoriteNodeButton: refactor task out
* AccessoryManager.connectedDeviceRole helper
* FavoriteNodeButton: show confirmation dialog when a CLIENT_BASE is trying to add a favorite
* addContactFromURL: add comment referencing upcoming change in https://github.com/meshtastic/firmware/pull/8495
* DeviceConfig: role picker: show a warning when selecting CLIENT_BASE, similar to warning shown for ROUTER
* Adjust device configuration Client Base warning text
* Compass view (#1521)
* Added compass view
* Added Compass View
* Node colors in compass
* Update Muzi R1 Neo to actively supported
* Update PositionPopover.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Helpers/CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Helpers/CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Benjamin Faershtein <119711889+RCGV1@users.noreply.github.com>
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Remove discovery queue
* revert problematic retry functionalliy
* format file
* Update & improve zh-Hans translation (#1523)
* Update Muzi R1 Neo to actively supported
* update & improve zh-Hans translation
rt
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Update protobufs to 2.7.1
* Add long-turbo preset
* Disable Range Test module when primary channel is public/unsecured (#1512)
* Update Muzi R1 Neo to actively supported
* Disable Range Test module when primary channel is public/unsecured
Updated RangeTestConfig.swift to determine whether the primary channel (index 0) is operating without encryption or with a 1-byte minimal PSK.
Disabled Range Test UI controls when on a public/default channel to prevent user interaction.
Added safety enforcement in the save operation: Range Test enabled flag is automatically forced to false before sending updates to the device.
Introduced a computed property isPrimaryChannelPublic following existing code patterns and security indicators (e.g., hexDescription PSK length).
Matches the behavior implemented in the Android client for consistent policy across platforms.
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Add new device images
* Remove print statement, get rid of cut and paste error
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
Co-authored-by: Mike Robbins <mrobbins@alum.mit.edu>
Co-authored-by: Martin Bogomolni <martinbogo@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: jake-b <1012393+jake-b@users.noreply.github.com>
Co-authored-by: Benjamin Faershtein <119711889+RCGV1@users.noreply.github.com>
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: Charles Pinesky <25388414+Vaidios@users.noreply.github.com>
Co-authored-by: Radio <35003866+radiolee@users.noreply.github.com>
Co-authored-by: Jason Houk <dubsectordevelopment@gmail.com>
2025-12-21 12:15:01 -08:00
|
|
|
private var mapContentSignature: NodeMapContentSignature {
|
2026-04-16 12:10:00 -07:00
|
|
|
let positionCount = node.positions.count
|
|
|
|
|
let lastPositionTime = node.positions.last?.time
|
2.7.6 Working Changes (#1479)
* Bump version
* Message list performance fixes into 2.7.6 (#1475)
* Remove extra want config call when adding a contact
* App badge and unnecessary notification fixes (#1455)
* - Fix for app badge not going to zero if a message arrives while you have that chat open
- Fix for push notifications popping up when a message is received while that chat is open
* Fix for cancelling notifications, works now. And scroll to bottom of conversation upon new message
* Fix: Channels help grammer fix (#1452)
* remove outdated TCP not available on Apple devices (#1450)
* Update initial onboarding view
* remove toggle gating for mac
* Update crash reporting opt out in real time
* Update onboarding text
* Use mDNS text records for node name
* TCP IP and port on the connection screen
* Hide app icon chooser on mac
* Infinite loop hang bugfixes and performance improvements for both `UserMessageList` and `ChannelMessageList` (#1465)
* 2.7.5 Working Changes (#1460)
* Remove extra want config call when adding a contact
* App badge and unnecessary notification fixes (#1455)
* - Fix for app badge not going to zero if a message arrives while you have that chat open
- Fix for push notifications popping up when a message is received while that chat is open
* Fix for cancelling notifications, works now. And scroll to bottom of conversation upon new message
* Fix: Channels help grammer fix (#1452)
* remove outdated TCP not available on Apple devices (#1450)
* Update initial onboarding view
* remove toggle gating for mac
* Update crash reporting opt out in real time
* Update onboarding text
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
* UserEntity: add mostRecentMessage and unreadMessages with early exit when lastMessage is nil, and fetch 1 row (not N) otherwise
* UserList: replace 5 slow calls to user.messageList with new fast calls
* NodeList: always put the connected node at the top of list (if it matches the node filters)
* ChannelEntity: add faster mostRecentPrivateMessage and unreadMessages which fetch 1 row (not N)
* ChannelList: replace 5 calls to channel.allPrivateMessage with new fast calls
* Fix incorrect appState.unreadDirectMessages calculations
* MyInfoEntity: also fix unreadMessages count here to be fast, and use it for appState.unreadChannelMessages
* UserMessageList: use @FetchRequest to prevent the N^2 behavior that was happening in calls to allPrivateMessages
* Refactor ChannelEntityExtension and MyInfoEntityExtension to be more similar to UserEntityExtension
* Remove SwiftUI-infinite-loop-causing `.id(redrawTapbacksTrigger)` in ChannelMessageList and UserMessageList (duplicate row ids)
* MyInfoEntityExtension: exclude emoji tapbacks (which never get marked as read anyway) from unread message count
* Add SaveChannelLinkData so MessageText and MeshtasticApp can use .sheet(item: ...) and avoid infinite loop hang due to Binding rebuild
* ChannelMessageList and UserMessageList: switch to stable messageId for ForEach SwiftUI row identity
* ChannelMessageList and UserMessageList: debouncedScrollToBottom; keyboardWillShowNotification/keyboardDidShowNotification
* ChannelMessageList and UserMessageList: scroll to bottom onFirstAppear
* ChannelMessageList and UserMessageList: block spurious markMessagesAsRead when this View is not active
---------
Co-authored-by: Garth Vander Houwen <garth@meshtastic.com>
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
* message-list-performance: revert scrolling changes (#1472)
* Revert e0f0b4a0f749d2e83946f2c1297e5c97c9fdf46e (ChannelMessageList and UserMessageList: scroll to bottom onFirstAppear)
* Revert "ChannelMessageList and UserMessageList: debouncedScrollToBottom; keyboardWillShowNotification/keyboardDidShowNotification"
This reverts commit ee1a7c44157eb6970ec2111fc1ac4d67a44a8238.
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
Co-authored-by: Mike Robbins <mrobbins@alum.mit.edu>
* Explicitly set unmessagable, seems unnessary
* Add back missing mesh map features
* Fix: "Retrieving nodes" significantly slower after reconnect extracted from #1424 (#1477)
* Fix: "Retrieving nodes" significantly slower after reconnect (#1424)
The node database retrieval was calling context.save() for every single
NodeInfo packet received (250 saves for 250 nodes). This caused severe
performance degradation on reconnect when CoreData had accumulated state.
Root Cause:
- nodeInfoPacket() called context.save() immediately for each node
- With 250 nodes, this meant 250 individual CoreData save operations
- On first connection, CoreData is fresh and fast
- On reconnect, CoreData has accumulated change tracking, undo management,
and memory pressure, making each save progressively slower
- This resulted in 10+ second retrieval times vs 1-2 seconds initially
Solution:
- Added deferSave parameter to nodeInfoPacket() function
- During database retrieval (.retrievingDatabase state), defer all saves
- Perform a single batch save when database retrieval completes
(when NONCE_ONLY_DB configCompleteID is received)
- This reduces 250 saves to 1 save
Performance Impact:
- Eliminates N individual saves during node database sync
- Reduces database retrieval time back to 1-2 seconds on reconnect
- Matches first-connection performance consistently
Fixes #1424
* Revert *MessageListUnified files
---------
Co-authored-by: Martin Bogomolni <martinbogo@gmail.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
* Hide route lines filter from mesh map
* Mesh Map: fuzz imprecise locations so they're distinguishable and clickable at the highest zoom levels (#1478)
Co-authored-by: Garth Vander Houwen <garth@meshtastic.com>
* Fix bad merge
* Update Meshtastic/Extensions/CoreData/UserEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Nodes/Helpers/Map/MapContent/MeshMapContent.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/ChannelEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/MyInfoEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/ChannelEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Keep list of previous manual connections (#1484)
* Keep list of previous manual connections
* More descriptive manual connection rows
* Merge fixes and new way to show IP on Connect view
---------
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
* Show who relayed messages (#1486)
* Add identification for node that relayed text messages and add count for ammount of relayers of your message
* Ack Relays
* upsertPositionPacket: don't use future timestamps to set node's lastHeard (#1488)
* R1 NEO
* Neo
* Update Meshtastic/Views/Settings/AppSettings.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Remove bad if
* Git rid of extra environment variable
* Update Meshtastic/Accessory/Transports/TCP/TCPTransport.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* MeshMap performance: quick wins (#1490)
* MeshMap: change onMapCameraChange frequency to .onEnd so that zooming doesn't cause continuous SwiftUI reevaluation on every frame
* MeshMapContent: factor out reducedPrecisionMapCircles into a separate function
* MeshMapContent: when multiple reducedPrecisionCircles have the same (lat,lon,radius), just draw one (big perf boost in dense areas)
* NodeMap performance improvements for high # positions history (#1480)
* NodeMapContent: move Route Lines out of ForEach
* NodeMapContent: move Convex Hull out of ForEach
* NodeMapContent: Replace `position.nodePosition?` with `node`
* NodeMapContent: drop unnecessary LazyVStack in showNodeHistory
* NodeMapContent: hoist out nodeColorSwift
* Move lineCoords, loraCoords calculations within showRouteLines, showConvexHull respectively
* Hoist out repeated node.metadata?.positionFlags lookups / PositionFlags creation
* NodeMapContent: remove unused @State
* NodeMapSwiftUI: add NodeMapContentEquatableWrapper and NodeMapContentSignature to prevent frequent NodeMapContent recomputation and infinite render loops
* NodeMapSwiftUI: disable animation during SwiftUI transactions
* NodeMapContent: hoist nodeBorderColor and set allowsHitTesting(false) on history point views
* NodeMapContent: prerenderHistoryPointCircle and prerenderHistoryPointArrow to avoid thousands of vector draw operations
* NodeMapContent: Shared coordinate list for Route Lines and Convex Hull
* NodeMapContent.prerenderHistoryPointArrow: add .frame(width: 16, height: 16)
* Fix wantRangeTestPackets to correctly follow rangeTestConfig.enabled (#1489)
* Fix interval drop down formatter
* Clean up channel qr code functionality.
* perferredPeripheralId fix
* Set opt in
* Retry once 5 second timer. dont throw the error
* Queue for peripherals
* Fix: hoplimit of dms would always fallback to hops away of the node even when configured hops was higher (#1495)
* fix hops setting in dms
* Fix hops for exchange position
* Final fix
* Don't favorite client base
* Update device hardware
* Prevent nil environment metrics
* Bump datadog sdk
* fix setting device telemetry enabled (#1515)
* Update Muzi R1 Neo to actively supported
* fix setting device telemetry enabled
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Don't subscribe to mqtt topic if downlink is not on (#1501)
* Dont sub if no downlink
* moved reload mqtt connect config
* Preview enabled in connected devices (#1509)
* Update Muzi R1 Neo to actively supported
* Preview enabled in connected devices
* Fixing indentation
* Fixing indentation
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* UpdateCoreData.updateAnyPacketFrom: mirror firmware's lastHeard/snr/rssi/hopsAway update logic from NodeDB::updateFrom (#1492)
* `CLIENT_BASE` add-favorite/role-change confirmation dialog (#1493)
* FavoriteNodeButton: refactor task out
* AccessoryManager.connectedDeviceRole helper
* FavoriteNodeButton: show confirmation dialog when a CLIENT_BASE is trying to add a favorite
* addContactFromURL: add comment referencing upcoming change in https://github.com/meshtastic/firmware/pull/8495
* DeviceConfig: role picker: show a warning when selecting CLIENT_BASE, similar to warning shown for ROUTER
* Adjust device configuration Client Base warning text
* Compass view (#1521)
* Added compass view
* Added Compass View
* Node colors in compass
* Update Muzi R1 Neo to actively supported
* Update PositionPopover.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Helpers/CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Helpers/CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Benjamin Faershtein <119711889+RCGV1@users.noreply.github.com>
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Remove discovery queue
* revert problematic retry functionalliy
* format file
* Update & improve zh-Hans translation (#1523)
* Update Muzi R1 Neo to actively supported
* update & improve zh-Hans translation
rt
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Update protobufs to 2.7.1
* Add long-turbo preset
* Disable Range Test module when primary channel is public/unsecured (#1512)
* Update Muzi R1 Neo to actively supported
* Disable Range Test module when primary channel is public/unsecured
Updated RangeTestConfig.swift to determine whether the primary channel (index 0) is operating without encryption or with a 1-byte minimal PSK.
Disabled Range Test UI controls when on a public/default channel to prevent user interaction.
Added safety enforcement in the save operation: Range Test enabled flag is automatically forced to false before sending updates to the device.
Introduced a computed property isPrimaryChannelPublic following existing code patterns and security indicators (e.g., hexDescription PSK length).
Matches the behavior implemented in the Android client for consistent policy across platforms.
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Add new device images
* Remove print statement, get rid of cut and paste error
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
Co-authored-by: Mike Robbins <mrobbins@alum.mit.edu>
Co-authored-by: Martin Bogomolni <martinbogo@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: jake-b <1012393+jake-b@users.noreply.github.com>
Co-authored-by: Benjamin Faershtein <119711889+RCGV1@users.noreply.github.com>
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: Charles Pinesky <25388414+Vaidios@users.noreply.github.com>
Co-authored-by: Radio <35003866+radiolee@users.noreply.github.com>
Co-authored-by: Jason Houk <dubsectordevelopment@gmail.com>
2025-12-21 12:15:01 -08:00
|
|
|
return NodeMapContentSignature(nodeNum: node.num, positionCount: positionCount, lastPositionTime: lastPositionTime, showNodeHistory: showNodeHistory, showRouteLines: showRouteLines, showConvexHull: showConvexHull, favorite: node.favorite)
|
|
|
|
|
}
|
|
|
|
|
|
2025-07-22 03:23:43 +00:00
|
|
|
private var baseMap: some View {
|
2.7.6 Working Changes (#1479)
* Bump version
* Message list performance fixes into 2.7.6 (#1475)
* Remove extra want config call when adding a contact
* App badge and unnecessary notification fixes (#1455)
* - Fix for app badge not going to zero if a message arrives while you have that chat open
- Fix for push notifications popping up when a message is received while that chat is open
* Fix for cancelling notifications, works now. And scroll to bottom of conversation upon new message
* Fix: Channels help grammer fix (#1452)
* remove outdated TCP not available on Apple devices (#1450)
* Update initial onboarding view
* remove toggle gating for mac
* Update crash reporting opt out in real time
* Update onboarding text
* Use mDNS text records for node name
* TCP IP and port on the connection screen
* Hide app icon chooser on mac
* Infinite loop hang bugfixes and performance improvements for both `UserMessageList` and `ChannelMessageList` (#1465)
* 2.7.5 Working Changes (#1460)
* Remove extra want config call when adding a contact
* App badge and unnecessary notification fixes (#1455)
* - Fix for app badge not going to zero if a message arrives while you have that chat open
- Fix for push notifications popping up when a message is received while that chat is open
* Fix for cancelling notifications, works now. And scroll to bottom of conversation upon new message
* Fix: Channels help grammer fix (#1452)
* remove outdated TCP not available on Apple devices (#1450)
* Update initial onboarding view
* remove toggle gating for mac
* Update crash reporting opt out in real time
* Update onboarding text
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
* UserEntity: add mostRecentMessage and unreadMessages with early exit when lastMessage is nil, and fetch 1 row (not N) otherwise
* UserList: replace 5 slow calls to user.messageList with new fast calls
* NodeList: always put the connected node at the top of list (if it matches the node filters)
* ChannelEntity: add faster mostRecentPrivateMessage and unreadMessages which fetch 1 row (not N)
* ChannelList: replace 5 calls to channel.allPrivateMessage with new fast calls
* Fix incorrect appState.unreadDirectMessages calculations
* MyInfoEntity: also fix unreadMessages count here to be fast, and use it for appState.unreadChannelMessages
* UserMessageList: use @FetchRequest to prevent the N^2 behavior that was happening in calls to allPrivateMessages
* Refactor ChannelEntityExtension and MyInfoEntityExtension to be more similar to UserEntityExtension
* Remove SwiftUI-infinite-loop-causing `.id(redrawTapbacksTrigger)` in ChannelMessageList and UserMessageList (duplicate row ids)
* MyInfoEntityExtension: exclude emoji tapbacks (which never get marked as read anyway) from unread message count
* Add SaveChannelLinkData so MessageText and MeshtasticApp can use .sheet(item: ...) and avoid infinite loop hang due to Binding rebuild
* ChannelMessageList and UserMessageList: switch to stable messageId for ForEach SwiftUI row identity
* ChannelMessageList and UserMessageList: debouncedScrollToBottom; keyboardWillShowNotification/keyboardDidShowNotification
* ChannelMessageList and UserMessageList: scroll to bottom onFirstAppear
* ChannelMessageList and UserMessageList: block spurious markMessagesAsRead when this View is not active
---------
Co-authored-by: Garth Vander Houwen <garth@meshtastic.com>
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
* message-list-performance: revert scrolling changes (#1472)
* Revert e0f0b4a0f749d2e83946f2c1297e5c97c9fdf46e (ChannelMessageList and UserMessageList: scroll to bottom onFirstAppear)
* Revert "ChannelMessageList and UserMessageList: debouncedScrollToBottom; keyboardWillShowNotification/keyboardDidShowNotification"
This reverts commit ee1a7c44157eb6970ec2111fc1ac4d67a44a8238.
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
Co-authored-by: Mike Robbins <mrobbins@alum.mit.edu>
* Explicitly set unmessagable, seems unnessary
* Add back missing mesh map features
* Fix: "Retrieving nodes" significantly slower after reconnect extracted from #1424 (#1477)
* Fix: "Retrieving nodes" significantly slower after reconnect (#1424)
The node database retrieval was calling context.save() for every single
NodeInfo packet received (250 saves for 250 nodes). This caused severe
performance degradation on reconnect when CoreData had accumulated state.
Root Cause:
- nodeInfoPacket() called context.save() immediately for each node
- With 250 nodes, this meant 250 individual CoreData save operations
- On first connection, CoreData is fresh and fast
- On reconnect, CoreData has accumulated change tracking, undo management,
and memory pressure, making each save progressively slower
- This resulted in 10+ second retrieval times vs 1-2 seconds initially
Solution:
- Added deferSave parameter to nodeInfoPacket() function
- During database retrieval (.retrievingDatabase state), defer all saves
- Perform a single batch save when database retrieval completes
(when NONCE_ONLY_DB configCompleteID is received)
- This reduces 250 saves to 1 save
Performance Impact:
- Eliminates N individual saves during node database sync
- Reduces database retrieval time back to 1-2 seconds on reconnect
- Matches first-connection performance consistently
Fixes #1424
* Revert *MessageListUnified files
---------
Co-authored-by: Martin Bogomolni <martinbogo@gmail.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
* Hide route lines filter from mesh map
* Mesh Map: fuzz imprecise locations so they're distinguishable and clickable at the highest zoom levels (#1478)
Co-authored-by: Garth Vander Houwen <garth@meshtastic.com>
* Fix bad merge
* Update Meshtastic/Extensions/CoreData/UserEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Nodes/Helpers/Map/MapContent/MeshMapContent.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/ChannelEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/MyInfoEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/ChannelEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Keep list of previous manual connections (#1484)
* Keep list of previous manual connections
* More descriptive manual connection rows
* Merge fixes and new way to show IP on Connect view
---------
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
* Show who relayed messages (#1486)
* Add identification for node that relayed text messages and add count for ammount of relayers of your message
* Ack Relays
* upsertPositionPacket: don't use future timestamps to set node's lastHeard (#1488)
* R1 NEO
* Neo
* Update Meshtastic/Views/Settings/AppSettings.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Remove bad if
* Git rid of extra environment variable
* Update Meshtastic/Accessory/Transports/TCP/TCPTransport.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* MeshMap performance: quick wins (#1490)
* MeshMap: change onMapCameraChange frequency to .onEnd so that zooming doesn't cause continuous SwiftUI reevaluation on every frame
* MeshMapContent: factor out reducedPrecisionMapCircles into a separate function
* MeshMapContent: when multiple reducedPrecisionCircles have the same (lat,lon,radius), just draw one (big perf boost in dense areas)
* NodeMap performance improvements for high # positions history (#1480)
* NodeMapContent: move Route Lines out of ForEach
* NodeMapContent: move Convex Hull out of ForEach
* NodeMapContent: Replace `position.nodePosition?` with `node`
* NodeMapContent: drop unnecessary LazyVStack in showNodeHistory
* NodeMapContent: hoist out nodeColorSwift
* Move lineCoords, loraCoords calculations within showRouteLines, showConvexHull respectively
* Hoist out repeated node.metadata?.positionFlags lookups / PositionFlags creation
* NodeMapContent: remove unused @State
* NodeMapSwiftUI: add NodeMapContentEquatableWrapper and NodeMapContentSignature to prevent frequent NodeMapContent recomputation and infinite render loops
* NodeMapSwiftUI: disable animation during SwiftUI transactions
* NodeMapContent: hoist nodeBorderColor and set allowsHitTesting(false) on history point views
* NodeMapContent: prerenderHistoryPointCircle and prerenderHistoryPointArrow to avoid thousands of vector draw operations
* NodeMapContent: Shared coordinate list for Route Lines and Convex Hull
* NodeMapContent.prerenderHistoryPointArrow: add .frame(width: 16, height: 16)
* Fix wantRangeTestPackets to correctly follow rangeTestConfig.enabled (#1489)
* Fix interval drop down formatter
* Clean up channel qr code functionality.
* perferredPeripheralId fix
* Set opt in
* Retry once 5 second timer. dont throw the error
* Queue for peripherals
* Fix: hoplimit of dms would always fallback to hops away of the node even when configured hops was higher (#1495)
* fix hops setting in dms
* Fix hops for exchange position
* Final fix
* Don't favorite client base
* Update device hardware
* Prevent nil environment metrics
* Bump datadog sdk
* fix setting device telemetry enabled (#1515)
* Update Muzi R1 Neo to actively supported
* fix setting device telemetry enabled
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Don't subscribe to mqtt topic if downlink is not on (#1501)
* Dont sub if no downlink
* moved reload mqtt connect config
* Preview enabled in connected devices (#1509)
* Update Muzi R1 Neo to actively supported
* Preview enabled in connected devices
* Fixing indentation
* Fixing indentation
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* UpdateCoreData.updateAnyPacketFrom: mirror firmware's lastHeard/snr/rssi/hopsAway update logic from NodeDB::updateFrom (#1492)
* `CLIENT_BASE` add-favorite/role-change confirmation dialog (#1493)
* FavoriteNodeButton: refactor task out
* AccessoryManager.connectedDeviceRole helper
* FavoriteNodeButton: show confirmation dialog when a CLIENT_BASE is trying to add a favorite
* addContactFromURL: add comment referencing upcoming change in https://github.com/meshtastic/firmware/pull/8495
* DeviceConfig: role picker: show a warning when selecting CLIENT_BASE, similar to warning shown for ROUTER
* Adjust device configuration Client Base warning text
* Compass view (#1521)
* Added compass view
* Added Compass View
* Node colors in compass
* Update Muzi R1 Neo to actively supported
* Update PositionPopover.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Helpers/CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Helpers/CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Benjamin Faershtein <119711889+RCGV1@users.noreply.github.com>
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Remove discovery queue
* revert problematic retry functionalliy
* format file
* Update & improve zh-Hans translation (#1523)
* Update Muzi R1 Neo to actively supported
* update & improve zh-Hans translation
rt
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Update protobufs to 2.7.1
* Add long-turbo preset
* Disable Range Test module when primary channel is public/unsecured (#1512)
* Update Muzi R1 Neo to actively supported
* Disable Range Test module when primary channel is public/unsecured
Updated RangeTestConfig.swift to determine whether the primary channel (index 0) is operating without encryption or with a 1-byte minimal PSK.
Disabled Range Test UI controls when on a public/default channel to prevent user interaction.
Added safety enforcement in the save operation: Range Test enabled flag is automatically forced to false before sending updates to the device.
Introduced a computed property isPrimaryChannelPublic following existing code patterns and security indicators (e.g., hexDescription PSK length).
Matches the behavior implemented in the Android client for consistent policy across platforms.
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Add new device images
* Remove print statement, get rid of cut and paste error
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
Co-authored-by: Mike Robbins <mrobbins@alum.mit.edu>
Co-authored-by: Martin Bogomolni <martinbogo@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: jake-b <1012393+jake-b@users.noreply.github.com>
Co-authored-by: Benjamin Faershtein <119711889+RCGV1@users.noreply.github.com>
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: Charles Pinesky <25388414+Vaidios@users.noreply.github.com>
Co-authored-by: Radio <35003866+radiolee@users.noreply.github.com>
Co-authored-by: Jason Houk <dubsectordevelopment@gmail.com>
2025-12-21 12:15:01 -08:00
|
|
|
NodeMapContentEquatableWrapper(signature: mapContentSignature) {
|
|
|
|
|
Map(position: $position, bounds: MapCameraBounds(minimumDistance: 0, maximumDistance: .infinity), scope: mapScope) {
|
|
|
|
|
NodeMapContent(node: node)
|
|
|
|
|
}
|
2025-07-22 03:23:43 +00:00
|
|
|
}
|
|
|
|
|
.mapScope(mapScope)
|
|
|
|
|
.mapStyle(mapStyle)
|
|
|
|
|
.mapControls {
|
|
|
|
|
MapScaleView(scope: mapScope)
|
|
|
|
|
.mapControlVisibility(.visible)
|
|
|
|
|
if showUserLocation {
|
|
|
|
|
MapUserLocationButton(scope: mapScope)
|
|
|
|
|
.mapControlVisibility(.visible)
|
|
|
|
|
}
|
|
|
|
|
MapPitchToggle(scope: mapScope)
|
|
|
|
|
.mapControlVisibility(.visible)
|
|
|
|
|
MapCompass(scope: mapScope)
|
|
|
|
|
.mapControlVisibility(.visible)
|
|
|
|
|
}
|
|
|
|
|
.controlSize(.regular)
|
2.7.6 Working Changes (#1479)
* Bump version
* Message list performance fixes into 2.7.6 (#1475)
* Remove extra want config call when adding a contact
* App badge and unnecessary notification fixes (#1455)
* - Fix for app badge not going to zero if a message arrives while you have that chat open
- Fix for push notifications popping up when a message is received while that chat is open
* Fix for cancelling notifications, works now. And scroll to bottom of conversation upon new message
* Fix: Channels help grammer fix (#1452)
* remove outdated TCP not available on Apple devices (#1450)
* Update initial onboarding view
* remove toggle gating for mac
* Update crash reporting opt out in real time
* Update onboarding text
* Use mDNS text records for node name
* TCP IP and port on the connection screen
* Hide app icon chooser on mac
* Infinite loop hang bugfixes and performance improvements for both `UserMessageList` and `ChannelMessageList` (#1465)
* 2.7.5 Working Changes (#1460)
* Remove extra want config call when adding a contact
* App badge and unnecessary notification fixes (#1455)
* - Fix for app badge not going to zero if a message arrives while you have that chat open
- Fix for push notifications popping up when a message is received while that chat is open
* Fix for cancelling notifications, works now. And scroll to bottom of conversation upon new message
* Fix: Channels help grammer fix (#1452)
* remove outdated TCP not available on Apple devices (#1450)
* Update initial onboarding view
* remove toggle gating for mac
* Update crash reporting opt out in real time
* Update onboarding text
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
* UserEntity: add mostRecentMessage and unreadMessages with early exit when lastMessage is nil, and fetch 1 row (not N) otherwise
* UserList: replace 5 slow calls to user.messageList with new fast calls
* NodeList: always put the connected node at the top of list (if it matches the node filters)
* ChannelEntity: add faster mostRecentPrivateMessage and unreadMessages which fetch 1 row (not N)
* ChannelList: replace 5 calls to channel.allPrivateMessage with new fast calls
* Fix incorrect appState.unreadDirectMessages calculations
* MyInfoEntity: also fix unreadMessages count here to be fast, and use it for appState.unreadChannelMessages
* UserMessageList: use @FetchRequest to prevent the N^2 behavior that was happening in calls to allPrivateMessages
* Refactor ChannelEntityExtension and MyInfoEntityExtension to be more similar to UserEntityExtension
* Remove SwiftUI-infinite-loop-causing `.id(redrawTapbacksTrigger)` in ChannelMessageList and UserMessageList (duplicate row ids)
* MyInfoEntityExtension: exclude emoji tapbacks (which never get marked as read anyway) from unread message count
* Add SaveChannelLinkData so MessageText and MeshtasticApp can use .sheet(item: ...) and avoid infinite loop hang due to Binding rebuild
* ChannelMessageList and UserMessageList: switch to stable messageId for ForEach SwiftUI row identity
* ChannelMessageList and UserMessageList: debouncedScrollToBottom; keyboardWillShowNotification/keyboardDidShowNotification
* ChannelMessageList and UserMessageList: scroll to bottom onFirstAppear
* ChannelMessageList and UserMessageList: block spurious markMessagesAsRead when this View is not active
---------
Co-authored-by: Garth Vander Houwen <garth@meshtastic.com>
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
* message-list-performance: revert scrolling changes (#1472)
* Revert e0f0b4a0f749d2e83946f2c1297e5c97c9fdf46e (ChannelMessageList and UserMessageList: scroll to bottom onFirstAppear)
* Revert "ChannelMessageList and UserMessageList: debouncedScrollToBottom; keyboardWillShowNotification/keyboardDidShowNotification"
This reverts commit ee1a7c44157eb6970ec2111fc1ac4d67a44a8238.
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
Co-authored-by: Mike Robbins <mrobbins@alum.mit.edu>
* Explicitly set unmessagable, seems unnessary
* Add back missing mesh map features
* Fix: "Retrieving nodes" significantly slower after reconnect extracted from #1424 (#1477)
* Fix: "Retrieving nodes" significantly slower after reconnect (#1424)
The node database retrieval was calling context.save() for every single
NodeInfo packet received (250 saves for 250 nodes). This caused severe
performance degradation on reconnect when CoreData had accumulated state.
Root Cause:
- nodeInfoPacket() called context.save() immediately for each node
- With 250 nodes, this meant 250 individual CoreData save operations
- On first connection, CoreData is fresh and fast
- On reconnect, CoreData has accumulated change tracking, undo management,
and memory pressure, making each save progressively slower
- This resulted in 10+ second retrieval times vs 1-2 seconds initially
Solution:
- Added deferSave parameter to nodeInfoPacket() function
- During database retrieval (.retrievingDatabase state), defer all saves
- Perform a single batch save when database retrieval completes
(when NONCE_ONLY_DB configCompleteID is received)
- This reduces 250 saves to 1 save
Performance Impact:
- Eliminates N individual saves during node database sync
- Reduces database retrieval time back to 1-2 seconds on reconnect
- Matches first-connection performance consistently
Fixes #1424
* Revert *MessageListUnified files
---------
Co-authored-by: Martin Bogomolni <martinbogo@gmail.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
* Hide route lines filter from mesh map
* Mesh Map: fuzz imprecise locations so they're distinguishable and clickable at the highest zoom levels (#1478)
Co-authored-by: Garth Vander Houwen <garth@meshtastic.com>
* Fix bad merge
* Update Meshtastic/Extensions/CoreData/UserEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Nodes/Helpers/Map/MapContent/MeshMapContent.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/ChannelEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/MyInfoEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Extensions/CoreData/ChannelEntityExtension.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Keep list of previous manual connections (#1484)
* Keep list of previous manual connections
* More descriptive manual connection rows
* Merge fixes and new way to show IP on Connect view
---------
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
* Show who relayed messages (#1486)
* Add identification for node that relayed text messages and add count for ammount of relayers of your message
* Ack Relays
* upsertPositionPacket: don't use future timestamps to set node's lastHeard (#1488)
* R1 NEO
* Neo
* Update Meshtastic/Views/Settings/AppSettings.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Remove bad if
* Git rid of extra environment variable
* Update Meshtastic/Accessory/Transports/TCP/TCPTransport.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* MeshMap performance: quick wins (#1490)
* MeshMap: change onMapCameraChange frequency to .onEnd so that zooming doesn't cause continuous SwiftUI reevaluation on every frame
* MeshMapContent: factor out reducedPrecisionMapCircles into a separate function
* MeshMapContent: when multiple reducedPrecisionCircles have the same (lat,lon,radius), just draw one (big perf boost in dense areas)
* NodeMap performance improvements for high # positions history (#1480)
* NodeMapContent: move Route Lines out of ForEach
* NodeMapContent: move Convex Hull out of ForEach
* NodeMapContent: Replace `position.nodePosition?` with `node`
* NodeMapContent: drop unnecessary LazyVStack in showNodeHistory
* NodeMapContent: hoist out nodeColorSwift
* Move lineCoords, loraCoords calculations within showRouteLines, showConvexHull respectively
* Hoist out repeated node.metadata?.positionFlags lookups / PositionFlags creation
* NodeMapContent: remove unused @State
* NodeMapSwiftUI: add NodeMapContentEquatableWrapper and NodeMapContentSignature to prevent frequent NodeMapContent recomputation and infinite render loops
* NodeMapSwiftUI: disable animation during SwiftUI transactions
* NodeMapContent: hoist nodeBorderColor and set allowsHitTesting(false) on history point views
* NodeMapContent: prerenderHistoryPointCircle and prerenderHistoryPointArrow to avoid thousands of vector draw operations
* NodeMapContent: Shared coordinate list for Route Lines and Convex Hull
* NodeMapContent.prerenderHistoryPointArrow: add .frame(width: 16, height: 16)
* Fix wantRangeTestPackets to correctly follow rangeTestConfig.enabled (#1489)
* Fix interval drop down formatter
* Clean up channel qr code functionality.
* perferredPeripheralId fix
* Set opt in
* Retry once 5 second timer. dont throw the error
* Queue for peripherals
* Fix: hoplimit of dms would always fallback to hops away of the node even when configured hops was higher (#1495)
* fix hops setting in dms
* Fix hops for exchange position
* Final fix
* Don't favorite client base
* Update device hardware
* Prevent nil environment metrics
* Bump datadog sdk
* fix setting device telemetry enabled (#1515)
* Update Muzi R1 Neo to actively supported
* fix setting device telemetry enabled
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Don't subscribe to mqtt topic if downlink is not on (#1501)
* Dont sub if no downlink
* moved reload mqtt connect config
* Preview enabled in connected devices (#1509)
* Update Muzi R1 Neo to actively supported
* Preview enabled in connected devices
* Fixing indentation
* Fixing indentation
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* UpdateCoreData.updateAnyPacketFrom: mirror firmware's lastHeard/snr/rssi/hopsAway update logic from NodeDB::updateFrom (#1492)
* `CLIENT_BASE` add-favorite/role-change confirmation dialog (#1493)
* FavoriteNodeButton: refactor task out
* AccessoryManager.connectedDeviceRole helper
* FavoriteNodeButton: show confirmation dialog when a CLIENT_BASE is trying to add a favorite
* addContactFromURL: add comment referencing upcoming change in https://github.com/meshtastic/firmware/pull/8495
* DeviceConfig: role picker: show a warning when selecting CLIENT_BASE, similar to warning shown for ROUTER
* Adjust device configuration Client Base warning text
* Compass view (#1521)
* Added compass view
* Added Compass View
* Node colors in compass
* Update Muzi R1 Neo to actively supported
* Update PositionPopover.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Helpers/CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Meshtastic/Views/Helpers/CompassView.swift
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Benjamin Faershtein <119711889+RCGV1@users.noreply.github.com>
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Remove discovery queue
* revert problematic retry functionalliy
* format file
* Update & improve zh-Hans translation (#1523)
* Update Muzi R1 Neo to actively supported
* update & improve zh-Hans translation
rt
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Update protobufs to 2.7.1
* Add long-turbo preset
* Disable Range Test module when primary channel is public/unsecured (#1512)
* Update Muzi R1 Neo to actively supported
* Disable Range Test module when primary channel is public/unsecured
Updated RangeTestConfig.swift to determine whether the primary channel (index 0) is operating without encryption or with a 1-byte minimal PSK.
Disabled Range Test UI controls when on a public/default channel to prevent user interaction.
Added safety enforcement in the save operation: Range Test enabled flag is automatically forced to false before sending updates to the device.
Introduced a computed property isPrimaryChannelPublic following existing code patterns and security indicators (e.g., hexDescription PSK length).
Matches the behavior implemented in the Android client for consistent policy across platforms.
---------
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
* Add new device images
* Remove print statement, get rid of cut and paste error
---------
Co-authored-by: Gnome Adrift <646322+gnomeadrift@users.noreply.github.com>
Co-authored-by: Zain Kergaye <62440012+ZainKergaye@users.noreply.github.com>
Co-authored-by: NillRudd <102033730+NillRudd@users.noreply.github.com>
Co-authored-by: Jake-B <jake-b@users.noreply.github.com>
Co-authored-by: Mike Robbins <mrobbins@alum.mit.edu>
Co-authored-by: Martin Bogomolni <martinbogo@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: jake-b <1012393+jake-b@users.noreply.github.com>
Co-authored-by: Benjamin Faershtein <119711889+RCGV1@users.noreply.github.com>
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: Charles Pinesky <25388414+Vaidios@users.noreply.github.com>
Co-authored-by: Radio <35003866+radiolee@users.noreply.github.com>
Co-authored-by: Jason Houk <dubsectordevelopment@gmail.com>
2025-12-21 12:15:01 -08:00
|
|
|
.transaction { $0.animation = nil }
|
2025-07-22 03:23:43 +00:00
|
|
|
}
|
2025-07-22 06:40:43 +00:00
|
|
|
|
2025-07-22 03:23:43 +00:00
|
|
|
private var lookAroundView: some View {
|
|
|
|
|
Group {
|
|
|
|
|
if scene != nil && isLookingAround {
|
|
|
|
|
LookAroundPreview(initialScene: scene)
|
|
|
|
|
.frame(height: UIDevice.current.userInterfaceIdiom == .phone ? 250 : 400)
|
|
|
|
|
.clipShape(RoundedRectangle(cornerRadius: 12))
|
|
|
|
|
.padding(.horizontal, 20)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2025-07-22 06:40:43 +00:00
|
|
|
|
2025-07-22 03:23:43 +00:00
|
|
|
private var altitudeView: some View {
|
|
|
|
|
Group {
|
|
|
|
|
if !isLookingAround && isShowingAltitude {
|
|
|
|
|
PositionAltitudeChart(node: node)
|
|
|
|
|
.frame(height: UIDevice.current.userInterfaceIdiom == .phone ? 250 : 400)
|
|
|
|
|
.clipShape(RoundedRectangle(cornerRadius: 12))
|
|
|
|
|
.padding(.horizontal, 20)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2025-07-22 06:40:43 +00:00
|
|
|
|
2025-07-22 03:23:43 +00:00
|
|
|
private var controlButtons: some View {
|
|
|
|
|
HStack {
|
2026-04-05 14:40:54 -07:00
|
|
|
Button(action: {
|
|
|
|
|
withAnimation {
|
|
|
|
|
isShowingLegend = !isShowingLegend
|
|
|
|
|
}
|
|
|
|
|
}) {
|
|
|
|
|
Image(systemName: isShowingLegend ? "map.fill" : "map")
|
|
|
|
|
}
|
|
|
|
|
.accessibilityLabel(isShowingLegend ? Text("Hide legend") : Text("Show legend"))
|
|
|
|
|
.accessibilityHint(Text("Toggles the map legend"))
|
|
|
|
|
.glassButtonStyle()
|
|
|
|
|
|
2025-07-22 03:23:43 +00:00
|
|
|
Button(action: {
|
|
|
|
|
withAnimation {
|
|
|
|
|
isEditingSettings = !isEditingSettings
|
|
|
|
|
}
|
|
|
|
|
}) {
|
|
|
|
|
Image(systemName: isEditingSettings ? "info.circle.fill" : "info.circle")
|
|
|
|
|
}
|
2026-04-05 14:40:54 -07:00
|
|
|
.glassButtonStyle()
|
2025-07-22 06:40:43 +00:00
|
|
|
|
2025-07-22 03:23:43 +00:00
|
|
|
if scene != nil {
|
|
|
|
|
Button(action: {
|
|
|
|
|
if isShowingAltitude {
|
|
|
|
|
isShowingAltitude = false
|
|
|
|
|
}
|
|
|
|
|
isLookingAround = !isLookingAround
|
|
|
|
|
}) {
|
|
|
|
|
Image(systemName: isLookingAround ? "binoculars.fill" : "binoculars")
|
|
|
|
|
}
|
2026-04-05 14:40:54 -07:00
|
|
|
.glassButtonStyle()
|
2025-07-22 03:23:43 +00:00
|
|
|
}
|
2025-07-22 06:40:43 +00:00
|
|
|
|
2026-04-16 12:10:00 -07:00
|
|
|
if node.positions.count > 1 {
|
2025-07-22 03:23:43 +00:00
|
|
|
Button(action: {
|
|
|
|
|
if isLookingAround {
|
|
|
|
|
isLookingAround = false
|
|
|
|
|
}
|
|
|
|
|
isShowingAltitude = !isShowingAltitude
|
|
|
|
|
}) {
|
|
|
|
|
Image(systemName: isShowingAltitude ? "mountain.2.fill" : "mountain.2")
|
|
|
|
|
}
|
2026-04-05 14:40:54 -07:00
|
|
|
.glassButtonStyle()
|
2025-07-22 03:23:43 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
.controlSize(.regular)
|
|
|
|
|
.padding(5)
|
|
|
|
|
}
|
2025-07-22 06:40:43 +00:00
|
|
|
|
2025-07-22 03:23:43 +00:00
|
|
|
private func updateMapStyle(for layer: MapLayer) {
|
|
|
|
|
UserDefaults.mapLayer = layer
|
|
|
|
|
switch layer {
|
|
|
|
|
case .standard:
|
|
|
|
|
mapStyle = MapStyle.standard(elevation: .flat, pointsOfInterest: showPointsOfInterest ? .all : .excludingAll, showsTraffic: showTraffic)
|
|
|
|
|
case .hybrid:
|
|
|
|
|
mapStyle = MapStyle.hybrid(elevation: .flat, pointsOfInterest: showPointsOfInterest ? .all : .excludingAll, showsTraffic: showTraffic)
|
|
|
|
|
case .satellite:
|
|
|
|
|
mapStyle = MapStyle.imagery(elevation: .flat)
|
|
|
|
|
case .offline:
|
|
|
|
|
break
|
|
|
|
|
}
|
|
|
|
|
}
|
2025-07-22 06:40:43 +00:00
|
|
|
|
2025-07-22 03:23:43 +00:00
|
|
|
private func handleNodeChange() {
|
|
|
|
|
isLookingAround = false
|
|
|
|
|
isShowingAltitude = false
|
2026-04-16 12:10:00 -07:00
|
|
|
let newMostRecent = node.positions.last
|
|
|
|
|
if node.positions.count > 1 {
|
2025-07-22 03:23:43 +00:00
|
|
|
position = .automatic
|
2026-04-16 12:10:00 -07:00
|
|
|
} else if let mrCoord = newMostRecent?.nodeCoordinate {
|
2025-07-22 03:23:43 +00:00
|
|
|
position = .camera(MapCamera(centerCoordinate: mrCoord, distance: distance, heading: 0, pitch: 0))
|
|
|
|
|
}
|
2026-04-16 12:10:00 -07:00
|
|
|
if let newMostRecent, let coord = newMostRecent.nodeCoordinate {
|
2025-07-22 03:23:43 +00:00
|
|
|
Task {
|
2026-04-16 12:10:00 -07:00
|
|
|
scene = try? await fetchScene(for: coord)
|
2025-07-22 03:23:43 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2025-07-22 06:40:43 +00:00
|
|
|
|
2025-07-22 03:23:43 +00:00
|
|
|
private func handleAppear() {
|
|
|
|
|
UIApplication.shared.isIdleTimerDisabled = true
|
|
|
|
|
updateMapStyle(for: selectedMapLayer)
|
2026-04-16 12:10:00 -07:00
|
|
|
let mostRecent = node.positions.last
|
|
|
|
|
if node.positions.count > 1 {
|
2025-07-22 03:23:43 +00:00
|
|
|
position = .automatic
|
2026-04-16 12:10:00 -07:00
|
|
|
} else if let mrCoord = mostRecent?.nodeCoordinate {
|
2025-07-22 03:23:43 +00:00
|
|
|
position = .camera(MapCamera(centerCoordinate: mrCoord, distance: distance, heading: 0, pitch: 0))
|
|
|
|
|
}
|
2026-04-16 12:10:00 -07:00
|
|
|
if scene == nil, let mrCoord = mostRecent?.nodeCoordinate {
|
2025-07-22 03:23:43 +00:00
|
|
|
Task {
|
|
|
|
|
scene = try? await fetchScene(for: mrCoord)
|
|
|
|
|
}
|
2023-09-12 00:02:31 -07:00
|
|
|
}
|
|
|
|
|
}
|
2023-10-03 16:37:07 -07:00
|
|
|
/// Get the look around scene
|
2023-09-14 17:06:38 -07:00
|
|
|
private func fetchScene(for coordinate: CLLocationCoordinate2D) async throws -> MKLookAroundScene? {
|
2023-09-24 18:44:04 -07:00
|
|
|
let lookAroundScene = MKLookAroundSceneRequest(coordinate: coordinate)
|
|
|
|
|
return try await lookAroundScene.scene
|
2023-09-14 17:06:38 -07:00
|
|
|
}
|
2023-09-12 00:02:31 -07:00
|
|
|
}
|