meshtastic/Meshtastic-Android
1
0
Fork 0
mirror of https://github.com/meshtastic/Meshtastic-Android.git synced 2026-04-20 22:23:37 +00:00
Code Issues Projects Releases Packages Wiki Activity
Meshtastic-Android/feature/node
History
James Rich 5aabf58576 refactor: consolidate metric formatting through MetricFormatter 
Replace 11 inline formatString("%.Nf ...") metric display calls with
MetricFormatter helpers in core/common. Adds two new helpers (windSpeed,
rainfall) for m/s and mm readings.

Migrated (11 sites):
- feature/node EnvironmentMetrics.kt: humidity, pressure, voltage,
  current, wind_speed, wind_gust, wind_lull, rainfall_1h, rainfall_24h
- feature/settings LoadingOverlay.kt, PacketResponseStateDialog.kt:
  progress percent indicators

New helpers in MetricFormatter:
- windSpeed(metersPerSecond, decimalPlaces = 1) -> "X.X m/s"
- rainfall(millimeters, decimalPlaces = 1) -> "X.X mm"

Intentionally left alone:
- core/model DistanceExtensions.kt: specialized unit-conversion helpers,
  which are themselves the canonical distance/speed formatters
- feature/node PositionLogComponents.kt, MetricsViewModel.kt: GPS
  coordinates and heading-angle formatters (not metric display strings)
- feature/node TracerouteChart, HostMetricsChart, EnvironmentCharts,
  PaxMetrics valueFormatter lambdas: chart-library axis callbacks with
  format strings scoped to the chart lib contract
- feature/node TracerouteLog.kt, HostMetricsLog.kt: generic
  "label: value" log rows, not metric displays
- feature/node CompassBottomSheet.kt: one-off %.0f° angle
- EnvironmentMetrics.kt lux, UV-lux, gas resistance, radiation, and
  wind-with-direction formats: one-off specialized units not worth a
  dedicated helper

Also adds detekt @Suppress("TooManyFunctions") on MetricFormatter
(11 helpers now exceeds the default threshold) and unit tests for the
new windSpeed/rainfall helpers.

Validation: ./gradlew spotlessApply, :core:common:jvmTest,
:core:common:detekt, spotlessCheck, and kmpSmokeCompile all pass.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-17 11:04:13 -05:00
..
src refactor: consolidate metric formatting through MetricFormatter 2026-04-17 11:04:13 -05:00
build.gradle.kts test: migrate Compose UI tests from androidTest to commonTest (#5091) 2026-04-12 20:20:00 +00:00
detekt-baseline.xml feat: Complete ViewModel extraction and update documentation (#4817) 2026-03-16 20:05:50 +00:00
README.md refactor: BLE transport and UI for Kotlin Multiplatform unification (#4911) 2026-03-25 02:15:51 +00:00

README.md

:feature:node

Overview

The :feature:node module handles node-centric features, including the node list, detailed node information, telemetry charts, and the compass.

Key Components

1. NodeListScreen

Displays all nodes currently known to the application.

2. NodeDetailScreen

Shows exhaustive details for a specific node, including hardware info, position history, and last heard status.

3. MetricsViewModel

Manages the retrieval and display of telemetry data (e.g., battery, SNR, environment metrics) using charts.

4. CompassViewModel

Provides a compass interface to show the relative direction and distance to other nodes.

Module dependency graph

graph TB
  :feature:node[node]:::kmp-feature

classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-application-compose fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef compose-desktop-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef android-library fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-library-compose fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-test fill:#A0C4FF,stroke:#000,stroke-width:2px,color:#000;
classDef jvm-library fill:#BDB2FF,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library-compose fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef unknown fill:#FFADAD,stroke:#000,stroke-width:2px,color:#000;