mirror of
https://github.com/meshtastic/Meshtastic-Android.git
synced 2026-04-20 22:23:37 +00:00
Bumps `org.meshtastic:mqtt-client` to 0.2.0 and absorbs the breaking shape change of the library's `ConnectionState` (enum → sealed class with disconnect/reconnect context). Surfaces the new context to users and wires up the new probe API. What changed - `MqttConnectionState` (core/model): enum → sealed class with `Inactive`, `Connecting`, `Connected`, `Reconnecting(attempt, lastError)`, `Disconnected(reason)` (+ `Idle` companion). Stays decoupled from the MQTT library — carries `String?` reasons rather than `MqttException`. - `MqttProbeStatus` (core/model): new sealed type mirroring the library's `ProbeResult` shape so feature modules don't need a direct mqtt-client dep. - `MqttManager.probe(...)`: new suspend method. `MqttManagerImpl` calls `MqttClient.probe()` and translates `ProbeResult` → `MqttProbeStatus`. - `MqttManagerImpl.toAppState()`: rewritten as a sealed-class `when` that propagates disconnect reason / reconnect attempt + last error through to UI. - `MQTTRepositoryImpl`: extracts `resolveEndpoint(rawAddress, tlsEnabled)` as a top-level `internal` function so it's directly testable; replaces the (removed) `ConnectionState.DISCONNECTED` initial value with `Disconnected.Idle`. - `MQTTConfigItemList`: new "Test Connection" button beneath the address row that fires `viewModel.probeMqttConnection(...)` and renders the structured `MqttProbeStatus` outcome inline (Probing / Success(+server info) / Rejected / DnsFailure / TcpFailure / TlsFailure / Timeout / Other). `MqttStatusRow` now surfaces the disconnect reason and reconnect attempt context when present. - `RadioConfigViewModel`: adds `mqttProbeStatus` flow, `probeMqttConnection()`, `clearMqttProbeStatus()`. Editing the address clears the last probe result. - `MQTTRepositoryImplTest`: replaces the trivial inlined-parsing tests with real coverage of every `resolveEndpoint` branch (bare host ws/wss, explicit port, ws://, wss://, mqtt://, mqtts://). Notes - This branch will not compile until 0.2.0 lands on Maven Central (deliberate; per the chosen "branch_now_wait" strategy). - Strings added to core/resources for the new probe/status messages. - `MqttConnectionState.INACTIVE` callsite in `RadioConfigViewModelTest` updated to the new sealed-class form. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| src | ||
| build.gradle.kts | ||
| detekt-baseline.xml | ||
| README.md | ||
:core:network
Overview
The :core:network module handles all internet-based communication, including fetching firmware metadata, device hardware definitions, and map tiles (in the fdroid flavor). It also provides the shared radio transport layer (TCPInterface, SerialTransport, BleRadioInterface).
Key Components
1. Ktor Client
The module uses Ktor as its primary HTTP client for high-performance, asynchronous networking.
2. Remote Data Sources
FirmwareReleaseRemoteDataSource: Fetches the latest firmware versions from GitHub or Meshtastic's metadata servers.DeviceHardwareRemoteDataSource: Fetches definitions for supported Meshtastic hardware devices.
3. Shared Transports
BleRadioInterface: Multiplatform BLE transport powered by Kable.TCPInterface: Multiplatform TCP transport.SerialTransport: JVM-shared USB/Serial transport powered by jSerialComm.BaseRadioTransportFactory: Common factory for instantiating the KMP transports.
Module dependency graph
graph TB
:core:network[network]:::kmp-library
classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-application-compose fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef compose-desktop-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef android-library fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-library-compose fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-test fill:#A0C4FF,stroke:#000,stroke-width:2px,color:#000;
classDef jvm-library fill:#BDB2FF,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library-compose fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef unknown fill:#FFADAD,stroke:#000,stroke-width:2px,color:#000;