mirror of
https://github.com/meshtastic/Meshtastic-Android.git
synced 2026-04-20 22:23:37 +00:00
Two Compose correctness/accessibility fixes from the UI audit:
* feature/messaging Reaction.kt: three items() blocks in LazyRow/
LazyColumn had no key= parameter, which caused incorrect state and
animation when the underlying lists reorder. Add stable keys: Map.Entry
iterations use it.key; the reaction list uses a composite
packetId:userId:emoji:timestamp because packetId defaults to 0 for
pending/local reactions.
* Accessibility pass across core/ui and feature/{settings,node,
wifi-provision}: add role=Role.Button + onClickLabel to clickable
Box/Column/Row/Text widgets that were rendering as plain containers
to TalkBack (RegularPreference, IndoorAirQuality, NodeFilterTextField,
ClickableTextField trailing icon). Add contentDescription (via
stringResource) to meaningful Close/Filter/PhoneAndroid icons that
previously passed null. Replace hardcoded English strings in
contentDescription slots with six new keys in core/resources
(export_tak_data_package, mpwrd_os translatable=false, clear_time_zone,
filter_icon, remove_filter, show_iaq_legend).
Roughly 200 insertions across 10 files; no behavior change other than
screen-reader output and stable list-item identity.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
||
|---|---|---|
| .. | ||
| src | ||
| build.gradle.kts | ||
| detekt-baseline.xml | ||
| README.md | ||
:feature:node
Overview
The :feature:node module handles node-centric features, including the node list, detailed node information, telemetry charts, and the compass.
Key Components
1. NodeListScreen
Displays all nodes currently known to the application.
2. NodeDetailScreen
Shows exhaustive details for a specific node, including hardware info, position history, and last heard status.
3. MetricsViewModel
Manages the retrieval and display of telemetry data (e.g., battery, SNR, environment metrics) using charts.
4. CompassViewModel
Provides a compass interface to show the relative direction and distance to other nodes.
Module dependency graph
graph TB
:feature:node[node]:::kmp-feature
classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-application-compose fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef compose-desktop-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef android-library fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-library-compose fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-test fill:#A0C4FF,stroke:#000,stroke-width:2px,color:#000;
classDef jvm-library fill:#BDB2FF,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library-compose fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef unknown fill:#FFADAD,stroke:#000,stroke-width:2px,color:#000;