mirror of
https://github.com/meshtastic/Meshtastic-Android.git
synced 2026-04-20 22:23:37 +00:00
Replaces two coroutine anti-patterns flagged by the architecture audit: * FirmwareUpdateViewModel.onCleared() was using GlobalScope.launch to run cleanup work that must outlive the ViewModel scope. Introduce a new ApplicationCoroutineScope marker interface + Koin @Single binding in core/common, backed by SupervisorJob() + ioDispatcher, and inject it into the VM. NonCancellable is preserved so shutdown work still cannot be interrupted. Verified end-to-end by the KoinVerificationTest full-graph check. * Six sites in feature/settings (android+jvm LogExporter/PrefExporter) and core/ui (android+jvm PlatformUtils) were hardcoding Dispatchers.IO. Switch to the project's injectable ioDispatcher property so tests can substitute a test dispatcher without reflection. Dispatchers.Main sites in LogExporter are intentionally left alone — they are fully test-swappable via Dispatchers.setMain() and there is no existing mainDispatcher property to inject. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| src | ||
| build.gradle.kts | ||
| detekt-baseline.xml | ||
| README.md | ||
:feature:settings
Overview
The :feature:settings module manages all application and radio-side configurations. This includes user preferences, channel configuration, and advanced radio settings.
Key Components
1. SettingsScreen
The main entry point for application-wide settings.
2. RadioConfigViewModel
Handles the complex logic of reading and writing configuration to the Meshtastic device over the radio link (BLE, USB, or TCP).
3. AboutScreen
Displays version information, licenses, and project links.
Features
- Channel Configuration: Manage encryption keys, channel names, and radio frequency settings.
- Node Database Management: Options to clear or prune the local and remote node databases.
- App Preferences: Theme selection, unit system (metric/imperial), and notification settings.
Module dependency graph
graph TB
:feature:settings[settings]:::kmp-feature
classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-application-compose fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef compose-desktop-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef android-library fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-library-compose fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-test fill:#A0C4FF,stroke:#000,stroke-width:2px,color:#000;
classDef jvm-library fill:#BDB2FF,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library-compose fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef unknown fill:#FFADAD,stroke:#000,stroke-width:2px,color:#000;