meshtastic/Meshtastic-Android
1
0
Fork 0
mirror of https://github.com/meshtastic/Meshtastic-Android.git synced 2026-04-20 22:23:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

Refactor: Remove "include unmessageable" filter (#1889)

Browse source
This commit is contained in:
James Rich 2025-05-20 22:08:40 -05:00 • committed by GitHub
parent 990cd103d7
commit f6e75e970b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 3 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/com/geeksville/mesh/ui/NodeScreen.kt
View file

@ -95,8 +95,6 @@ fun NodeScreen(
onToggleIncludeUnknown = model::toggleIncludeUnknown,
showDetails = state.showDetails,
onToggleShowDetails = model::toggleShowDetails,
includeUnmessageable = state.includeUnmessageable,
onToggleIncludeUnmessageable = model::toggleIncludeUnmessageable
)
}

29
app/src/main/java/com/geeksville/mesh/ui/components/NodeFilterTextField.kt
View file

@ -70,8 +70,6 @@ fun NodeFilterTextField(
onToggleIncludeUnknown: () -> Unit,
showDetails: Boolean,
onToggleShowDetails: () -> Unit,
includeUnmessageable: Boolean,
onToggleIncludeUnmessageable: () -> Unit,
) {
Row(
modifier = modifier.background(MaterialTheme.colorScheme.background),
@ -90,8 +88,6 @@ fun NodeFilterTextField(
onToggleIncludeUnknown = onToggleIncludeUnknown,
showDetails = showDetails,
onToggleShowDetails = onToggleShowDetails,
includeUnmessageable = includeUnmessageable,
onToggleIncludeUnmessageable = onToggleIncludeUnmessageable
)
}
}
@ -158,8 +154,6 @@ private fun NodeSortButton(
onToggleIncludeUnknown: () -> Unit,
showDetails: Boolean,
onToggleShowDetails: () -> Unit,
onToggleIncludeUnmessageable: () -> Unit,
includeUnmessageable: Boolean,
modifier: Modifier = Modifier,
) = Box(modifier) {
var expanded by remember { mutableStateOf(false) }
@ -234,27 +228,6 @@ private fun NodeSortButton(
}
}
)
HorizontalDivider()
DropdownMenuItem(
onClick = {
onToggleIncludeUnmessageable()
expanded = false
},
text = {
Row {
AnimatedVisibility(visible = includeUnmessageable) {
Icon(
imageVector = Icons.Default.Done,
contentDescription = null,
modifier = Modifier.padding(end = 4.dp),
)
}
Text(
text = stringResource(id = R.string.node_filter_include_unmessageable),
)
}
}
)
}
}
@ -272,8 +245,6 @@ private fun NodeFilterTextFieldPreview() {
onToggleIncludeUnknown = {},
showDetails = false,
onToggleShowDetails = {},
includeUnmessageable = false,
onToggleIncludeUnmessageable = {}
)
}
}