From efbc61eaf2d928798206e552390fe26c58d766b4 Mon Sep 17 00:00:00 2001
From: Kevin Hester <kevinh@geeksville.com>
Date: Sun, 21 Feb 2021 12:27:13 +0800
Subject: [PATCH] fix mroe lint warnings

---
 app/src/main/res/drawable/face.xml            | 20 -------------------
 app/src/main/res/layout/advanced_settings.xml |  2 +-
 app/src/main/res/layout/fragment_main.xml     |  7 -------
 app/src/main/res/layout/map_view.xml          |  2 +-
 app/src/main/res/menu/menu_main.xml           |  4 ++--
 app/src/main/res/values/colors.xml            |  1 -
 app/src/main/res/values/dimens.xml            |  1 -
 app/src/main/res/values/strings.xml           |  2 ++
 8 files changed, 6 insertions(+), 33 deletions(-)
 delete mode 100644 app/src/main/res/drawable/face.xml
 delete mode 100644 app/src/main/res/layout/fragment_main.xml

diff --git a/app/src/main/res/drawable/face.xml b/app/src/main/res/drawable/face.xml
deleted file mode 100644
index 94608039c..000000000
--- a/app/src/main/res/drawable/face.xml
+++ /dev/null
@@ -1,20 +0,0 @@
-<vector xmlns:android="http://schemas.android.com/apk/res/android"
-        android:width="24dp"
-        android:height="24dp"
-        android:viewportWidth="24.0"
-        android:viewportHeight="24.0"
-        android:tint="?attr/colorControlNormal">
-    <path
-        android:fillColor="@android:color/white"
-        android:pathData="M17.5,8c0.46,0 0.91,-0.05 1.34,-0.12C17.44,5.56 14.9,4 12,4c-0.46,0 -0.91,0.05 -1.34,0.12C12.06,6.44 14.6,8 17.5,8zM8.08,5.03C6.37,6 5.05,7.58 4.42,9.47c1.71,-0.97 3.03,-2.55 3.66,-4.44z"
-        android:fillAlpha=".3"/>
-    <path
-        android:fillColor="@android:color/white"
-        android:pathData="M12,2C6.48,2 2,6.48 2,12s4.48,10 10,10 10,-4.48 10,-10S17.52,2 12,2zM12,4c2.9,0 5.44,1.56 6.84,3.88 -0.43,0.07 -0.88,0.12 -1.34,0.12 -2.9,0 -5.44,-1.56 -6.84,-3.88 0.43,-0.07 0.88,-0.12 1.34,-0.12zM8.08,5.03C7.45,6.92 6.13,8.5 4.42,9.47 5.05,7.58 6.37,6 8.08,5.03zM12,20c-4.41,0 -8,-3.59 -8,-8 0,-0.05 0.01,-0.1 0.01,-0.15 2.6,-0.98 4.68,-2.99 5.74,-5.55 1.83,2.26 4.62,3.7 7.75,3.7 0.75,0 1.47,-0.09 2.17,-0.24 0.21,0.71 0.33,1.46 0.33,2.24 0,4.41 -3.59,8 -8,8z"/>
-    <path
-        android:fillColor="@android:color/white"
-        android:pathData="M9,13m-1.25,0a1.25,1.25 0,1 1,2.5 0a1.25,1.25 0,1 1,-2.5 0"/>
-    <path
-        android:fillColor="@android:color/white"
-        android:pathData="M15,13m-1.25,0a1.25,1.25 0,1 1,2.5 0a1.25,1.25 0,1 1,-2.5 0"/>
-</vector>
diff --git a/app/src/main/res/layout/advanced_settings.xml b/app/src/main/res/layout/advanced_settings.xml
index 755b3e585..a0c6c8dfd 100644
--- a/app/src/main/res/layout/advanced_settings.xml
+++ b/app/src/main/res/layout/advanced_settings.xml
@@ -4,7 +4,7 @@
     xmlns:app="http://schemas.android.com/apk/res-auto"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
-    android:background="#FFFFFF">
+    >
 
     <com.google.android.material.textfield.TextInputLayout
         android:id="@+id/positionBroadcastPeriodView"
diff --git a/app/src/main/res/layout/fragment_main.xml b/app/src/main/res/layout/fragment_main.xml
deleted file mode 100644
index 696be4e41..000000000
--- a/app/src/main/res/layout/fragment_main.xml
+++ /dev/null
@@ -1,7 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    android:id="@+id/constraintLayout"
-    android:layout_width="match_parent"
-    android:layout_height="match_parent">
-
-</FrameLayout>
\ No newline at end of file
diff --git a/app/src/main/res/layout/map_view.xml b/app/src/main/res/layout/map_view.xml
index a9d5df8cc..608b01154 100644
--- a/app/src/main/res/layout/map_view.xml
+++ b/app/src/main/res/layout/map_view.xml
@@ -10,7 +10,7 @@
         android:id="@+id/mapView"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
-        android:clickable="true"
+        android:clickable="true" android:focusable="true"
         mapbox:mapbox_uiZoomGestures="true"
         mapbox:mapbox_uiScrollGestures="true"></com.mapbox.mapboxsdk.maps.MapView>
 
diff --git a/app/src/main/res/menu/menu_main.xml b/app/src/main/res/menu/menu_main.xml
index fa17012a7..db3e1a6da 100644
--- a/app/src/main/res/menu/menu_main.xml
+++ b/app/src/main/res/menu/menu_main.xml
@@ -15,11 +15,11 @@
         android:id="@+id/stress_test"
         android:checkable="true"
         android:checked="false"
-        android:title="Protocol stress test" />
+        android:title="@string/protocol_stress_test" />
     <item
         android:id="@+id/advanced_settings"
         app:showAsAction="withText"
-        android:title="Advanced settings" />
+        android:title="@string/advanced_settings" />
     <item
         android:id="@+id/about"
         android:title="@string/about"
diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml
index 9cb16e82e..545dd613b 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -2,7 +2,6 @@
 <resources>
     <color name="colorPrimary">#3700B3</color>
     <color name="colorPrimaryDark">#3700B3</color>
-    <color name="colorAccent">#D81B60</color>
     <color name="colorMsg">#F2F2F2</color>
     <color name="colorMyMsg">#EDEAF4</color>
 </resources>
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index 0aefc338b..a8fdb8c56 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -1,4 +1,3 @@
 <resources>
-    <dimen name="fab_margin">16dp</dimen>
     <dimen name="message_offset">64dp</dimen>
 </resources>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 02328944d..bb3447e1e 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -86,4 +86,6 @@
     <string name="ls_sleep_secs">Device sleep period (in seconds)</string>
     <string name="meshtastic_messages_notifications">Notifications about messages</string>
     <string name="broadcast_period_too_small">Minimum broadcast period for this channel is %d</string>
+    <string name="protocol_stress_test">Protocol stress test</string>
+    <string name="advanced_settings">Advanced settings</string>
 </resources>