meshtastic/Meshtastic-Android
1
0
Fork 0
mirror of https://github.com/meshtastic/Meshtastic-Android.git synced 2026-04-20 22:23:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

refactor(analytics): reduce tracking footprint (#4649)

Browse source 
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This commit is contained in:
James Rich 2026-02-25 20:44:13 -06:00 • committed by GitHub
parent ceeb28945d
commit 85c6ed61bb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 109 additions and 163 deletions
Download patch file Download diff file Expand all files Collapse all files

15
app/src/main/AndroidManifest.xml
View file

@ -135,6 +135,21 @@
android:name="google_analytics_default_allow_ad_personalization_signals"
android:value="false" />
<!-- Disable SSAID collection to reduce PII footprint -->
<meta-data
android:name="google_analytics_ssaid_collection_enabled"
android:value="false" />
<!-- Disable automatic screen reporting to reduce background noise -->
<meta-data
android:name="google_analytics_automatic_screen_reporting_enabled"
android:value="false" />
<!-- Set default analytics storage consent to denied for Advanced Consent Mode -->
<meta-data
android:name="google_analytics_default_allow_analytics_storage"
android:value="false" />
<!-- This is the public API for doing mesh radio operations from android apps -->
<service
android:name="com.geeksville.mesh.service.MeshService"

119
app/src/test/java/com/geeksville/mesh/widget/LocalStatsWidgetStateProviderTest.kt
View file

@ -1,119 +0,0 @@
/*
* Copyright (c) 2026 Meshtastic LLC
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
package com.geeksville.mesh.widget
import androidx.test.ext.junit.runners.AndroidJUnit4
import io.mockk.coEvery
import io.mockk.every
import io.mockk.mockk
import io.mockk.mockkStatic
import io.mockk.unmockkAll
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.first
import kotlinx.coroutines.test.runTest
import org.junit.After
import org.junit.Assert.assertEquals
import org.junit.Assert.assertFalse
import org.junit.Assert.assertTrue
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.meshtastic.core.data.repository.NodeRepository
import org.meshtastic.core.database.model.Node
import org.meshtastic.core.model.util.onlineTimeThreshold
import org.meshtastic.core.resources.getStringSuspend
import org.meshtastic.core.service.ConnectionState
import org.meshtastic.core.service.ServiceRepository
import org.meshtastic.proto.DeviceMetrics
import org.meshtastic.proto.LocalStats
import org.meshtastic.proto.User
import org.robolectric.annotation.Config
@RunWith(AndroidJUnit4::class)
@Config(sdk = [34])
@OptIn(ExperimentalCoroutinesApi::class)
class LocalStatsWidgetStateProviderTest {
private val connectionStateFlow = MutableStateFlow<ConnectionState>(ConnectionState.Disconnected)
private val nodeDbFlow = MutableStateFlow<Map<Int, Node>>(emptyMap())
private val localStatsFlow = MutableStateFlow(LocalStats())
private val ourNodeInfoFlow = MutableStateFlow<Node?>(null)
private val serviceRepository = mockk<ServiceRepository>(relaxed = true)
private val nodeRepository = mockk<NodeRepository>(relaxed = true)
@Before
fun setUp() {
mockkStatic("org.meshtastic.core.resources.ContextExtKt")
mockkStatic("org.meshtastic.core.model.util.TimeUtilsKt")
coEvery { getStringSuspend(any()) } returns "Mock String"
coEvery { getStringSuspend(any(), *anyVararg()) } returns "Mock Formatted String"
every { onlineTimeThreshold() } returns 0
// Explicitly return flows from mocks
every { serviceRepository.connectionState } returns connectionStateFlow
every { nodeRepository.nodeDBbyNum } returns nodeDbFlow
every { nodeRepository.localStats } returns localStatsFlow
every { nodeRepository.ourNodeInfo } returns ourNodeInfoFlow
}
@After
fun tearDown() {
unmockkAll()
}
@Test
fun `initial state reflects disconnected status`() = runTest {
val provider = LocalStatsWidgetStateProvider(nodeRepository, serviceRepository)
val state = provider.state.first()
assertEquals(ConnectionState.Disconnected, state.connectionState)
assertFalse(state.showContent)
}
@Test
fun `connected state shows content and maps node info`() = runTest {
connectionStateFlow.value = ConnectionState.Connected
ourNodeInfoFlow.value =
Node(
num = 123,
user = User(short_name = "ABC"),
deviceMetrics = DeviceMetrics(battery_level = 85, channel_utilization = 12.5f),
)
val provider = LocalStatsWidgetStateProvider(nodeRepository, serviceRepository)
val state =
provider.state.first { (it.connectionState == ConnectionState.Connected) && (it.nodeShortName == "ABC") }
assertTrue(state.showContent)
assertEquals("ABC", state.nodeShortName)
assertEquals("85%", state.batteryValue)
}
@Test
fun `node count and update timestamp are populated`() = runTest {
connectionStateFlow.value = ConnectionState.Connected
nodeDbFlow.value = mapOf(1 to Node(num = 1, lastHeard = 1000))
val provider = LocalStatsWidgetStateProvider(nodeRepository, serviceRepository)
val state = provider.state.first { it.nodeCountText == "1/1" }
assertEquals("1/1", state.nodeCountText)
assertEquals("Mock Formatted String", state.updatedText)
}
}