fix(map): address code review findings — precision, naming, icons, i18n

- Fix Int.toFloat() precision loss in track point filter by storing
  time as string in GeoJSON and using string-based equality comparison
- Rename MapStyle enum values to match actual tile styles: Satellite→Light
  (Positron), Hybrid→RoadMap (Americana), with updated string resources
- Reset bearingUpdate to IGNORE when gesture cancels location tracking
- Use LocationOn icon for ALWAYS_NORTH tracking mode instead of
  misleading LocationDisabled
- Remove dead isOfflineManagerAvailable() expect/actual declarations
- Replace hardcoded English strings in offline map UI with
  stringResource() calls backed by core:resources entries
This commit is contained in:
James Rich 2026-04-13 12:14:17 -05:00
parent 01d2642275
commit 5cae109ec9
10 changed files with 64 additions and 44 deletions

View file

@ -1160,10 +1160,16 @@
<string name="bluetooth_feature_config_description">Wirelessly manage your device settings and channels.</string>
<string name="map_style_selection">Map style selection</string>
<string name="map_style_osm">OpenStreetMap</string>
<string name="map_style_satellite">Satellite</string>
<string name="map_style_light">Light</string>
<string name="map_style_terrain">Terrain</string>
<string name="map_style_hybrid">Hybrid</string>
<string name="map_style_road_map">Road Map</string>
<string name="map_style_dark">Dark</string>
<string name="offline_maps">Offline Maps</string>
<string name="offline_download">Download</string>
<string name="offline_download_visible_region">Download visible region</string>
<string name="offline_saves_tiles">Saves tiles for offline use</string>
<string name="offline_downloaded_regions">Downloaded Regions</string>
<string name="offline_unnamed_region">Unnamed Region</string>
<string name="local_stats_battery">Battery: %1$d%</string>
<string name="local_stats_nodes">Nodes: %1$d online / %2$d total</string>