meshtastic/Meshtastic-Android
1
0
Fork 0
mirror of https://github.com/meshtastic/Meshtastic-Android.git synced 2026-04-20 22:23:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(auto): fix ConnectionState data object usage and add list item limits

Browse source 
Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Android/sessions/d1af27de-bc74-4b77-bdb8-7ae8167ab336

Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-04-17 03:34:43 +00:00 • committed by GitHub
parent 6d7ddebbef
commit 41b99fd079
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

17
app/src/main/kotlin/org/meshtastic/app/auto/MeshtasticCarScreen.kt
View file

@ -67,7 +67,7 @@ class MeshtasticCarScreen(carContext: CarContext) :
private val scope = CoroutineScope(Dispatchers.Main + SupervisorJob())
private var observeJob: Job? = null
private var connectionState: ConnectionState = ConnectionState.Disconnected()
private var connectionState: ConnectionState = ConnectionState.Disconnected
private var favoriteNodes: List<Node> = emptyList()
private var channels: List<ChannelSettings> = emptyList()
private var unreadCounts: Map<String, Int> = emptyMap()
@ -195,10 +195,10 @@ class MeshtasticCarScreen(carContext: CarContext) :
private fun buildFavoritesSection(): ItemList {
val builder = ItemList.Builder()
for (node in favoriteNodes) {
for (node in favoriteNodes.take(MAX_LIST_ITEMS)) {
val contactKey = "0${node.user.id}"
val unread = unreadCounts[contactKey] ?: 0
val name = node.user.long_name.ifEmpty { node.user.short_name }
val name = node.user.long_name.ifEmpty { node.user.short_name }.ifEmpty { "Unknown" }
val subtitle = buildString {
append(node.user.short_name)
if (node.hopsAway >= 0) append(" · ${node.hopsAway} hops")
@ -220,7 +220,7 @@ class MeshtasticCarScreen(carContext: CarContext) :
private fun buildChannelsSection(): ItemList {
val builder = ItemList.Builder()
for ((index, channelSettings) in channels.withIndex()) {
for ((index, channelSettings) in channels.take(MAX_LIST_ITEMS).withIndex()) {
val contactKey = "${index}${DataPacket.ID_BROADCAST}"
val unread = unreadCounts[contactKey] ?: 0
val channelName = channelSettings.name.ifEmpty { "Primary Channel" }
@ -237,4 +237,13 @@ class MeshtasticCarScreen(carContext: CarContext) :
return builder.build()
}
companion object {
/**
* Android Auto enforces a maximum item count per [ListTemplate] section.
* Car API level 1 supports up to 6 items per section.
*/
private const val MAX_LIST_ITEMS = 6
}
}