refactor: recommended and required firmware updates (#2012)

app/src/main/java/com/geeksville/mesh/database/entity/FirmwareReleaseEntity.kt

@@ -80,6 +80,12 @@ fun FirmwareReleaseEntity.asDeviceVersion(): DeviceVersion {
     )
 }
 
+fun FirmwareRelease.asDeviceVersion(): DeviceVersion {
+    return DeviceVersion(
+        id.substringBeforeLast(".").replace("v", "")
+    )
+}
+
 enum class FirmwareReleaseType {
     STABLE,
     ALPHA

app/src/main/java/com/geeksville/mesh/model/UIState.kt

@@ -55,6 +55,8 @@ import com.geeksville.mesh.database.QuickChatActionRepository
 import com.geeksville.mesh.database.entity.MyNodeEntity
 import com.geeksville.mesh.database.entity.Packet
 import com.geeksville.mesh.database.entity.QuickChatAction
+import com.geeksville.mesh.database.entity.asDeviceVersion
+import com.geeksville.mesh.repository.api.FirmwareReleaseRepository
 import com.geeksville.mesh.repository.datastore.RadioConfigRepository
 import com.geeksville.mesh.repository.location.LocationRepository
 import com.geeksville.mesh.repository.radio.RadioInterfaceService
@@ -77,6 +79,7 @@ import kotlinx.coroutines.flow.flatMapLatest
 import kotlinx.coroutines.flow.launchIn
 import kotlinx.coroutines.flow.map
 import kotlinx.coroutines.flow.mapLatest
+import kotlinx.coroutines.flow.mapNotNull
 import kotlinx.coroutines.flow.onEach
 import kotlinx.coroutines.flow.stateIn
 import kotlinx.coroutines.launch
@@ -183,6 +186,7 @@ class UIViewModel @Inject constructor(
     private val packetRepository: PacketRepository,
     private val quickChatActionRepository: QuickChatActionRepository,
     private val locationRepository: LocationRepository,
+    firmwareReleaseRepository: FirmwareReleaseRepository,
     private val preferences: SharedPreferences
 ) : ViewModel(), Logging {
 
@@ -560,6 +564,8 @@ class UIViewModel @Inject constructor(
         showSnackbar(R.string.channel_invalid)
     }
 
+    val latestStableFirmwareRelease = firmwareReleaseRepository.stableRelease.mapNotNull { it?.asDeviceVersion() }
+
     /**
      * Called immediately after activity observes requestChannelUrl
      */

app/src/main/java/com/geeksville/mesh/service/MeshService.kt

@@ -193,7 +193,8 @@ class MeshService : Service(), Logging {
         /** The minimum firmware version we know how to talk to. We'll still be able
          * to talk to 2.0 firmwares but only well enough to ask them to firmware update.
          */
-        val minDeviceVersion = DeviceVersion(BuildConfig.MIN_DEVICE_VERSION)
+        val minDeviceVersion = DeviceVersion(BuildConfig.MIN_FW_VERSION)
+        val absoluteMinDeviceVersion = DeviceVersion(BuildConfig.ABS_MIN_FW_VERSION)
     }
 
     enum class ConnectionState {

app/src/main/java/com/geeksville/mesh/ui/Main.kt

@@ -49,6 +49,7 @@ import androidx.compose.material3.TopAppBar
 import androidx.compose.material3.rememberTooltipState
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.collectAsState
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.livedata.observeAsState
 import androidx.compose.runtime.mutableStateOf
@@ -195,6 +196,8 @@ private fun VersionChecks(
     val connectionState by viewModel.connectionState.collectAsStateWithLifecycle()
     val myNodeInfo by viewModel.myNodeInfo.collectAsStateWithLifecycle()
     val context = LocalContext.current
+    val latestStableFirmwareRelease by
+    viewModel.latestStableFirmwareRelease.collectAsState(DeviceVersion("2.6.4"))
     // Check if the device is running an old app version or firmware version
     LaunchedEffect(connectionState, myNodeInfo) {
         if (connectionState == MeshService.ConnectionState.CONNECTED) {
@@ -211,18 +214,31 @@ private fun VersionChecks(
                             MeshService.changeDeviceAddress(context, service, "n")
                         }
                     )
-                } else if (curVer < MeshService.minDeviceVersion) {
+                } else if (curVer < MeshService.absoluteMinDeviceVersion) {
                     val title = context.getString(R.string.firmware_too_old)
                     val message = context.getString(R.string.firmware_old)
                     viewModel.showAlert(
                         title = title,
-                        message = message,
+                        html = message,
                         dismissable = false,
                         onConfirm = {
                             val service = viewModel.meshService ?: return@showAlert
                             MeshService.changeDeviceAddress(context, service, "n")
                         }
                     )
+                } else if (curVer < MeshService.minDeviceVersion) {
+                    val title = context.getString(R.string.should_update_firmware)
+                    val message =
+                        context.getString(
+                            R.string.should_update,
+                            latestStableFirmwareRelease.asString
+                        )
+                    viewModel.showAlert(
+                        title = title,
+                        message = message,
+                        dismissable = false,
+                        onConfirm = {}
+                    )
                 }
             }
         }

app/src/main/java/com/geeksville/mesh/ui/common/components/AlertDialogs.kt

@@ -55,7 +55,7 @@ fun SimpleAlertDialog(
                 style = SpanStyle(
                     textDecoration = TextDecoration.Underline,
                     fontStyle = FontStyle.Italic,
-                    color = MaterialTheme.colorScheme.tertiary
+                    color = MaterialTheme.colorScheme.primary
                 )
             )
         )