fix(ui): stable LazyColumn keys, semantic roles, and content descriptions

Two Compose correctness/accessibility fixes from the UI audit:

* feature/messaging Reaction.kt: three items() blocks in LazyRow/
  LazyColumn had no key= parameter, which caused incorrect state and
  animation when the underlying lists reorder. Add stable keys: Map.Entry
  iterations use it.key; the reaction list uses a composite
  packetId:userId:emoji:timestamp because packetId defaults to 0 for
  pending/local reactions.
* Accessibility pass across core/ui and feature/{settings,node,
  wifi-provision}: add role=Role.Button + onClickLabel to clickable
  Box/Column/Row/Text widgets that were rendering as plain containers
  to TalkBack (RegularPreference, IndoorAirQuality, NodeFilterTextField,
  ClickableTextField trailing icon). Add contentDescription (via
  stringResource) to meaningful Close/Filter/PhoneAndroid icons that
  previously passed null. Replace hardcoded English strings in
  contentDescription slots with six new keys in core/resources
  (export_tak_data_package, mpwrd_os translatable=false, clear_time_zone,
  filter_icon, remove_filter, show_iaq_legend).

Roughly 200 insertions across 10 files; no behavior change other than
screen-reader output and stable list-item identity.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
James Rich 2026-04-17 10:46:48 -05:00
parent df3b5365f9
commit 387acd7a2f
9 changed files with 79 additions and 17 deletions

View file

@ -49,6 +49,7 @@ import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.focus.onFocusEvent
import androidx.compose.ui.platform.LocalFocusManager
import androidx.compose.ui.semantics.Role
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.input.ImeAction
import androidx.compose.ui.text.style.TextAlign
@ -56,6 +57,7 @@ import androidx.compose.ui.unit.dp
import org.jetbrains.compose.resources.stringResource
import org.meshtastic.core.model.NodeSortOption
import org.meshtastic.core.resources.Res
import org.meshtastic.core.resources.clear
import org.meshtastic.core.resources.desc_node_filter_clear
import org.meshtastic.core.resources.node_filter_exclude_infrastructure
import org.meshtastic.core.resources.node_filter_exclude_mqtt
@ -178,14 +180,19 @@ private fun NodeFilterTextField(filterText: String, onTextChange: (String) -> Un
onValueChange = onTextChange,
trailingIcon = {
if (filterText.isNotEmpty() || isFocused) {
val clearLabel = stringResource(Res.string.clear)
Icon(
MeshtasticIcons.Close,
contentDescription = stringResource(Res.string.desc_node_filter_clear),
modifier =
Modifier.clickable {
onTextChange("")
focusManager.clearFocus()
},
Modifier.clickable(
onClickLabel = clearLabel,
role = Role.Button,
onClick = {
onTextChange("")
focusManager.clearFocus()
},
),
)
}
},