ci: release flow tweaks (#4723)

.github/workflows/create-or-promote-release.yml

@@ -106,112 +106,6 @@ jobs:
           fi
         shell: bash
 
-      - name: Update External Assets (Firmware, Hardware, Protos)
-        if: ${{ !inputs.dry_run && inputs.channel == 'internal' }}
-        run: |
-          # Update Submodules (Protobufs)
-          echo "Updating core/proto submodule..."
-          git submodule update --init --remote core/proto
-          
-          # Update Firmware List
-          firmware_file_path="app/src/main/assets/firmware_releases.json"
-          temp_firmware_file="/tmp/new_firmware_releases.json"
-          
-          echo "Fetching latest firmware releases..."
-          curl -s --fail https://api.meshtastic.org/github/firmware/list > "$temp_firmware_file"
-          
-          if ! jq empty "$temp_firmware_file" 2>/dev/null; then
-            echo "::error::Firmware API returned invalid JSON data. Aborting."
-            exit 1
-          else
-            if [ ! -f "$firmware_file_path" ] || ! jq --sort-keys . "$temp_firmware_file" | diff -q - <(jq --sort-keys . "$firmware_file_path"); then
-              echo "Changes detected in firmware list or local file missing. Updating $firmware_file_path."
-              cp "$temp_firmware_file" "$firmware_file_path"
-            else
-              echo "No changes detected in firmware list."
-            fi
-          fi
-
-          # Update Hardware List
-          hardware_file_path="app/src/main/assets/device_hardware.json"
-          temp_hardware_file="/tmp/new_device_hardware.json"
-
-          echo "Fetching latest device hardware data..."
-          curl -s --fail https://api.meshtastic.org/resource/deviceHardware > "$temp_hardware_file"
-
-          if ! jq empty "$temp_hardware_file" 2>/dev/null; then
-            echo "::error::Hardware API returned invalid JSON data. Aborting."
-            exit 1
-          else
-            if [ ! -f "$hardware_file_path" ] || ! jq --sort-keys . "$temp_hardware_file" | diff -q - <(jq --sort-keys . "$hardware_file_path"); then
-              echo "Changes detected in hardware list or local file missing. Updating $hardware_file_path."
-              cp "$temp_hardware_file" "$hardware_file_path"
-            else
-              echo "No changes detected in hardware list."
-            fi
-          fi
-
-      - name: Sync with Crowdin
-        if: ${{ !inputs.dry_run && inputs.channel == 'internal' }}
-        uses: crowdin/github-action@v2
-        with:
-          base_url: 'https://meshtastic.crowdin.com/api/v2'
-          config: 'crowdin.yml'
-          crowdin_branch_name: 'main'
-          upload_sources: true
-          upload_sources_args: '--preserve-hierarchy'
-          upload_translations: false
-          download_translations: true
-          download_translations_args: '--preserve-hierarchy'
-          create_pull_request: false
-          push_translations: false
-          push_sources: false
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          CROWDIN_PROJECT_ID: ${{ secrets.CROWDIN_PROJECT_ID }}
-          CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }}
-
-      - name: Commit Release Assets (Translations, Data, Config)
-        if: ${{ !inputs.dry_run && inputs.channel == 'internal' }}
-        env:
-          FINAL_TAG: ${{ steps.calculate_tags.outputs.final_tag }}
-        run: |
-          # Calculate Version Code
-          OFFSET=$(grep '^VERSION_CODE_OFFSET=' config.properties | cut -d'=' -f2)
-          COMMIT_COUNT=$(git rev-list --count HEAD)
-          # +1 because we are about to add a commit
-          VERSION_CODE=$((COMMIT_COUNT + OFFSET + 1))
-          
-          echo "Calculated Version Code: $VERSION_CODE"
-          
-          # Update VERSION_NAME_BASE in config.properties
-          sed -i "s/^VERSION_NAME_BASE=.*/VERSION_NAME_BASE=${{ inputs.base_version }}/" config.properties
-          
-          git config user.name "github-actions[bot]"
-          git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
-
-          # Add updated data files
-          git add config.properties
-          git add app/src/main/assets/firmware_releases.json || true
-          git add app/src/main/assets/device_hardware.json || true
-          git add core/proto || true
-          
-          # Add updated translations (fastlane metadata and strings)
-          git add fastlane/metadata/android || true
-          git add "**/strings.xml" || true
-          
-          # Only commit if there are changes
-          if ! git diff --cached --quiet; then
-            git commit -m "chore(release): prepare $FINAL_TAG [skip ci]
-
-          - Bump base version to ${{ inputs.base_version }}
-          - Sync translations and assets"
-            git push origin HEAD:${{ github.ref_name }}
-          else
-            echo "No changes to commit."
-          fi
-        shell: bash
-
       - name: Create and Push Release Tag
         if: ${{ !inputs.dry_run && inputs.channel == 'internal' }}
         env:
@@ -244,3 +138,19 @@ jobs:
       base_version: ${{ inputs.base_version }}
       from_channel: ${{ needs.determine-tags.outputs.from_channel }}
     secrets: inherit
+
+  cleanup-on-failure:
+    needs: [determine-tags, call-release-workflow]
+    if: ${{ failure() && !inputs.dry_run && inputs.channel == 'internal' }}
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+        with:
+          fetch-depth: 0
+      - name: Delete Failed Tag
+        env:
+          FINAL_TAG: ${{ needs.determine-tags.outputs.final_tag }}
+        run: |
+          echo "Release workflow failed. Deleting tag $FINAL_TAG to allow a clean retry..."
+          git push origin :refs/tags/"$FINAL_TAG" || echo "Tag was not pushed or already deleted."