meshtastic/Meshtastic-Android
1
0
Fork 0
mirror of https://github.com/meshtastic/Meshtastic-Android.git synced 2026-04-20 22:23:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

feat(logging): Remove redundant Report Bug button and related functionality (#2836)

Browse source 
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This commit is contained in:
James Rich 2025-08-25 14:43:12 -05:00 • committed by GitHub
parent 9fd184d3ac
commit 23d0688fba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 0 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/src/main/java/com/geeksville/mesh/android/Logging.kt
View file

@ -17,7 +17,6 @@
package com.geeksville.mesh.android
import com.geeksville.mesh.util.Exceptions
import timber.log.Timber
interface Logging {
@ -51,9 +50,4 @@ interface Logging {
throw ex
}
}
// / Report an error (including messaging our crash reporter service if allowed
fun reportError(s: String) {
Exceptions.report(Exception("logging reportError: $s"), s)
}
}

45
app/src/main/java/com/geeksville/mesh/ui/connections/Connections.kt
View file

@ -47,8 +47,6 @@ import androidx.compose.material.icons.filled.Wifi
import androidx.compose.material.icons.rounded.Bluetooth
import androidx.compose.material.icons.rounded.Usb
import androidx.compose.material.icons.rounded.Wifi
import androidx.compose.material3.AlertDialog
import androidx.compose.material3.Button
import androidx.compose.material3.Card
import androidx.compose.material3.Checkbox
import androidx.compose.material3.Icon
@ -84,7 +82,6 @@ import androidx.lifecycle.compose.collectAsStateWithLifecycle
import com.geeksville.mesh.ConfigProtos
import com.geeksville.mesh.R
import com.geeksville.mesh.android.BuildUtils.debug
import com.geeksville.mesh.android.BuildUtils.reportError
import com.geeksville.mesh.android.GeeksvilleApplication
import com.geeksville.mesh.android.gpsDisabled
import com.geeksville.mesh.android.isGooglePlayAvailable
@ -194,9 +191,6 @@ fun ConnectionsScreen(
var showScanDialog by remember { mutableStateOf(false) }
val scanResults by scanModel.scanResult.observeAsState(emptyMap())
// State for the Report Bug dialog
var showReportBugDialog by remember { mutableStateOf(false) }
// Observe scan results to show the dialog
if (scanResults.isNotEmpty()) {
showScanDialog = true
@ -465,15 +459,6 @@ fun ConnectionsScreen(
modifier = Modifier.padding(start = 16.dp),
)
}
Spacer(modifier = Modifier.height(16.dp))
// Report Bug Button
Button(
onClick = { showReportBugDialog = true }, // Set state to show Report Bug dialog
modifier = Modifier.fillMaxWidth().padding(horizontal = 16.dp),
enabled = isAnalyticsAllowed,
) {
Text(stringResource(R.string.report_bug))
}
}
}
}
@ -526,36 +511,6 @@ fun ConnectionsScreen(
}
}
}
// Compose Report Bug Dialog
if (showReportBugDialog) {
AlertDialog(
onDismissRequest = { showReportBugDialog = false },
title = { Text(stringResource(R.string.report_a_bug)) },
text = { Text(stringResource(R.string.report_bug_text)) },
confirmButton = {
Button(
onClick = {
showReportBugDialog = false
reportError("Clicked Report A Bug")
uiViewModel.showSnackBar("Bug report sent!")
},
) {
Text(stringResource(R.string.report))
}
},
dismissButton = {
Button(
onClick = {
showReportBugDialog = false
debug("Decided not to report a bug")
},
) {
Text(stringResource(R.string.cancel))
}
},
)
}
}
Box(modifier = Modifier.fillMaxWidth().padding(8.dp)) {