meshtastic/Meshtastic-Android
1
0
Fork 0
mirror of https://github.com/meshtastic/Meshtastic-Android.git synced 2026-04-20 22:23:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix: clean up flaky, duplicated, and misplaced tests; remove redundant deps (#5048)

Browse source
This commit is contained in:
James Rich 2026-04-10 14:46:45 -05:00 • committed by GitHub
parent e70dabe94d
commit 02f6fd67b8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
23 changed files with 11 additions and 676 deletions
Download patch file Download diff file Expand all files Collapse all files

95
feature/node/src/test/kotlin/org/meshtastic/feature/node/metrics/BaseMetricScreenTest.kt
View file

@ -1,95 +0,0 @@
/*
* Copyright (c) 2026 Meshtastic LLC
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
package org.meshtastic.feature.node.metrics
import androidx.compose.material3.Text
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onNodeWithTag
import androidx.compose.ui.test.onNodeWithText
import androidx.compose.ui.test.performClick
import org.junit.Rule
import org.junit.Test
import org.junit.runner.RunWith
import org.meshtastic.core.model.TelemetryType
import org.meshtastic.core.resources.Res
import org.meshtastic.core.resources.device_metrics_log
import org.meshtastic.core.ui.theme.AppTheme
import org.robolectric.RobolectricTestRunner
import org.robolectric.annotation.Config
import kotlin.test.assertTrue
@RunWith(RobolectricTestRunner::class)
@Config(sdk = [34])
class BaseMetricScreenTest {
@get:Rule val composeTestRule = createComposeRule()
@Test
fun baseMetricScreen_displaysTitleAndNodeName() {
val nodeName = "Test Node 123"
val testData = listOf("Item 1", "Item 2")
composeTestRule.setContent {
AppTheme {
BaseMetricScreen(
onNavigateUp = {},
telemetryType = TelemetryType.DEVICE,
titleRes = Res.string.device_metrics_log,
nodeName = nodeName,
data = testData,
timeProvider = { 0.0 },
chartPart = { _, _, _, _ -> Text("Chart Placeholder") },
listPart = { _, _, _, _ -> Text("List Placeholder") },
)
}
}
// Verify Node Name is displayed (MainAppBar title)
composeTestRule.onNodeWithText(nodeName).assertIsDisplayed()
// Verify Placeholders are displayed
composeTestRule.onNodeWithText("Chart Placeholder").assertIsDisplayed()
composeTestRule.onNodeWithText("List Placeholder").assertIsDisplayed()
}
@Test
fun baseMetricScreen_refreshButtonTriggersCallback() {
var refreshClicked = false
val testData = emptyList<String>()
composeTestRule.setContent {
AppTheme {
BaseMetricScreen(
onNavigateUp = {},
telemetryType = TelemetryType.DEVICE,
titleRes = Res.string.device_metrics_log,
nodeName = "Node",
data = testData,
timeProvider = { 0.0 },
onRequestTelemetry = { refreshClicked = true },
chartPart = { _, _, _, _ -> },
listPart = { _, _, _, _ -> },
)
}
}
composeTestRule.onNodeWithTag("refresh_button").performClick()
assertTrue("Refresh callback should be triggered", refreshClicked)
}
}