meshcore-dev/meshcore_py
1
0
Fork 0
mirror of https://github.com/meshcore-dev/meshcore_py.git synced 2026-04-20 22:13:49 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #60 from agessaman/fix-sync-callbacks

Browse source 
Fix: Sync callbacks called inline in `_process_events` to eliminate `no_event_received` race
This commit is contained in:
fdlamotte 2026-02-21 07:30:25 -04:00 • committed by GitHub
commit 2c259b9743
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/meshcore/events.py
View file

@ -183,8 +183,16 @@ class EventDispatcher:
):
continue
# Fire the call back asychronously
asyncio.create_task(self._execute_callback(subscription.callback, event.clone()))
# Call sync callbacks inline so futures are resolved before asyncio.wait()
# returns - avoids the race where create_task schedules the callback after
# the waiter has already timed out with done=set().
if asyncio.iscoroutinefunction(subscription.callback):
asyncio.create_task(self._execute_callback(subscription.callback, event.clone()))
else:
try:
subscription.callback(event.clone())
except Exception as e:
logger.error(f"Error in event handler for {event.type}: {e}", exc_info=True)
self.queue.task_done()